Merge pull request #37 from MacPaw/feat/fixDeprecatedDbalPing

feat: fix use deprecated dbal connection function ping

Author: Yozhef

src/Check/DoctrineCheck.php

@@ -42,7 +42,8 @@ public function check(): array
         }
 
         try {
-            $entityManager->getConnection()->ping();
+            $con = $entityManager->getConnection();
+            $con->executeQuery($con->getDatabasePlatform()->getDummySelectSQL())->free();
         } catch (Throwable $e) {
             return array_merge($result, [self::CHECK_RESULT_KEY => false]);
         }

tests/Integration/Mock/AbstractPlatformMock.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SymfonyHealthCheckBundle\Tests\Integration\Mock;
+
+class AbstractPlatformMock
+{
+    public function getDummySelectSQL(): string
+    {
+        $expression = func_num_args() > 0 ? func_get_arg(0) : '1';
+
+        return sprintf('SELECT %s', $expression);
+    }
+}

tests/Integration/Mock/ConnectionMock.php

@@ -6,8 +6,13 @@
 
 class ConnectionMock
 {
-    public function ping(): bool
+    public function getDatabasePlatform(): AbstractPlatformMock
     {
-        return true;
+        return new AbstractPlatformMock();
+    }
+
+    public function executeQuery(): ExecuteQueryMock
+    {
+        return new ExecuteQueryMock();
     }
 }

tests/Integration/Mock/ExecuteQueryMock.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SymfonyHealthCheckBundle\Tests\Integration\Mock;
+
+class ExecuteQueryMock
+{
+    public function free(): void
+    {
+    }
+}

tests/Integration/Unit/Check/DoctrineCheckTest.php

@@ -104,7 +104,7 @@ public function testDoctrineFailPing(): void
             ->willReturn($connectionMock);
 
         $connectionMock
-            ->method('ping')
+            ->method('getDatabasePlatform')
             ->with()
             ->will(self::throwException(new Exception()));