Merge pull request #168 from idimopoulos/html5_encoding

goetas · web-flow · commit ad8802ce058a · 2019-06-15T15:49:31.000+03:00
Set default encoding in the DOMDocument object
diff --git a/src/HTML5/Parser/DOMTreeBuilder.php b/src/HTML5/Parser/DOMTreeBuilder.php
@@ -176,6 +176,7 @@ public function __construct($isFragment = false, array $options = array())
             $dt = $impl->createDocumentType('html');
             // $this->doc = \DOMImplementation::createDocument(NULL, 'html', $dt);
             $this->doc = $impl->createDocument(null, null, $dt);
+            $this->doc->encoding = !empty($options['encoding']) ? $options['encoding'] : 'UTF-8';
         }
 
         $this->errors = array();
diff --git a/test/HTML5/Parser/DOMTreeBuilderTest.php b/test/HTML5/Parser/DOMTreeBuilderTest.php
@@ -52,6 +52,7 @@ public function testDocument()
         $html = '<!DOCTYPE html><html></html>';
         $doc = $this->parse($html);
 
+        $this->assertEquals('UTF-8', $doc->encoding);
         $this->assertInstanceOf('\DOMDocument', $doc);
         $this->assertEquals('html', $doc->documentElement->tagName);
         $this->assertEquals('http://www.w3.org/1999/xhtml', $doc->documentElement->namespaceURI);

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,7 @@ public function __construct($isFragment = false, array $options = array())`
`176`	`176`	`$dt = $impl->createDocumentType('html');`
`177`	`177`	`// $this->doc = \DOMImplementation::createDocument(NULL, 'html', $dt);`
`178`	`178`	`$this->doc = $impl->createDocument(null, null, $dt);`
	`179`	`+ $this->doc->encoding = !empty($options['encoding']) ? $options['encoding'] : 'UTF-8';`
`179`	`180`	`}`
`180`	`181`
`181`	`182`	`$this->errors = array();`