Skip to content

Commit 0cbfe19

Browse files
fix: use final app reference in lambdas
1 parent 7f128d4 commit 0cbfe19

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import com.bumptech.glide.Glide;
2121
import dagger.hilt.android.AndroidEntryPoint;
22+
import com.d4rk.androidtutorials.java.data.model.PromotedApp;
2223

2324
@AndroidEntryPoint
2425
public class HomeFragment extends Fragment {
@@ -52,19 +53,20 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
5253
binding.scrollView.clearFocus();
5354
promotedContainer.clearFocus();
5455
promotedContainer.removeAllViews();
55-
java.util.List<com.d4rk.androidtutorials.java.data.model.PromotedApp> apps = state.promotedApps();
56+
java.util.List<PromotedApp> apps = state.promotedApps();
5657
int adPosition = new java.util.Random().nextInt(apps.size() + 1);
5758
for (int i = 0; i < apps.size(); i++) {
5859
if (i == adPosition) {
5960
addPromotedAd(promotedContainer);
6061
}
62+
PromotedApp app = apps.get(i);
6163
com.d4rk.androidtutorials.java.databinding.PromotedAppItemBinding itemBinding =
6264
com.d4rk.androidtutorials.java.databinding.PromotedAppItemBinding.inflate(inflater, promotedContainer, false);
63-
loadImage(apps.get(i).iconUrl(), itemBinding.appIcon);
64-
itemBinding.appName.setText(apps.get(i).name());
65+
loadImage(app.iconUrl(), itemBinding.appIcon);
66+
itemBinding.appName.setText(app.name());
6567
itemBinding.appDescription.setVisibility(android.view.View.GONE);
66-
itemBinding.appButton.setOnClickListener(v -> startActivity(homeViewModel.getPromotedAppIntent(apps.get(i).packageName())));
67-
itemBinding.shareButton.setOnClickListener(v -> shareApp(apps.get(i)));
68+
itemBinding.appButton.setOnClickListener(v -> startActivity(homeViewModel.getPromotedAppIntent(app.packageName())));
69+
itemBinding.shareButton.setOnClickListener(v -> shareApp(app));
6870
promotedContainer.addView(itemBinding.getRoot());
6971
}
7072
if (adPosition == apps.size()) {

0 commit comments

Comments
 (0)