Refactor and update UI elements

This commit introduces several changes:

- Refactored `MainUiState` and test `FakeHomeRepository` & `FakeQuizLocalDataSource` to use Java records.
- Updated various icons (`ic_arrow_back`, `ic_arrow_forward`, `ic_close`, `ic_security`) with new path data and added `ic_open_new`.
- Modified layout files for onboarding (`fragment_onboarding_data.xml`, `fragment_onboarding_done.xml`, `activity_onboarding.xml`) to adjust icon gravity and replace a LinearLayout with a MaterialButton.
- Updated text strings and removed unused ones in `strings.xml`.
- Renamed `getDailyTip()` to `dailyTip()` in `HomeRepository` and its implementations.
- Added FIXME comments for potential null pointer exceptions, deprecated methods, and unused code in several Java files.
- Changed GitHub username in `OpenSourceLicensesUtils.java`.
- Updated card view shape appearance in `fragment_onboarding_selection.xml`.
- Simplified fragment creation in `OnboardingActivity` using an enhanced switch.

Author: MihaiCristianCondrea

app/src/main/java/com/d4rk/androidtutorials/java/ads/views/NativeAdBannerView.java

@@ -39,7 +39,7 @@ public NativeAdBannerView(@NonNull Context context, @Nullable AttributeSet attrs
 
     private void init(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr) {
         if (attrs != null) {
-            TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.NativeAdBannerView, defStyleAttr, 0);
+            TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.NativeAdBannerView, defStyleAttr, 0); // FIXME: 'TypedArray' used without 'try'-with-resources statement
             layoutRes = a.getResourceId(R.styleable.NativeAdBannerView_nativeAdLayout, R.layout.ad_home_banner_large);
             a.recycle();
         }
@@ -49,7 +49,7 @@ public void loadAd(AdRequest adRequest) {
         loadAd(adRequest, null);
     }
 
-    public void loadAd(AdRequest adRequest, @Nullable AdListener listener) {
+    public void loadAd(AdRequest adRequest, @Nullable AdListener listener) { // FIXME: Parameter 'adRequest' is never used
         NativeAdLoader.load(getContext(), this, layoutRes, listener);
     }
 

app/src/main/java/com/d4rk/androidtutorials/java/data/repository/DefaultHomeRepository.java

@@ -28,7 +28,7 @@ public String getAppPlayStoreUrl(String packageName) {
     }
 
     @Override
-    public String getDailyTip() {
+    public String dailyTip() {
         return localDataSource.getDailyTip();
     }
 

app/src/main/java/com/d4rk/androidtutorials/java/data/repository/HomeRepository.java

@@ -13,7 +13,7 @@ public interface HomeRepository {
 
     String getAppPlayStoreUrl(String packageName);
 
-    String getDailyTip();
+    String dailyTip();
 
     void fetchPromotedApps(PromotedAppsCallback callback);
 

app/src/main/java/com/d4rk/androidtutorials/java/domain/home/GetDailyTipUseCase.java

@@ -16,6 +16,6 @@ public GetDailyTipUseCase(HomeRepository repository) {
      * Returns today's tip string.
      */
     public String invoke() {
-        return repository.getDailyTip();
+        return repository.dailyTip();
     }
 }

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/data/room/RoomActivity.java

@@ -89,7 +89,7 @@ protected void onDestroy() {
 
     private static class NotesAdapter extends ListAdapter<Note, NotesAdapter.NoteViewHolder> {
         private static final DiffUtil.ItemCallback<Note> DIFF_CALLBACK =
-                new DiffUtil.ItemCallback<Note>() {
+                new DiffUtil.ItemCallback<>() {
                     @Override
                     public boolean areItemsTheSame(@NonNull Note oldItem, @NonNull Note newItem) {
                         return oldItem.id == newItem.id;

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/networking/retrofit/RetrofitActivity.java

@@ -44,9 +44,9 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
 
         binding.buttonFetch.setOnClickListener(v -> {
             binding.buttonFetch.setEnabled(false);
-            api.getTodo().enqueue(new Callback<Todo>() {
+            api.getTodo().enqueue(new Callback<>() {
                 @Override
-                public void onResponse(Call<Todo> call, Response<Todo> response) {
+                public void onResponse(Call<Todo> call, Response<Todo> response) { // FIXME: Not annotated parameter overrides @EverythingIsNonNull parameter
                     if (response.isSuccessful() && response.body() != null) {
                         binding.textViewResult.setText(response.body().title);
                     } else {
@@ -56,7 +56,7 @@ public void onResponse(Call<Todo> call, Response<Todo> response) {
                 }
 
                 @Override
-                public void onFailure(Call<Todo> call, Throwable t) {
+                public void onFailure(Call<Todo> call, Throwable t) { // FIXME: Not annotated parameter overrides @EverythingIsNonNull parameter
                     binding.textViewResult.setText(R.string.snack_general_error);
                     binding.buttonFetch.setEnabled(true);
                 }

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/start/AndroidStartProjectActivity.java

@@ -25,7 +25,7 @@ protected void onCreate(Bundle savedInstanceState) {
         edgeToEdgeDelegate.applyEdgeToEdge(binding.constraintLayout);
 
         setSupportActionBar(binding.topAppBar);
-        binding.topAppBar.setNavigationOnClickListener(v -> onBackPressed());
+        binding.topAppBar.setNavigationOnClickListener(v -> onBackPressed()); // FIXME: 'onBackPressed()' is deprecated
         binding.topAppBar.setOnMenuItemClickListener(item -> {
             if (item.getItemId() == R.id.action_share) {
                 Intent sharingIntent = new Intent(Intent.ACTION_SEND);

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/textboxes/passwordbox/PasswordBoxActivity.java

@@ -62,7 +62,7 @@ private void hidePassword() {
 
     private void addKeyListener() {
         binding.buttonShowPassword.setOnClickListener(v ->
-                Snackbar.make(binding.getRoot(), binding.editText.getText(), Snackbar.LENGTH_LONG).show());
+                Snackbar.make(binding.getRoot(), binding.editText.getText(), Snackbar.LENGTH_LONG).show()); // FIXME: Argument 'binding.editText.getText()' might be null
     }
 
 

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java

@@ -107,7 +107,7 @@ private void shareTip(String tip) {
     private void shareApp(com.d4rk.androidtutorials.java.data.model.PromotedApp app) {
         android.content.Intent sharingIntent = new android.content.Intent(android.content.Intent.ACTION_SEND);
         sharingIntent.setType("text/plain");
-        String shareLink = homeViewModel.getPromotedAppIntent(app.packageName()).getData().toString();
+        String shareLink = homeViewModel.getPromotedAppIntent(app.packageName()).getData().toString(); // FIXME: Method invocation 'toString' may produce 'NullPointerException'
         String shareMessage = getString(com.d4rk.androidtutorials.java.R.string.share_message, shareLink);
         sharingIntent.putExtra(android.content.Intent.EXTRA_TEXT, shareMessage);
         sharingIntent.putExtra(android.content.Intent.EXTRA_SUBJECT, getString(com.d4rk.androidtutorials.java.R.string.share_subject));

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/main/MainActivity.java

@@ -76,21 +76,21 @@ public void onResume(@NonNull LifecycleOwner owner) {
                 if (ConsentUtils.canShowAds(MainActivity.this)) {
                     if (mBinding.adView.getVisibility() != View.VISIBLE) {
                         MobileAds.initialize(MainActivity.this);
-                        mBinding.adPlaceholder.setVisibility(View.GONE);
+                        mBinding.adPlaceholder.setVisibility(View.GONE); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
                         mBinding.adView.setVisibility(View.VISIBLE);
                         mBinding.adView.loadAd(new AdRequest.Builder().build());
                     }
                 } else {
                     mBinding.adView.setVisibility(View.GONE);
-                    mBinding.adPlaceholder.setVisibility(View.VISIBLE);
+                    mBinding.adPlaceholder.setVisibility(View.VISIBLE); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
                 }
             }
         }
     };
     private MainViewModel mainViewModel;
     private NavController navController;
     private int currentNavIndex;
-    private AppUpdateNotificationsManager appUpdateNotificationsManager;
+    private AppUpdateNotificationsManager appUpdateNotificationsManager; // FIXME: Private field 'appUpdateNotificationsManager' is assigned but never accessed
     private AppUpdateManager appUpdateManager;
     private InstallStateUpdatedListener installStateUpdatedListener;
     private long backPressedTime;
@@ -173,24 +173,24 @@ private void observeViewModel() {
             EdgeToEdgeDelegate edgeToEdgeDelegate = new EdgeToEdgeDelegate(this);
             NavigationBarView navBarView = (NavigationBarView) mBinding.navView;
             if (useRail) {
-                mBinding.navRail.setVisibility(View.VISIBLE);
+                mBinding.navRail.setVisibility(View.VISIBLE); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
                 navBarView.setVisibility(View.GONE);
                 edgeToEdgeDelegate.applyEdgeToEdge(mBinding.container);
             } else {
-                mBinding.navRail.setVisibility(View.GONE);
+                mBinding.navRail.setVisibility(View.GONE); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
                 navBarView.setVisibility(View.VISIBLE);
                 edgeToEdgeDelegate.applyEdgeToEdgeBottomBar(mBinding.container, navBarView);
 
-                navBarView.setLabelVisibilityMode(uiState.getBottomNavVisibility());
+                navBarView.setLabelVisibilityMode(uiState.bottomNavVisibility());
                 if (mBinding.adView != null) {
                     if (ConsentUtils.canShowAds(this)) {
                         MobileAds.initialize(this);
-                        mBinding.adPlaceholder.setVisibility(View.GONE);
+                        mBinding.adPlaceholder.setVisibility(View.GONE); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
                         mBinding.adView.setVisibility(View.VISIBLE);
                         mBinding.adView.loadAd(new AdRequest.Builder().build());
                     } else {
                         mBinding.adView.setVisibility(View.GONE);
-                        mBinding.adPlaceholder.setVisibility(View.VISIBLE);
+                        mBinding.adPlaceholder.setVisibility(View.VISIBLE); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
                     }
                 }
             }
@@ -200,13 +200,13 @@ private void observeViewModel() {
             if (navHostFragment != null) {
                 navController = navHostFragment.getNavController();
                 NavGraph navGraph = navController.getNavInflater().inflate(R.navigation.mobile_navigation);
-                navGraph.setStartDestination(uiState.getDefaultNavDestination());
+                navGraph.setStartDestination(uiState.defaultNavDestination());
                 navController.setGraph(navGraph);
 
                 navOrder.put(R.id.navigation_home, 0);
                 navOrder.put(R.id.navigation_android_studio, 1);
                 navOrder.put(R.id.navigation_about, 2);
-                currentNavIndex = navOrder.get(navController.getCurrentDestination().getId());
+                currentNavIndex = navOrder.get(navController.getCurrentDestination().getId()); // FIXME: Method invocation 'getId' may produce 'NullPointerException'
 
                 NavOptions forwardOptions = new NavOptions.Builder()
                         .setEnterAnim(R.anim.fragment_spring_enter)
@@ -256,13 +256,13 @@ private void observeViewModel() {
                 });
             }
 
-            if (uiState.isThemeChanged()) {
+            if (uiState.themeChanged()) {
                 recreate();
             }
         });
 
         mainViewModel.getLoadingState().observe(this, isLoading ->
-                mBinding.progressBar.setVisibility(Boolean.TRUE.equals(isLoading) ? View.VISIBLE : View.GONE));
+                mBinding.progressBar.setVisibility(Boolean.TRUE.equals(isLoading) ? View.VISIBLE : View.GONE)); // FIXME: Method invocation 'setVisibility' may produce 'NullPointerException'
     }
 
     private void setupUpdateNotifications() {
@@ -285,7 +285,8 @@ public boolean onOptionsItemSelected(android.view.MenuItem item) {
         return super.onOptionsItemSelected(item);
     }
 
-    private void checkForImmediateUpdate() {
+    // TODO: Call on onResume
+    private void checkForImmediateUpdate() { // FIXME: Private method 'checkForImmediateUpdate()' is never used
         appUpdateManager
                 .getAppUpdateInfo()
                 .addOnSuccessListener(