Skip to content

Commit 1fa5056

Browse files
Refine onboarding indicators
1 parent 68773a0 commit 1fa5056

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/onboarding/OnboardingActivity.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import android.view.View;
66
import android.widget.ImageView;
77
import android.widget.LinearLayout;
8+
import android.util.TypedValue;
89

910
import androidx.annotation.NonNull;
1011
import androidx.appcompat.app.AppCompatActivity;
@@ -81,10 +82,11 @@ public void onPageSelected(int position) {
8182
new TabLayoutMediator(binding.tabIndicator, binding.viewPager, (tab, position) -> {
8283
ImageView dot = new ImageView(this);
8384
dot.setImageResource(R.drawable.onboarding_dot_unselected);
85+
int margin = dpToPx(2);
8486
LinearLayout.LayoutParams params = new LinearLayout.LayoutParams(
8587
LinearLayout.LayoutParams.WRAP_CONTENT,
8688
LinearLayout.LayoutParams.WRAP_CONTENT);
87-
params.setMargins(8,0,8,0);
89+
params.setMargins(margin, 0, margin, 0);
8890
dot.setLayoutParams(params);
8991
tab.setCustomView(dot);
9092
}).attach();
@@ -171,6 +173,11 @@ private void updateButtons(int position) {
171173
}
172174
}
173175

176+
private int dpToPx(int dp) {
177+
return Math.round(TypedValue.applyDimension(
178+
TypedValue.COMPLEX_UNIT_DIP, dp, getResources().getDisplayMetrics()));
179+
}
180+
174181
private static class OnboardingPagerAdapter extends FragmentStateAdapter {
175182

176183
OnboardingPagerAdapter(@NonNull AppCompatActivity activity) {

app/src/main/res/drawable/onboarding_dot_selected.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<shape xmlns:android="http://schemas.android.com/apk/res/android"
33
android:shape="oval">
44
<size
5-
android:width="8dp"
6-
android:height="8dp" />
5+
android:width="12dp"
6+
android:height="12dp" />
77
<solid android:color="?attr/colorPrimary" />
88
</shape>

app/src/main/res/drawable/onboarding_dot_unselected.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
<size
55
android:width="8dp"
66
android:height="8dp" />
7-
<solid android:color="@android:color/darker_gray" />
7+
<solid android:color="?attr/colorOutline" />
88
</shape>

0 commit comments

Comments
 (0)