Skip to content

Commit 2226a32

Browse files
Merge pull request #97 from MihaiCristianCondrea/codex/ensure-app-uses-glide-for-image-loading
Use Glide for image loading
2 parents e231cff + c9a6882 commit 2226a32

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

app/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ dependencies {
6060
implementation libs.review
6161
implementation libs.app.update
6262
implementation libs.volley
63+
implementation libs.glide
6364

6465
// Firebase
6566
implementation platform(libs.firebase.bom)
@@ -98,6 +99,7 @@ dependencies {
9899
annotationProcessor libs.hilt.compiler
99100
implementation libs.androidx.room.runtime
100101
annotationProcessor libs.androidx.room.compiler
102+
annotationProcessor libs.glide.compiler
101103

102104
// Testing
103105
testImplementation libs.junit

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import me.zhanghai.android.fastscroll.FastScrollerBuilder;
1818

19+
import com.bumptech.glide.Glide;
1920
import dagger.hilt.android.AndroidEntryPoint;
2021

2122
@AndroidEntryPoint
@@ -103,14 +104,9 @@ private void shareApp(com.d4rk.androidtutorials.java.data.model.PromotedApp app)
103104
}
104105

105106
private void loadImage(String url, android.widget.ImageView imageView) {
106-
com.android.volley.toolbox.ImageRequest request = new com.android.volley.toolbox.ImageRequest(
107-
url,
108-
imageView::setImageBitmap,
109-
0,
110-
0,
111-
android.widget.ImageView.ScaleType.CENTER_INSIDE,
112-
android.graphics.Bitmap.Config.ARGB_8888,
113-
error -> {});
114-
com.android.volley.toolbox.Volley.newRequestQueue(requireContext()).add(request);
107+
Glide.with(imageView.getContext())
108+
.load(url)
109+
.centerInside()
110+
.into(imageView);
115111
}
116112
}

gradle/libs.versions.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ playServicesAds = "24.5.0"
3030
codeview = "1.3.9"
3131
hilt = "2.57.1"
3232
room = "2.6.1"
33+
glide = "4.16.0"
3334

3435
[libraries]
3536
aboutlibraries = { module = "com.mikepenz:aboutlibraries", version.ref = "aboutlibraries" }
@@ -70,3 +71,5 @@ hilt-android = { module = "com.google.dagger:hilt-android", version.ref = "hilt"
7071
hilt-compiler = { module = "com.google.dagger:hilt-android-compiler", version.ref = "hilt" }
7172
androidx-room-runtime = { module = "androidx.room:room-runtime", version.ref = "room" }
7273
androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "room" }
74+
glide = { module = "com.github.bumptech.glide:glide", version.ref = "glide" }
75+
glide-compiler = { module = "com.github.bumptech.glide:compiler", version.ref = "glide" }

0 commit comments

Comments
 (0)