Skip to content

Commit 6f39181

Browse files
author
Mihai-Cristian Condrea
committed
chore: Add FIXME comments for unused and potentially buggy code
This commit adds `FIXME` comments to several parts of the codebase to highlight areas that require attention. Specifically, it marks: * Unused methods in `MainViewModel`, `SettingsViewModel`, `SupportViewModel`, and `ReviewHelper`. * A potential null argument being passed in `DefaultSupportRepository`.
1 parent c5bbd66 commit 6f39181

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

app/src/main/java/com/d4rk/androidtutorials/java/data/repository/DefaultSupportRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public BillingFlowLauncher initiatePurchase(String productId) {
131131
Collections.singletonList(
132132
BillingFlowParams.ProductDetailsParams.newBuilder()
133133
.setProductDetails(details)
134-
.setOfferToken(finalOfferToken)
134+
.setOfferToken(finalOfferToken) // FIXME: Argument 'finalOfferToken' might be null
135135
.build()
136136
);
137137

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/main/MainViewModel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,14 @@ public void applySettings(String[] themeValues,
9999
/**
100100
* Checks if we need to show the startup screen.
101101
*/
102-
public boolean shouldShowStartupScreen() {
102+
public boolean shouldShowStartupScreen() { // FIXME: Method 'shouldShowStartupScreen()' is never used
103103
return shouldShowStartupScreenUseCase.invoke();
104104
}
105105

106106
/**
107107
* Mark startup screen as shown.
108108
*/
109-
public void markStartupScreenShown() {
109+
public void markStartupScreenShown() { // FIXME: Method 'markStartupScreenShown()' is never used
110110
markStartupScreenShownUseCase.invoke();
111111
}
112112

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/settings/SettingsViewModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public String getDarkMode() {
7070
return getDarkModeUseCase.invoke();
7171
}
7272

73-
public void setConsentAccepted(boolean accepted) {
73+
public void setConsentAccepted(boolean accepted) { // FIXME: Method 'setConsentAccepted(boolean)' is never used
7474
setConsentAcceptedUseCase.invoke(accepted);
7575
}
7676
}

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/support/SupportViewModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public SupportRepository.BillingFlowLauncher initiatePurchase(String productId)
4747
return initiatePurchaseUseCase.invoke(productId);
4848
}
4949

50-
public AdRequest initMobileAds() {
50+
public AdRequest initMobileAds() { // FIXME: Method 'initMobileAds()' is never used
5151
return initMobileAdsUseCase.invoke();
5252
}
5353
}

app/src/main/java/com/d4rk/androidtutorials/java/utils/ReviewHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public static void launchInAppReviewIfEligible(Activity activity,
2525
launchReview(activity, onReviewLaunched);
2626
}
2727

28-
public static void forceLaunchInAppReview(Activity activity) {
28+
public static void forceLaunchInAppReview(Activity activity) { // FIXME: Method 'forceLaunchInAppReview(android.app.Activity)' is never used
2929
launchReview(activity, null);
3030
}
3131

0 commit comments

Comments
 (0)