Skip to content

Conversation

@aaronsky
Copy link
Contributor

@aaronsky aaronsky commented Nov 10, 2025

Fixes #3130.

Redoes #3182 (and potentially fixes unresolved comments on #3185).

The StoreKit Testing configuration file has a peculiar requirement that has no precedent in the rules. The file's path in the scheme must be relative to the xcshareddata/xcschemes directory the scheme is under, not the scheme itself (so one level shallower than you'd expect). Making the path relative to the project fails, and making it absolute crashes Xcode.

A prior iteration of this PR attempted to relativize the path in Starlark, but exposed some safety shortcomings. In knowing the absolute path of both the scheme directory and the configuration file, doing this work in the generator gives us slightly improved safety guarantees at the cost of performance. To this author, there is too much ambiguity between the paths of either location without this information, since the files can potentially exist in independent file trees under a workspace.

Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
@aaronsky aaronsky force-pushed the aaronsky/3130-support-storekit-configuration-run-action branch from 29af24d to c3f2a3f Compare November 10, 2025 01:56
@aaronsky aaronsky marked this pull request as ready for review November 10, 2025 02:00
@aaronsky aaronsky requested a review from a team as a code owner November 10, 2025 02:01
…-run-action

Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
@aaronsky aaronsky enabled auto-merge (squash) November 14, 2025 00:35
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
@aaronsky
Copy link
Contributor Author

@brentleyjones I moved the path relativization back into the generator, and updated tests. I couldn't find a good heuristic to use as an anchor in the Starlark, whereas we have the full workspace path in the generator. Hopefully this doesn't result in an intolerable regression of project incrementality. Please take another look at your soonest convenience.

Copy link
Contributor

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for ‎tools/generators/xcschemes changes, or minimally the relative path logic part.

Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
@brentleyjones brentleyjones merged commit 4c0a71b into MobileNativeFoundation:main Nov 19, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Support StoreKit Configuration files in generated xcschemes.

2 participants