-
Notifications
You must be signed in to change notification settings - Fork 112
Support StoreKit Configuration setting in xcscheme Run action #3245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support StoreKit Configuration setting in xcscheme Run action #3245
Conversation
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
29af24d to
c3f2a3f
Compare
…-run-action Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
|
@brentleyjones I moved the path relativization back into the generator, and updated tests. I couldn't find a good heuristic to use as an anchor in the Starlark, whereas we have the full workspace path in the generator. Hopefully this doesn't result in an intolerable regression of project incrementality. Please take another look at your soonest convenience. |
brentleyjones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for tools/generators/xcschemes changes, or minimally the relative path logic part.
tools/generators/xcschemes/src/Generator/CreateCustomSchemeInfos.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
4c0a71b
into
MobileNativeFoundation:main
Fixes #3130.
Redoes #3182 (and potentially fixes unresolved comments on #3185).
The StoreKit Testing configuration file has a peculiar requirement that has no precedent in the rules. The file's path in the scheme must be relative to the
xcshareddata/xcschemesdirectory the scheme is under, not the scheme itself (so one level shallower than you'd expect). Making the path relative to the project fails, and making it absolute crashes Xcode.A prior iteration of this PR attempted to relativize the path in Starlark, but exposed some safety shortcomings. In knowing the absolute path of both the scheme directory and the configuration file, doing this work in the generator gives us slightly improved safety guarantees at the cost of performance. To this author, there is too much ambiguity between the paths of either location without this information, since the files can potentially exist in independent file trees under a workspace.