runtime getLatestVersion() fix plus unit test

Author: supertick

src/main/java/org/myrobotlab/service/Runtime.java

@@ -1487,8 +1487,13 @@ public static String getVersion() {
   public static String getLatestVersion() {
     String latest = "https://myrobotlab-repo.s3.us-east-1.amazonaws.com/latestVersion.txt";
     byte[] b = Http.get(latest);
-    String version = (b == null) ? "unknown" : new String(b);
-    return version;
+
+    String v = "{\"tag_name\":\"unknown\"}";
+    if (b != null) {
+      v = new String(b);
+    }
+    Map githubVersion = (Map) CodecUtils.fromJson(v);
+    return ((String) githubVersion.get("tag_name")).replaceFirst("^v", "");
   }
 
   // FIXME - shouldn't this be in platform ???

src/test/java/org/myrobotlab/service/RuntimeTest.java

@@ -1,10 +1,8 @@
 package org.myrobotlab.service;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
-import java.util.Date;
 import java.util.List;
 import java.util.Map;
 
@@ -101,7 +99,6 @@ public void testRuntimeLocale() {
     assertEquals("fr-FR", l.toString());
 
   }
-  
 
   @Test
   public void testGetDescribeMessage() {
@@ -113,4 +110,33 @@ public void testGetDescribeMessage() {
     assertEquals("Incorrect UUID in describe query", "testUUID", ((DescribeQuery) msg.data[1]).uuid);
   }
 
+  @Test
+  public void testGetLatestVersion() {
+    if (hasInternet()) {
+      try {
+        String latestVersion = Runtime.getLatestVersion();
+        Assert.assertNotNull("Latest version should not be null", latestVersion);
+        Assert.assertFalse("Latest version should not be empty", latestVersion.isEmpty());
+
+        // The version should not contain the leading 'v' since getLatestVersion
+        // removes it
+        Assert.assertFalse("Version should not start with 'v'", latestVersion.startsWith("v"));
+
+        // Version should follow semantic versioning pattern (x.y.z)
+        String[] versionParts = latestVersion.split("\\.");
+        Assert.assertTrue("Version should have at least 2 parts (major.minor)", versionParts.length >= 2);
+
+        log.info("Latest version retrieved: {}", latestVersion);
+      } catch (Exception e) {
+        // If remote service is unavailable, the method should still return
+        // "unknown"
+        // rather than throwing an exception
+        log.error("testGetLatestVersion failed", e);
+        Assert.fail("getLatestVersion should not throw exceptions, but return 'unknown' on failure");
+      }
+    } else {
+      log.info("Skipping testGetLatestVersion - no internet connection");
+    }
+  }
+
 }