Don't show error message on startup unless it is real json

Author: SinghRajenM

NppJSONViewer/NppJsonViewer/JsonViewDlg.cpp

@@ -159,7 +159,18 @@ void JsonViewDlg::DrawJsonTree()
         auto res = PopulateTreeUsingSax(rootNode, txtForParsing);
         if (res.has_value())
         {
-            ShowMessage(JSON_ERROR_TITLE, res.value(), MB_OK | MB_ICONERROR);
+            // This is the case when Notepad++ has JsonViewer Window opened for previous intance
+            // Later on second launch, don't show the error message as this could be some text file
+            // If it is real json file but has some error, then there must be more than 1 node exist.
+
+            if (!m_IsNppReady && m_hTreeView->GetNodeCount() <= 1)
+            {
+                m_hTreeView->InsertNode(JSON_ERR_VALIDATE, NULL, rootNode);
+            }
+            else
+            {
+                ShowMessage(JSON_ERROR_TITLE, res.value(), MB_OK | MB_ICONERROR);
+            }
         }
     }
 
@@ -585,8 +596,7 @@ auto JsonViewDlg::CopyPath() const -> std::wstring
 
 int JsonViewDlg::ShowMessage(const std::wstring &title, const std::wstring &msg, int flag, bool bDontShow)
 {
-    // Don't show message untill NPP ready message is received.
-    return (!bDontShow && m_IsNppReady) ? ::MessageBox(_hParent, msg.c_str(), title.c_str(), flag) : IDOK;
+    return !bDontShow ? ::MessageBox(_hParent, msg.c_str(), title.c_str(), flag) : IDOK;
 }
 
 void JsonViewDlg::ReportError(const Result &result)

NppJSONViewer/NppJsonViewer/NppJsonPlugin.cpp

@@ -55,7 +55,7 @@ void NppJsonPlugin::ProcessNotification(const SCNotification *notifyCode)
 
     case NPPN_BUFFERACTIVATED:
     {
-        if (m_pJsonViewDlg && !m_bAboutToClose)
+        if (m_pJsonViewDlg && m_bNppReady && !m_bAboutToClose)
         {
             m_pJsonViewDlg->HandleTabActivated();
         }
@@ -70,12 +70,12 @@ void NppJsonPlugin::ProcessNotification(const SCNotification *notifyCode)
 
     case NPPN_READY:
     {
-        m_bNppReady = true;
         // This is work arround where dialog does not show tree on launch
         if (m_pJsonViewDlg && m_pJsonViewDlg->isVisible() && !m_bAboutToClose)
         {
             ::SendMessage(m_pJsonViewDlg->getHSelf(), WM_COMMAND, IDC_BTN_REFRESH, 0);
         }
+        m_bNppReady = true;
         break;
     }