When file type is json, then error message is shown twice on npp launch if viewer dock was kept once on previous instance

Author: SinghRajenM

NppJSONViewer/NppJsonViewer/JsonViewDlg.cpp

@@ -8,9 +8,10 @@
 #include <format>
 
 
-JsonViewDlg::JsonViewDlg(HINSTANCE hIntance, const NppData &nppData, int nCmdId, std::shared_ptr<Setting> &pSetting)
-    : m_NppData(nppData)
-    , DockingDlgInterface(IDD_TREEDLG)
+JsonViewDlg::JsonViewDlg(HINSTANCE hIntance, const NppData &nppData, const bool &isReady, int nCmdId, std::shared_ptr<Setting> &pSetting)
+    : DockingDlgInterface(IDD_TREEDLG)
+    , m_NppData(nppData)
+    , m_IsNppReady(isReady)
     , m_nDlgId(nCmdId)
     , m_Editor(std::make_unique<ScintillaEditor>(nppData))
     , m_hTreeView(std::make_unique<TreeViewCtrl>())
@@ -576,7 +577,8 @@ auto JsonViewDlg::CopyPath() const -> std::wstring
 
 int JsonViewDlg::ShowMessage(const std::wstring &title, const std::wstring &msg, int flag, bool bDontShow)
 {
-    return !bDontShow ? ::MessageBox(_hParent, msg.c_str(), title.c_str(), flag) : IDOK;
+    // Don't show message untill NPP ready message is received.
+    return (!bDontShow && m_IsNppReady) ? ::MessageBox(_hParent, msg.c_str(), title.c_str(), flag) : IDOK;
 }
 
 void JsonViewDlg::ReportError(const Result &result)

NppJSONViewer/NppJsonViewer/JsonViewDlg.h

@@ -20,7 +20,7 @@ class JsonViewDlg : public DockingDlgInterface
     };
 
 public:
-    JsonViewDlg(HINSTANCE hIntance, const NppData &nppData, int nCmdId, std::shared_ptr<Setting> &pSetting);
+    JsonViewDlg(HINSTANCE hIntance, const NppData &nppData, const bool &isReady, int nCmdId, std::shared_ptr<Setting> &pSetting);
     virtual ~JsonViewDlg();
 
     void ShowDlg(bool bShow);
@@ -73,9 +73,10 @@ class JsonViewDlg : public DockingDlgInterface
     virtual INT_PTR CALLBACK run_dlgProc(UINT message, WPARAM wParam, LPARAM lParam);
 
 private:
-    int     m_nDlgId      = -1;
-    NppData m_NppData     = {};
-    HICON   m_hBtnIcon[4] = {};
+    int         m_nDlgId      = -1;
+    NppData     m_NppData     = {};
+    HICON       m_hBtnIcon[4] = {};
+    const bool &m_IsNppReady;
 
     // To handle doc panel resizing
     LONG m_lfDeltaWidth          = 0;

NppJSONViewer/NppJsonViewer/NppJsonPlugin.cpp

@@ -70,6 +70,7 @@ void NppJsonPlugin::ProcessNotification(const SCNotification *notifyCode)
 
     case NPPN_READY:
     {
+        m_bNppReady = true;
         // This is work arround where dialog does not show tree on launch
         if (m_pJsonViewDlg && m_pJsonViewDlg->isVisible() && !m_bAboutToClose)
         {
@@ -101,7 +102,7 @@ void NppJsonPlugin::SetMenuIcon()
 {
     if (m_hMenuIcon.hToolbarIcon || m_hMenuIcon.hToolbarBmp)
     {
-        toolbarIcons tbIcon;
+        toolbarIcons tbIcon {};
         tbIcon.hToolbarBmp  = m_hMenuIcon.hToolbarBmp;
         tbIcon.hToolbarIcon = m_hMenuIcon.hToolbarIcon;
         auto nCommandId     = m_shortcutCommands.GetCommandID(CallBackID::SHOW_DOC_PANEL);
@@ -155,7 +156,7 @@ void NppJsonPlugin::ConstructJsonDlg()
     {
         ConstructSetting();
         auto nCmdId    = m_shortcutCommands.GetCommandID(CallBackID::SHOW_DOC_PANEL);
-        m_pJsonViewDlg = std::make_unique<JsonViewDlg>(reinterpret_cast<HINSTANCE>(m_hModule), m_NppData, nCmdId, m_pSetting);
+        m_pJsonViewDlg = std::make_unique<JsonViewDlg>(reinterpret_cast<HINSTANCE>(m_hModule), m_NppData, m_bNppReady, nCmdId, m_pSetting);
     }
 }
 

NppJSONViewer/NppJsonViewer/NppJsonPlugin.h

@@ -87,6 +87,7 @@ class NppJsonPlugin
     NppData                      m_NppData = {};
     std::wstring                 m_configPath;
     bool                         m_bAboutToClose = false;
+    bool                         m_bNppReady     = false;
     std::unique_ptr<AboutDlg>    m_pAboutDlg     = nullptr;
     std::unique_ptr<JsonViewDlg> m_pJsonViewDlg  = nullptr;
     std::unique_ptr<SettingsDlg> m_pSettingsDlg  = nullptr;