Merge branch 'develop' into feature/16-Add-Functionality-for-Diurnal-Readings

Author: TinasheMTapera

.vscode/settings.json

@@ -0,0 +1,5 @@
+{
+    "python.terminal.activateEnvInCurrentTerminal": true,
+    "quarto.path": "",
+    "quarto.usePipQuarto": false
+}

data

@@ -0,0 +1 @@
+/n/holylabs/LABS/cgolden_lab/Lab/projects/era5_database/era5_sandbox/data

notes/01_download_raw_data.ipynb

@@ -61,7 +61,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 5,
+   "execution_count": null,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -71,6 +71,8 @@
     "    )->bool:\n",
     "    '''\n",
     "    Check that the query is valid\n",
+    "    ###TODO Not a good idea to overwrite components of the query body because the user may believe something and the function may give somehting else back\n",
+    "     Better to just tell them something is wrong\n",
     "    '''\n",
     "\n",
     "    required_keys = ['product_type', 'variable', 'year', 'month', 'day', 'time', 'area', 'data_format', 'download_format']\n",
@@ -308,7 +310,8 @@
     "#| export\n",
     "@hydra.main(config_path=\"../../conf\", config_name=\"config\", version_base=None)\n",
     "def main(cfg: DictConfig) -> None:\n",
-    "    download_raw_era5(cfg=cfg)"
+    "    download_raw_era5(cfg=cfg)\n",
+    "    # better approach would be to have the function only use the specific arguments of the config\n"
    ]
   },
   {