[None][infra] add attribution files for release/1.1 #9495
Conversation
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87
changed the title
📝 WalkthroughWalkthroughUpdates pre-commit configuration to extend exclusion patterns for large file checks and codespell. Adds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.pre-commit-config.yaml(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: xinhe-nv
Repo: NVIDIA/TensorRT-LLM PR: 8534
File: scripts/format_test_list.py:1-6
Timestamp: 2025-10-22T06:53:47.017Z
Learning: The file `scripts/format_test_list.py` in the TensorRT-LLM repository does not require the NVIDIA Apache-2.0 copyright header.
Learnt from: galagam
Repo: NVIDIA/TensorRT-LLM PR: 6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
Learnt from: venkywonka
Repo: NVIDIA/TensorRT-LLM PR: 6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
.pre-commit-config.yaml (1)
21-21: Verify regex pattern for check-added-large-files exclusion.Line 21 uses regex syntax
ATTRIBUTIONS-.*\.mdto exclude attribution files from large-file checks. The pattern is correct, but ensure it matches the actual file naming convention for attribution files in this release.
| - tomli | ||
| # add ignore words list | ||
| args: ["-L", "Mor,ans,thirdparty", "--skip", "security_scanning/*"] | ||
| args: ["-L", "Mor,ans,thirdparty", "--skip", "ATTRIBUTIONS-*.md,*.svg", "--skip", "security_scanning/*"] |
There was a problem hiding this comment.
🧩 Analysis chain
Script executed:
#!/bin/bash
# First, let's inspect the .pre-commit-config.yaml file to see lines around 21 and 69
echo "=== Inspecting .pre-commit-config.yaml ==="
if [ -f ".pre-commit-config.yaml" ]; then
echo "--- Lines 15-25 (context for line 21) ---"
sed -n '15,25p' .pre-commit-config.yaml | cat -n
echo ""
echo "--- Lines 65-75 (context for line 69) ---"
sed -n '65,75p' .pre-commit-config.yaml | cat -n
else
echo "File not found"
fi
echo ""
echo "=== Checking codespell help for --skip documentation ==="
which codespell > /dev/null 2>&1 && codespell --help | grep -A 10 "\-\-skip" || echo "codespell not installed, checking online documentation"Repository: NVIDIA/TensorRT-LLM
<shell_result>
Repository: NVIDIA/TensorRT-LLM
Script execution failed with unrecoverable error: [CAPABILITY:RUN_SHELL_SCRIPT] Failed to clone repository NVIDIA/TensorRT-LLM: Clone operation failed
</shell_result>
codespell --skip multiple arguments behavior documentation
<web_search_result>
--skip accepts a single comma-separated list of glob patterns (e.g. --skip=".po,.ts,./vendor/*"). Patterns are parsed as one option value, so quote it (or escape commas) when passing multiple entries on the shell to avoid splitting. Documentation: GitHub README and the man page. [1][2]
Sources:
[1] codespell README (--skip examples).
[2] codespell man page (--skip, description).
</web_search_result>
codespell multiple --skip arguments override last one
<web_search_result>
You're seeing that because codespell treats --skip as a single option that takes a comma-separated list, and later occurrences overwrite earlier ones (command-line options replace previous values). Provide all patterns in one --skip value (or put them in your config file / .codespellrc which supports multiple skip entries). Example:
- Single CLI: codespell --skip ".po,.ts,./src/3rdParty,./src/Test"
- Config (.codespellrc or pyproject.toml): skip = '.po,.ts,./src/3rdParty,./src/Test'
References: codespell CLI/docs and project README. [1][2]
Sources:
[1] codespell GitHub README (options and config behavior). [2] codespell manpage / --skip description.
</web_search_result>
Consolidate multiple --skip arguments into a single comma-separated list.
Codespell's --skip option expects a single comma-separated list of glob patterns. When multiple --skip arguments are specified (as on line 69), later occurrences override earlier ones—meaning the first --skip "ATTRIBUTIONS-*.md,*.svg" is ignored, and only --skip "security_scanning/*" takes effect. This likely leaves ATTRIBUTIONS-*.md and *.svg files unchecked.
Combine both patterns into a single argument:
args: ["-L", "Mor,ans,thirdparty", "--skip", "ATTRIBUTIONS-*.md,*.svg,security_scanning/*"]
Additionally, verify consistency with any --skip patterns used elsewhere in the config (e.g., line 21) to ensure uniform glob vs. regex syntax.
🤖 Prompt for AI Agents
In .pre-commit-config.yaml around line 69, multiple --skip args are used which
causes earlier skip patterns to be overridden; consolidate the skip patterns
into a single --skip argument containing a comma-separated list (e.g., combine
ATTRIBUTIONS-*.md, *.svg and security_scanning/* into one --skip value) and
update the args array accordingly; also scan other places in the file (e.g.,
line 21) for --skip usage and make them consistent in using comma-separated glob
patterns rather than multiple --skip entries.
2 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.