Skip to content

Conversation

@fredricz-20070104
Copy link
Collaborator

@fredricz-20070104 fredricz-20070104 commented Nov 27, 2025

Summary by CodeRabbit

  • Chores
    • Added new performance benchmark configuration and expanded test coverage for evaluation scenarios.

✏️ Tip: You can customize this high-level summary in your review settings.

Add GB 200 WIDEEP test case for RCCA 5422621

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Walkthrough

This change adds a new performance benchmark configuration for deepseek-r1-fp4 with specific parameters (1k context, 2 gen, 48 dep, bs16) and registers it in the test list to be executed as part of the perf disagg wideep benchmark suite.

Changes

Cohort / File(s) Summary
Benchmark Configuration
tests/integration/defs/perf/disagg/test_configs/wideep/perf/deepseek-r1-fp4_1k1k_ctx2_gen1_dep48_bs16_eplb288_mtp3_ccb-DEFAULT.yaml
New YAML configuration file defining a complete benchmarking run with metadata, SLURM job parameters, hardware allocation (tensor\_parallel\_size=48 in gen), profiling toggles, and worker configurations for generation and context processing.
Test List Update
tests/integration/defs/perf/disagg/testlist/wideep.txt
Adds a new test case entry for the deepseek-r1-fp4 benchmark with the DEFAULT CCB configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required sections (Description and Test Coverage) outlined in the template, though it touches the core intent. Expand the description with a detailed explanation of what the test case covers and explicitly list the test coverage (reference the new test entry).
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly references the NVBugs ID and describes a specific test case addition, matching the primary change in the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fredricz-20070104 fredricz-20070104 changed the title [https://nvbugs/5422621][test]Add GB 200 WIDEEP test case for RCCA 5422621 [https://nvbugs/5422621][test] Add GB 200 WIDEEP test case for RCCA 5422621 Nov 27, 2025
@fredricz-20070104
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25939 [ run ] triggered by Bot. Commit: f92e597

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25939 [ run ] completed with state FAILURE. Commit: f92e597
/LLM/main/L0_MergeRequest_PR pipeline #19670 completed with status: 'FAILURE'

@fredricz-20070104 fredricz-20070104 force-pushed the feature/rcca_5561153 branch 2 times, most recently from 90ac793 to 4b93904 Compare November 27, 2025 05:56
add two cases for RCCA 5561153

Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants