chore: nx migrate @nativescript/plugin-tools

NathanWalker · NathanWalker · commit 22ecb5aff1bb · 2025-01-29T08:45:06.000-08:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -24,12 +24,18 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier", "plugin:@nx/typescript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": ["references.d.ts"],
diff --git a/.prettierignore b/.prettierignore
@@ -4,4 +4,5 @@
 /coverage
 native-src
 
-/.nx/cache
+/.nx/cache
+/.nx/workspace-data
diff --git a/apps/demo-angular/package.json b/apps/demo-angular/package.json
@@ -14,7 +14,7 @@
     "@nativescript/mlkit-custom-object-detection": "file:../../dist/packages/mlkit-custom-object-detection"
   },
   "devDependencies": {
-    "@nativescript/android": "8.8.0-alpha.7",
-    "@nativescript/ios": "~8.7.0"
+    "@nativescript/android": "~8.8.0",
+    "@nativescript/ios": "~8.8.0"
   }
 }
diff --git a/apps/demo-angular/project.json b/apps/demo-angular/project.json
@@ -12,31 +12,8 @@
         "production": true,
         "uglify": true,
         "release": true,
-        "forDevice": true
-      },
-      "dependsOn": [
-        {
-          "target": "build.all",
-          "dependencies": true
-        }
-      ]
-    },
-    "ios": {
-      "executor": "@nativescript/nx:build",
-      "options": {
-        "platform": "ios"
-      },
-      "dependsOn": [
-        {
-          "target": "build.all",
-          "dependencies": true
-        }
-      ]
-    },
-    "android": {
-      "executor": "@nativescript/nx:build",
-      "options": {
-        "platform": "android"
+        "forDevice": true,
+        "tsConfig": "apps/demo-angular/tsconfig.json"
       },
       "dependsOn": [
         {
@@ -46,13 +23,21 @@
       ]
     },
     "clean": {
-      "executor": "@nativescript/nx:build",
-      "options": {
-        "clean": true
-      }
+      "executor": "@nativescript/nx:clean",
+      "options": {}
     },
     "lint": {
       "executor": "@nx/eslint:lint"
+    },
+    "debug": {
+      "executor": "@nativescript/nx:debug",
+      "options": {
+        "noHmr": true,
+        "uglify": false,
+        "release": false,
+        "forDevice": false,
+        "prepare": false
+      }
     }
   }
 }
diff --git a/apps/demo/package.json b/apps/demo/package.json
@@ -17,7 +17,7 @@
     "@nativescript/mlkit-custom-object-detection": "file:../../packages/mlkit-custom-object-detection"
   },
   "devDependencies": {
-    "@nativescript/android": "8.8.0-alpha.8",
-    "@nativescript/ios": "~8.7.0"
+    "@nativescript/android": "~8.8.0",
+    "@nativescript/ios": "~8.8.0"
   }
 }
diff --git a/apps/demo/project.json b/apps/demo/project.json
@@ -12,33 +12,8 @@
         "production": true,
         "uglify": true,
         "release": true,
-        "forDevice": true
-      },
-      "dependsOn": [
-        {
-          "target": "build.all",
-          "dependencies": true
-        }
-      ]
-    },
-    "ios": {
-      "executor": "@nativescript/nx:build",
-      "options": {
-        "platform": "ios",
-        "noHmr": true
-      },
-      "dependsOn": [
-        {
-          "target": "build.all",
-          "dependencies": true
-        }
-      ]
-    },
-    "android": {
-      "executor": "@nativescript/nx:build",
-      "options": {
-        "platform": "android",
-        "noHmr": true
+        "forDevice": true,
+        "tsConfig": "apps/demo/tsconfig.json"
       },
       "dependsOn": [
         {
@@ -48,13 +23,21 @@
       ]
     },
     "clean": {
-      "executor": "@nativescript/nx:build",
-      "options": {
-        "clean": true
-      }
+      "executor": "@nativescript/nx:clean",
+      "options": {}
     },
     "lint": {
       "executor": "@nx/eslint:lint"
+    },
+    "debug": {
+      "executor": "@nativescript/nx:debug",
+      "options": {
+        "noHmr": true,
+        "uglify": false,
+        "release": false,
+        "forDevice": false,
+        "prepare": false
+      }
     }
   }
 }
diff --git a/migrations.json b/migrations.json
@@ -1,12 +1,7 @@
 {
   "migrations": [
-    {
-      "cli": "nx",
-      "version": "5.2.0",
-      "description": "Migrate tools to 5.2.0",
-      "implementation": "./src/migrations/update-5-2-0/update-5-2-0",
-      "package": "@nativescript/plugin-tools",
-      "name": "update-to-5.2.0"
-    }
+    { "cli": "nx", "version": "5.3.0", "description": "Migrate tools to 5.3.0", "implementation": "./src/migrations/update-5-3-0/update-5-3-0", "package": "@nativescript/plugin-tools", "name": "update-to-5.3.0" },
+    { "cli": "nx", "version": "5.4.0", "description": "Migrate tools to 5.4.0", "implementation": "./src/migrations/update-5-4-0/update-5-4-0", "package": "@nativescript/plugin-tools", "name": "update-to-5.4.0" },
+    { "cli": "nx", "version": "5.5.0", "description": "Migrate tools to 5.5.0", "implementation": "./src/migrations/update-5-5-0/update-5-5-0", "package": "@nativescript/plugin-tools", "name": "update-to-5.5.0" }
   ]
 }
diff --git a/nx.json b/nx.json
@@ -38,5 +38,21 @@
   "useDaemonProcess": false,
   "parallel": 1,
   "useInferencePlugins": false,
-  "defaultBase": "master"
+  "defaultBase": "master",
+  "release": {
+    "releaseTagPattern": "{version}-{projectName}",
+    "projects": ["packages/*"],
+    "projectsRelationship": "independent",
+    "changelog": {
+      "workspaceChangelog": false,
+      "projectChangelogs": {
+        "renderOptions": {
+          "authors": true,
+          "commitReferences": true,
+          "versionTitleDate": true
+        }
+      }
+    }
+  },
+  "useLegacyCache": true
 }
diff --git a/package.json b/package.json
@@ -16,29 +16,29 @@
   },
   "private": true,
   "devDependencies": {
-    "@angular/animations": "^17.0.0",
-    "@angular/common": "^17.0.0",
-    "@angular/compiler": "^17.0.0",
-    "@angular/compiler-cli": "^17.0.0",
-    "@angular/core": "^17.0.0",
-    "@angular/forms": "^17.0.0",
-    "@angular/platform-browser": "^17.0.0",
-    "@angular/platform-browser-dynamic": "^17.0.0",
-    "@angular/router": "^17.0.0",
-    "@nativescript/angular": "^17.0.0",
-    "@nativescript/core": "~8.7.0",
-    "@nativescript/plugin-tools": "5.2.5",
-    "@nativescript/types": "~8.7.0",
+    "@angular/animations": "^19.0.0",
+    "@angular/common": "^19.0.0",
+    "@angular/compiler": "^19.0.0",
+    "@angular/compiler-cli": "^19.0.0",
+    "@angular/core": "^19.0.0",
+    "@angular/forms": "^19.0.0",
+    "@angular/platform-browser": "^19.0.0",
+    "@angular/platform-browser-dynamic": "^19.0.0",
+    "@angular/router": "^19.0.0",
+    "@nativescript/angular": "^19.0.0",
+    "@nativescript/core": "~8.8.0",
+    "@nativescript/plugin-tools": "5.5.1",
+    "@nativescript/types": "~8.8.0",
     "@nativescript/webpack": "~5.0.5",
-    "@ngtools/webpack": "^17.0.0",
+    "@ngtools/webpack": "^19.0.0",
     "husky": "~9.0.0",
     "nativescript-vue": "~2.9.0",
     "nativescript-vue-template-compiler": "~2.9.0",
-    "ng-packagr": "^17.0.0",
+    "ng-packagr": "^19.0.0",
     "rxjs": "~7.8.0",
-    "typescript": "~5.4.0",
-    "zone.js": "~0.14.0",
-    "@angular-devkit/build-angular": "^17.0.0"
+    "typescript": "~5.6.0",
+    "zone.js": "~0.15.0",
+    "@angular-devkit/build-angular": "^19.0.0"
   },
   "lint-staged": {
     "**/*.{js,ts,scss,json,html}": [
diff --git a/tools/workspace-scripts.js b/tools/workspace-scripts.js
@@ -23,15 +23,15 @@ module.exports = {
       },
       demo: {
         clean: {
-          script: 'nx run demo:clean',
+          script: 'nx clean demo',
           description: '⚆  Clean  🧹',
         },
         ios: {
-          script: 'nx run demo:ios',
+          script: 'nx debug demo ios',
           description: '⚆  Run iOS  ',
         },
         android: {
-          script: 'nx run demo:android',
+          script: 'nx debug demo android',
           description: '⚆  Run Android  🤖',
         },
       },
@@ -41,15 +41,15 @@ module.exports = {
       },
       'demo-angular': {
         clean: {
-          script: 'nx run demo-angular:clean',
+          script: 'nx clean demo-angular',
           description: '⚆  Clean  🧹',
         },
         ios: {
-          script: 'nx run demo-angular:ios',
+          script: 'nx debug demo-angular ios',
           description: '⚆  Run iOS  ',
         },
         android: {
-          script: 'nx run demo-angular:android',
+          script: 'nx debug demo-angular android',
           description: '⚆  Run Android  🤖',
         },
       },
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -21,6 +21,7 @@
     ],
     "paths": {
       "@demo/shared": ["tools/demo/index.ts"],
+      "@nativescript/*": ["packages/*"],
       "@nativescript/mlkit-barcode-scanning": ["packages/mlkit-barcode-scanning/index.ts"],
       "@nativescript/mlkit-core": ["packages/mlkit-core/index.d.ts"],
       "@nativescript/mlkit-core/angular": ["packages/mlkit-core/angular/index.ts"],
@@ -31,8 +32,7 @@
       "@nativescript/mlkit-object-detection": ["packages/mlkit-object-detection/index.ts"],
       "@nativescript/mlkit-pose-detection": ["packages/mlkit-pose-detection/index.ts"],
       "@nativescript/mlkit-selfie-segmentation": ["packages/mlkit-selfie-segmentation/index.ts"],
-      "@nativescript/mlkit-text-recognition": ["packages/mlkit-text-recognition/index.ts"],
-      "@nativescript/*": ["packages/*"]
+      "@nativescript/mlkit-text-recognition": ["packages/mlkit-text-recognition/index.ts"]
     }
   },
   "exclude": ["node_modules", "tmp"]

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`"@nativescript/mlkit-custom-object-detection": "file:../../dist/packages/mlkit-custom-object-detection"`
`15`	`15`	`},`
`16`	`16`	`"devDependencies": {`
`17`		`- "@nativescript/android": "8.8.0-alpha.7",`
`18`		`- "@nativescript/ios": "~8.7.0"`
	`17`	`+ "@nativescript/android": "~8.8.0",`
	`18`	`+ "@nativescript/ios": "~8.8.0"`
`19`	`19`	`}`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`"@nativescript/mlkit-custom-object-detection": "file:../../packages/mlkit-custom-object-detection"`
`18`	`18`	`},`
`19`	`19`	`"devDependencies": {`
`20`		`- "@nativescript/android": "8.8.0-alpha.8",`
`21`		`- "@nativescript/ios": "~8.7.0"`
	`20`	`+ "@nativescript/android": "~8.8.0",`
	`21`	`+ "@nativescript/ios": "~8.8.0"`
`22`	`22`	`}`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"migrations": [`
`3`		`- {`
`4`		`- "cli": "nx",`
`5`		`- "version": "5.2.0",`
`6`		`- "description": "Migrate tools to 5.2.0",`
`7`		`- "implementation": "./src/migrations/update-5-2-0/update-5-2-0",`
`8`		`- "package": "@nativescript/plugin-tools",`
`9`		`- "name": "update-to-5.2.0"`
`10`		`- }`
	`3`	`+ { "cli": "nx", "version": "5.3.0", "description": "Migrate tools to 5.3.0", "implementation": "./src/migrations/update-5-3-0/update-5-3-0", "package": "@nativescript/plugin-tools", "name": "update-to-5.3.0" },`
	`4`	`+ { "cli": "nx", "version": "5.4.0", "description": "Migrate tools to 5.4.0", "implementation": "./src/migrations/update-5-4-0/update-5-4-0", "package": "@nativescript/plugin-tools", "name": "update-to-5.4.0" },`
	`5`	`+ { "cli": "nx", "version": "5.5.0", "description": "Migrate tools to 5.5.0", "implementation": "./src/migrations/update-5-5-0/update-5-5-0", "package": "@nativescript/plugin-tools", "name": "update-to-5.5.0" }`
`11`	`6`	`]`
`12`	`7`	`}`