clean-up after release build in android to prevent runtime errors (#2452)

Author: petekanev

lib/definitions/project.d.ts

@@ -163,6 +163,12 @@ interface IPlatformProjectService {
 	 * @returns {void}
 	 */
 	ensureConfigurationFileInAppResources(): void;
+
+	/**
+	 * Removes build artifacts specific to the platform
+	 * @returns {void}
+	 */
+	cleanProject(projectRoot: string, options: string[]): IFuture<void>
 }
 
 interface IAndroidProjectPropertiesManager {

lib/services/android-project-service.ts

@@ -410,7 +410,7 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
 		return Future.fromResult();
 	}
 
-	private cleanProject(projectRoot: string, options: string[]): IFuture<void> {
+	public cleanProject(projectRoot: string, options: string[]): IFuture<void> {
 		return (() => {
 			options.unshift("clean");
 

lib/services/ios-project-service.ts

@@ -653,10 +653,15 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 				this.platformData.configurationFileName
 			);
 	}
+
 	public ensureConfigurationFileInAppResources(): void {
 		return null;
 	}
 
+	public cleanProject(projectRoot: string, options: string[]): IFuture<void> {
+		return Future.fromResult();
+	}
+
 	private mergeInfoPlists(): IFuture<void> {
 		return (() => {
 			let projectDir = this.$projectData.projectDir;

lib/services/platform-service.ts

@@ -217,6 +217,16 @@ export class PlatformService implements IPlatformService {
 			this.ensurePlatformInstalled(platform).wait();
 			let changesInfo = this.$projectChangesService.checkForChanges(platform);
 			if (changesInfo.hasChanges) {
+				// android build artifacts need to be cleaned up when switching from release to debug builds
+				if (platform.toLowerCase() === "android") {
+					let previousPrepareInfo = this.$projectChangesService.getPrepareInfo(platform);
+					// clean up prepared plugins when not building for release
+					if (previousPrepareInfo && previousPrepareInfo.release !== this.$options.release) {
+						let platformData = this.$platformsData.getPlatformData(platform);
+						platformData.platformProjectService.cleanProject(platformData.projectRoot, []).wait();
+					}
+				}
+
 				this.preparePlatformCore(platform, changesInfo).wait();
 				this.$projectChangesService.savePrepareInfo(platform);
 			} else {

test/stubs.ts

@@ -338,6 +338,9 @@ export class PlatformProjectServiceStub implements IPlatformProjectService {
 	ensureConfigurationFileInAppResources(): void {
 		return null;
 	}
+	cleanProject(projectRoot: string, options: string[]): IFuture<void> {
+		return Future.fromResult();
+	}
 }
 
 export class ProjectDataService implements IProjectDataService {