Skip to content

Commit c5edd01

Browse files
authored
Fix a promote issue for AbsMSeries over Poly tower (#2061)
1 parent 3ae5789 commit c5edd01

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

src/generic/AbsMSeries.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,10 @@ end
670670
#
671671
###############################################################################
672672

673+
function (R::AbsMSeriesRing)(x::RingElement)
674+
return R(base_ring(R)(x))
675+
end
676+
673677
function (R::AbsMSeriesRing{T, S})(x::S, prec::Vector{Int}) where
674678
{T <: RingElement, S <: AbstractAlgebra.MPolyRingElem{T}}
675679
for v in prec

src/generic/AbsSeries.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ end
307307
#
308308
###############################################################################
309309

310-
function (a::AbsPowerSeriesRing{T} where T <: RingElement)(b::RingElement)
310+
function (a::AbsPowerSeriesRing)(b::RingElement)
311311
return a(base_ring(a)(b))
312312
end
313313

test/generic/AbsMSeries-test.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -642,3 +642,10 @@ end
642642
@test evaluate(f, [y], [h]) == evaluate(f, [x, h])
643643
end
644644
end
645+
646+
@testset "Generic.AbsMSeries.#2060" begin
647+
R, a = polynomial_ring(QQ, :a)
648+
F, x = polynomial_ring(R, :x)
649+
S, (eps,) = power_series_ring(F, 4, [])
650+
@test coefficients(eps + a) == [a, 1]
651+
end

0 commit comments

Comments
 (0)