Refactor indexer bounds checking (#357)

Author: aalmada

NetFabric.Hyperlinq.UnitTests/Generation/ValueEnumerable/Return.Tests.cs

@@ -33,7 +33,7 @@ public void Indexer_With_IndexOutOfRange_Must_Throw(int value, int index)
             Func<int> action = () => ValueEnumerable.Return(value)[index];
 
             // Assert
-            _ = action.Must().Throw<IndexOutOfRangeException>();
+            _ = action.Must().Throw<ArgumentOutOfRangeException>();
         }    
     }
 }

NetFabric.Hyperlinq/Conversion/AsValueEnumerable/AsValueEnumerable.ArraySegment.cs

@@ -39,7 +39,7 @@ public readonly TSource this[int index]
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 get
                 {
-                    if (index < 0 || index >= Count) Throw.IndexOutOfRangeException();
+                    if ((uint)index >= (uint)Count) Throw.ArgumentOutOfRangeException<TSource>(nameof(index));
 
                     return source.Array![source.Offset + index];
                 }

NetFabric.Hyperlinq/Generation/ValueEnumerable/Empty.cs

@@ -20,10 +20,10 @@ public int Count
                 => 0;
 
             public TSource this[int index]
-                => Throw.IndexOutOfRangeException<TSource>();
+                => Throw.ArgumentOutOfRangeException<TSource>(nameof(index));
             TSource IList<TSource>.this[int index]
             {
-                get => Throw.IndexOutOfRangeException<TSource>();
+                get => Throw.ArgumentOutOfRangeException<TSource>(nameof(index));
 
                 [ExcludeFromCodeCoverage]
                 // ReSharper disable once ValueParameterNotUsed

NetFabric.Hyperlinq/Generation/ValueEnumerable/Return.cs

@@ -33,7 +33,7 @@ public readonly TSource this[int index]
                 get => index switch
                 {
                     0 => value,
-                    _ => Throw.IndexOutOfRangeException<TSource>()
+                    _ => Throw.ArgumentOutOfRangeException<TSource>(nameof(index))
                 };
             }
             TSource IReadOnlyList<TSource>.this[int index]

NetFabric.Hyperlinq/NetFabric.Hyperlinq.csproj

@@ -4,7 +4,7 @@
     <TargetFrameworks>net461;netstandard2.0;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
     <PackageId>NetFabric.Hyperlinq</PackageId>
     <Title>NetFabric.Hyperlinq</Title>
-    <Description> High performance LINQ implementation with minimal heap allocations. Supports enumerables, async enumerables, arrays, Memory and Span.</Description>
+    <Description> High performance LINQ implementation with minimal heap allocations. Supports enumerables, async enumerables, Memory, and Span.</Description>
     <Version>3.0.0-beta44</Version>
     <PackageIcon>Icon.png</PackageIcon>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
@@ -81,9 +81,4 @@
     </EmbeddedResource>
   </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="Conversion\AsAsyncEnumerable" />
-    <Folder Include="Utils\Generator\" />
-  </ItemGroup>
-
 </Project>

NetFabric.Hyperlinq/Projection/Select/Select/Select.ArraySegment.cs

@@ -44,7 +44,7 @@ public TResult this[int index]
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 get
                 {
-                    if (index < 0 || index >= Count) Throw.IndexOutOfRangeException();
+                    if ((uint)index >= (uint)Count) Throw.ArgumentOutOfRangeException<TSource>(nameof(index));
 
                     return selector.Invoke(source.Array![index + source.Offset]);
                 }

NetFabric.Hyperlinq/Projection/Select/SelectAt/SelectAt.ArraySegment.cs

@@ -47,7 +47,7 @@ public TResult this[int index]
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 get
                 {
-                    if (index < 0 || index >= Count) Throw.IndexOutOfRangeException();
+                    if ((uint)index >= (uint)Count) Throw.ArgumentOutOfRangeException<TSource>(nameof(index));
 
                     return selector.Invoke(source.Array![index + source.Offset], index);
                 }

NetFabric.Hyperlinq/Utils/Throw.cs

@@ -38,14 +38,6 @@ public static T ArgumentOutOfRangeException<T>(string? paramName)
         public static ref readonly T ArgumentOutOfRangeExceptionRef<T>(string? paramName)
             => throw new ArgumentOutOfRangeException(paramName);
 
-        [DoesNotReturn]
-        public static void IndexOutOfRangeException()
-            => throw new IndexOutOfRangeException();
-
-        [DoesNotReturn]
-        public static T IndexOutOfRangeException<T>()
-            => throw new IndexOutOfRangeException();
-
         [DoesNotReturn]
         public static void EmptySequence()
             => throw new InvalidOperationException(Resource.EmptySequence);