SonarQube fixes.

Author: jimbuck

projects/ngx-page-scroll/src/lib/ngx-page-scroll.directive.ts

@@ -69,9 +69,9 @@ export class NgxPageScrollDirective implements OnChanges, OnDestroy {
   pageScrollFinish: EventEmitter<boolean> = new EventEmitter<boolean>();
 
   private pageScrollInstance: PageScrollInstance;
-  private document: Document;
+  private readonly document: Document;
 
-  constructor(private pageScrollService: PageScrollService, @Optional() private router: Router, @Inject(DOCUMENT) document) {
+  constructor(private readonly pageScrollService: PageScrollService, @Optional() private readonly router: Router, @Inject(DOCUMENT) document) {
     this.document = (document as Document);
   }
 

src/app/app.component.ts

@@ -40,7 +40,7 @@ export class AppComponent {
       name: 'Namespace Feature',
     }];
 
-  constructor(private router: Router, private pageScrollService: PageScrollService) {
+  constructor(private readonly router: Router, private readonly pageScrollService: PageScrollService) {
     router.events.subscribe((event) => {
       // see also
       if (event instanceof NavigationEnd) {

src/app/horizontal-scroll/horizontal-scroll.component.ts

@@ -13,7 +13,7 @@ export class HorizontalScrollComponent implements OnInit {
   @ViewChild('container')
   public container: ElementRef;
 
-  constructor(@Inject(DOCUMENT) private document: any, private pageScrollService: PageScrollService) {
+  constructor(@Inject(DOCUMENT) private readonly document: any, private readonly pageScrollService: PageScrollService) {
   }
 
   public scrollHorizontalStart(): void {

src/app/namespace-scroll/namespace-scroll.component.ts

@@ -22,7 +22,7 @@ export class NamespaceScrollComponent implements OnInit {
   @ViewChild('container4')
   public container4: ElementRef;
 
-  constructor(@Inject(DOCUMENT) private document: any, public pageScrollService: PageScrollService) {
+  constructor(@Inject(DOCUMENT) private readonly document: any, public readonly pageScrollService: PageScrollService) {
   }
 
   ngOnInit(): void {

src/app/nested-scroll/nested-scroll.component.ts

@@ -18,7 +18,7 @@ export class NestedScrollComponent implements OnInit {
   @ViewChild('complexContainer')
   public complexContainer: ElementRef;
 
-  constructor(@Inject(DOCUMENT) private document: any, private pageScrollService: PageScrollService, public dialog: MatDialog) {
+  constructor(@Inject(DOCUMENT) private readonly document: any, private readonly pageScrollService: PageScrollService, public readonly dialog: MatDialog) {
   }
 
   ngOnInit(): void {

src/app/pathological-tests/pathological-tests.component.ts

@@ -11,7 +11,7 @@ import { MatSnackBar } from '@angular/material/snack-bar';
 })
 export class PathologicalTestsComponent implements OnInit {
 
-  constructor(@Inject(DOCUMENT) private document: any, private snackBar: MatSnackBar) {
+  constructor(@Inject(DOCUMENT) private readonly document: any, private readonly snackBar: MatSnackBar) {
   }
 
   ngOnInit(): void {

src/app/scroll-dialog/scroll-dialog.component.ts

@@ -18,8 +18,8 @@ export class ScrollDialogComponent implements OnInit, AfterViewInit {
 
   constructor(public dialogRef: MatDialogRef<ScrollDialogComponent>,
               @Inject(MAT_DIALOG_DATA) public data: any,
-              private pageScrollService: PageScrollService,
-              @Inject(DOCUMENT) private document: any) {
+              private readonly pageScrollService: PageScrollService,
+              @Inject(DOCUMENT) private readonly document: any) {
   }
 
   ngOnInit(): void {

src/app/simple-scroll/simple-scroll.component.ts

@@ -31,9 +31,9 @@ export class SimpleScrollComponent implements OnInit {
     return c / 2 * (-Math.pow(2, -10 * --t) + 2) + b;
   }
 
-  public constructor(@Inject(DOCUMENT) private document: any,
-                     private pageScrollService: PageScrollService,
-                     private snackBar: MatSnackBar) {
+  public constructor(@Inject(DOCUMENT) private readonly document: any,
+                     private readonly pageScrollService: PageScrollService,
+                     private readonly snackBar: MatSnackBar) {
   }
 
   ngOnInit(): void {