-
Notifications
You must be signed in to change notification settings - Fork 4
feat: major improvements #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@NormandErwan ping! |
|
Hello, and thank you very much for this PR. I quickly looked over the changes, and they seem to be a very good improvement! I have very little time these days, but I will do my best to merge them. Thank you for your proposal regarding the NuGet package. However, it is your work, so I would prefer you to remain the owner. |
|
Hi, I'm very sorry for the delay. I'm finally testing, it's very nice, thank you for your work! I've also seen that dotnet/docfx#10827 has been merged, would you like to fix the github pages workflow as well? |
@NormandErwan done: https://github.com/bdovaz/UnityXrefMaps/tree/gh-pages 6000.0 LTS example: https://bdovaz.github.io/UnityXrefMaps/6000.0/xrefmap.yml It took me quite a while because I used Unity's releases API: https://services.docs.unity.com/release/v1/ And it has the problem that the tags in the UnityCsReference repository are always behind, since it seems that they only commit from time to time and it's never synchronized... So I had to create a logic that tries to resolve the tag closest to the one resolved by the releases API. On the other hand, versions 2019.2 and 2019.1 fail. I don't know if the project structure was different in these versions https://github.com/bdovaz/UnityXrefMaps/actions/runs/19927828874 I have also made sure that the deployment does not fail because a specific version fails, but rather that it tries to deploy whatever it can. I have also created tests for xref href fixes and corrected many cases of packages where Unity with docfx generates completely different URLs. |

I've done a lot of things, you can really see it in the README.md file in the
Advanced usagesection.If you're still interested in maintaining this project (I hope you are), I'll add you as the owner of the NuGet package.
Highlights:
I haven't fixed the github pages workflow in this PR (it's been failing since November 2024) with the new changes because, at the very least, this PR dotnet/docfx#10827 that I created due to a problem that occurs when trying to generate the UnityEngine xrefmap needs to be merged.