Skip to content

Commit c441c3b

Browse files
committed
Rework PassingRule enum, based on review in working group
- Add common prefix as used in other enums in OSI3 - Split CANNOT_BE_DETERMINED into UNKNOWN and OTHER, similar to other enums - Rename LEFT_TO_RIGHT and RIGHT_TO_LEFT, to avoid confusion - Fix a spelling error in BOTH_ALLOWED
1 parent bdb6e95 commit c441c3b

File tree

1 file changed

+27
-13
lines changed

1 file changed

+27
-13
lines changed

osi_logicallane.proto

Lines changed: 27 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -182,30 +182,44 @@ message LogicalLaneBoundary
182182
// (i.e. it may be overridden by signs).
183183
//
184184
enum PassingRule {
185-
// Passing rule cannot be determined, e.g. because it depends on the
186-
// agent type.
185+
// Passing rule is unknown (must not be used in ground truth).
187186
//
188-
CANNOT_BE_DETERMINED = 0;
187+
PASSING_RULE_UNKNOWN = 0;
189188

190189
// No passing is allowed (neither from left to right nor from right to
191190
// left).
192191
//
193-
NONE_ALLOWED = 1;
194-
195-
// Only passing from left to right (in definition direction, so in
196-
// decreasing T direction) is allowed.
192+
PASSING_RULE_NONE_ALLOWED = 1;
193+
194+
// Only passing in increasing T direction allowed. Passing is allowed
195+
// from one lane to the other if the points on the target lane have
196+
// larger T values than points on the source lane (at the same S
197+
// position). In reference line direction (but not necessarily in
198+
// driving direction), this means changing from right to left is
199+
// allowed.
197200
//
198-
LEFT_TO_RIGHT = 2;
199-
200-
// Only passing from right to left (in definition direction, so in
201-
// increasing T direction) is allowed.
201+
PASSING_RULE_INCREASING_T = 2;
202+
203+
// Only passing in decreasing T direction allowed. Passing is allowed
204+
// from one lane to the other if the points on the target lane have
205+
// smaller T values than points on the source lane (at the same S
206+
// position). In reference line direction (but not necessarily in
207+
// driving direction), this means changing from left to right is
208+
// allowed.
202209
//
203-
RIGHT_TO_LEFT = 3;
210+
PASSING_RULE_DECREASING_T = 3;
204211

205212
// Passing is allowed in both directions (left to right and right to
206213
// left).
207214
//
208-
BOTH_ALLOWD = 4;
215+
PASSING_RULE_BOTH_ALLOWED = 4;
216+
217+
// Passing rule fits neither of the above categories.
218+
//
219+
// Example: this type needs to be used if passing depends on the agent
220+
// type, e.g. if cars may change lane, but trucks may not.
221+
//
222+
PASSING_RULE_OTHER = 5;
209223
}
210224
}
211225

0 commit comments

Comments
 (0)