Skip to content

Commit e7f323f

Browse files
DerBaertigeKmeid
authored andcommitted
Apply suggestions from code review
Signed-off-by: Georg Seifert <Georg.Seifert@carissma.eu> Co-authored-by: Kmeid <kmeid.saad@ansys.com>
1 parent 76bb1ac commit e7f323f

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

osi_common.proto

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@ message Identifier
217217

218218
// \brief References to external objects
219219
//
220-
// The external reference is used to identify objects defined in non-OSI
221-
// descriptions. This could be other OpenX-Standards as well as user defined
220+
// The external reference is an optional recommendation to refer to objects defined outside of OSI.
221+
// This could be other OpenX standards, 3rd-party standards or user-defined objects.
222222
// simulation environments.
223223
//
224224
message ExternalReference
@@ -233,14 +233,14 @@ message ExternalReference
233233

234234
// The type of the external references
235235
//
236-
// Can be used to describe the original source, e.g. OpenDRIVE 1.6
236+
// Must be used to describe the type of the original source.
237237
//
238238
optional string type = 2;
239239

240240
// The external identifier reference value.
241241
//
242242
// For a common description of the external identifier, where a wide range
243-
// of identification types could be represented, the repeded string is chosen.
243+
// of identification types could be represented, the repeated string is chosen.
244244
//
245245
// E.g. referencing a unique lane in OpenDRIVE
246246
// (RoadId --> String, S-Value of LaneSection --> Double, LaneId --> Int)
@@ -550,4 +550,3 @@ message WavelengthData
550550
//
551551
optional double samples_number = 3;
552552
}
553-

osi_environment.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,14 @@ message EnvironmentalConditions
9090

9191
// External Reference to the Environmental Condition Sources
9292
//
93-
// \note For OpenDRIVE and OpenSECNARIO there is no no direct counterpart.
93+
// \note For OpenDRIVE and OpenSECNARIO there is no direct counterpart.
9494
//
9595
// \note For non-ASAM Standards, it is implementation-specific how
9696
// source_reference is resolved.
9797
//
9898
// \note The value has to be repeated, as it cannot guarantee, that one
9999
// object is derived from only one origin source, like from one
100-
// scernario file and and from the sensors.
100+
// scernario file and from the sensors.
101101
//
102102
repeated ExternalReference source_reference = 9;
103103

osi_object.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ message StationaryObject
5454
// * identifier[1] = id of t_road_objects_object or t_road_objects_bridge
5555
//
5656
// For OpenSCENARIO 1.0 the entities of the type MiscObject, which describes
57-
// partly stationary objecs should be set as following:
57+
// partly stationary objects should be set as following:
5858
// * reference = URI to the OpenSCENARIO File
5959
// * type = "OpenSCENARIO 1.0"
6060
// * identifier[0] = Entity-Type ("MiscObject")
@@ -69,7 +69,7 @@ message StationaryObject
6969
//
7070
// \note The value has to be repeated, as it cannot guarantee, that one
7171
// object is derived from only one origin source, like from one
72-
// scernario file and and from the sensors.
72+
// scenario file and and from the sensors.
7373
//
7474
repeated ExternalReference source_reference = 5;
7575

osi_occupant.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ message Occupant
2525

2626
// External Reference to the Occupant Source
2727
//
28-
// \note For OpenDRIVE and OpenSECNARIO there is no no direct counterpart.
28+
// \note For OpenDRIVE and OpenSCENARIO there is no no direct counterpart.
2929
//
3030
// \note For non-ASAM Standards, it is implementation-specific how
3131
// source_reference is resolved.

0 commit comments

Comments
 (0)