pr comments

Author: PhilipDeegan

pyphare/pyphare/pharein/simulation.py

@@ -481,7 +481,7 @@ def check_directory(directory, key):
 # diag_options = {"format":"phareh5", "options": {"dir": "phare_ouputs/"}}
 def check_diag_options(**kwargs):
     diag_options = kwargs.get("diag_options", None)
-    formats = ["phareh5", "pharevtkh5"]
+    formats = ["phareh5", "pharevtkhdf"]
     if diag_options is not None and "format" in diag_options:
         if diag_options["format"] not in formats:
             raise ValueError("Error - diag_options format is invalid")

src/core/data/tensorfield/tensorfield.hpp

@@ -205,8 +205,6 @@ class TensorField
 
     NO_DISCARD auto& componentNames() const { return componentNames_; }
     NO_DISCARD auto& physicalQuantity() const { return qty_; }
-    NO_DISCARD auto constexpr static size() { return N; }
-
     NO_DISCARD auto static constexpr size() { return N; }
 
 private:

src/diagnostic/diagnostics.hpp

@@ -56,7 +56,7 @@ struct DiagnosticsManagerResolver
         PHARE_LOG_LINE_SS(format);
         if (format == "phareh5")
             return DiagnosticsManager<h5::H5Writer<ModelView_t>>::make_unique(hier, model, dict);
-        if (format == "pharevtkh5")
+        if (format == "pharevtkhdf")
             return DiagnosticsManager<vtkh5::H5Writer<ModelView_t>>::make_unique(hier, model, dict);
         throw std::runtime_error("DiagnosticsManagerResolver - unknown format " + format);
 #else

src/hdf5/detail/h5/h5_file.hpp

@@ -252,10 +252,10 @@ class HighFiveFile
         return h5file_.getDataSet(s);
     }
 
-    HighFiveFile(HighFiveFile const&)             = delete;
-    HighFiveFile(HighFiveFile const&&)            = delete;
-    HighFiveFile& operator=(HighFiveFile const&)  = delete;
-    HighFiveFile& operator=(HighFiveFile const&&) = delete;
+    HighFiveFile(HighFiveFile const&)       = delete;
+    HighFiveFile(HighFiveFile const&&)      = delete;
+    HighFiveFile& operator=(HighFiveFile&)  = delete;
+    HighFiveFile& operator=(HighFiveFile&&) = delete;
 
 private:
     HighFive::FileAccessProps fapl_;

tests/simulator/test_vtk_diagnostics.py

@@ -171,7 +171,7 @@ def test_dump_diags(self, ndim, interp, simInput):
 
         local_out = self.unique_diag_dir_for_test_case(f"{out}/test_vtk", ndim, interp)
         simInput["diag_options"]["options"]["dir"] = local_out
-        simInput["diag_options"]["format"] = "pharevtkh5"
+        simInput["diag_options"]["format"] = "pharevtkhdf"
         simulation = ph.Simulation(**simInput)
         self.assertTrue(len(simulation.cells) == ndim)
         dump_all_diags(setup_model().populations)