improvement

Author: Amin

composer.json

@@ -25,7 +25,8 @@
   "require": {
     "php": "^8.4",
     "quasarstream/exception": "^1.0",
-    "quasarstream/dtls": "^1.0"
+    "quasarstream/rtp-parameter": "^1.0",
+    "quasarstream/ice": "^1.0"
   },
   "require-dev": {
     "phpunit/php-code-coverage": "11.0.x-dev",

src/DtlsParameter/RTCDtlsFingerprint.php

@@ -0,0 +1,39 @@
+<?php
+
+/**
+ * This file is part of the PHP WebRTC package.
+ *
+ * (c) Amin Yazdanpanah <https://www.aminyazdanpanah.com/#contact>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Webrtc\SDP\DtlsParameter;
+
+use Webrtc\Mixin\DataClass;
+
+/**
+ * Represents a DTLS fingerprint.
+ */
+#[DataClass]
+class RTCDtlsFingerprint
+{
+    /**
+     * Initializes a new RTCDtlsFingerprint instance.
+     *
+     * @param string $algorithm The hash algorithm (e.g., "sha-256").
+     * @param string $value The fingerprint value.
+     */
+    public function __construct(
+        public string $algorithm,
+        public string $value
+    )
+    {
+    }
+
+    public function isAlgorithm(string $algorithm): bool
+    {
+        return $this->algorithm === $algorithm;
+    }
+}

src/DtlsParameter/RTCDtlsParameters.php

@@ -0,0 +1,35 @@
+<?php
+
+/**
+ * This file is part of the PHP WebRTC package.
+ *
+ * (c) Amin Yazdanpanah <https://www.aminyazdanpanah.com/#contact>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Webrtc\SDP\DtlsParameter;
+
+use Webrtc\Mixin\DataClass;
+use Webrtc\SDP\Enum\DtlsRole;
+
+/**
+ * Represents DTLS (Datagram Transport Layer Security) parameters.
+ */
+#[DataClass]
+class RTCDtlsParameters
+{
+    /**
+     * Initializes a new RTCDtlsParameters instance.
+     *
+     * @param RTCDtlsFingerprint[] $fingerprints List of DTLS fingerprints, one for each certificate.
+     * @param DtlsRole $role The DTLS role, with a default of "auto".
+     */
+    public function __construct(
+        public array    $fingerprints = [],
+        public DtlsRole $role = DtlsRole::Auto
+    )
+    {
+    }
+}

src/Enum/DtlsRole.php

@@ -0,0 +1,19 @@
+<?php
+
+/**
+ * This file is part of the PHP WebRTC package.
+ *
+ * (c) Amin Yazdanpanah <https://www.aminyazdanpanah.com/#contact>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Webrtc\SDP\Enum;
+
+enum DtlsRole: string
+{
+    case Auto = "auto";
+    case Client = "client";
+    case Server = "server";
+}

src/MediaDescription.php

@@ -11,12 +11,12 @@
 
 namespace Webrtc\SDP;
 
-use Webrtc\DTLS\Parameters\RTCDtlsParameters;
 use Webrtc\ICE\RTCIceCandidate;
 use Webrtc\ICE\RTCIceParameters;
-use Webrtc\RTP\Parameters\RTCRtpParameters;
-use Webrtc\SCTP\RTCSctpCapabilities;
+use Webrtc\RTPParameter\RTCRtpParameters;
+use Webrtc\SDP\DtlsParameter\RTCDtlsParameters;
 use Webrtc\SDP\Enum\SDPDirections;
+use Webrtc\SDP\SctpParameter\RTCSctpCapabilities;
 
 /**
  * Represents a media description for SDP (Session Description Protocol).

src/SctpParameter/RTCSctpCapabilities.php

@@ -0,0 +1,26 @@
+<?php
+
+/**
+ * This file is part of the PHP WebRTC package.
+ *
+ * (c) Amin Yazdanpanah <https://www.aminyazdanpanah.com/#contact>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Webrtc\SDP\SctpParameter;
+
+/**
+ * Provides information about the capabilities of the RTCSctpTransport.
+ */
+class RTCSctpCapabilities
+{
+    /**
+     * The maximum size of data that the implementation can send or
+     * 0 if the implementation can handle messages of any size.
+     */
+    public function __construct(public int $maxMessageSize = 0)
+    {
+    }
+}

src/SessionDescription.php

@@ -11,16 +11,15 @@
 
 namespace Webrtc\SDP;
 
-use Webrtc\DTLS\Enum\DtlsRole;
-use Webrtc\DTLS\Parameters\RTCDtlsFingerprint;
 use Webrtc\Exception\InvalidArgumentException;
 use Webrtc\ICE\RTCIceCandidate;
-use Webrtc\RTP\Parameters\RTCRtcpFeedback;
-use Webrtc\RTP\Parameters\RTCRtpCodecParameters;
-use Webrtc\RTP\Parameters\RTCRtpHeaderExtensionParameters;
-use Webrtc\RTP\RtpConstants;
-use Webrtc\SCTP\RTCSctpCapabilities;
+use Webrtc\RTPParameter\RTCRtcpFeedback;
+use Webrtc\RTPParameter\RTCRtpCodecParameters;
+use Webrtc\RTPParameter\RTCRtpHeaderExtensionParameters;
+use Webrtc\SDP\DtlsParameter\RTCDtlsFingerprint;
+use Webrtc\SDP\Enum\DtlsRole;
 use Webrtc\SDP\Enum\SDPDirections;
+use Webrtc\SDP\SctpParameter\RTCSctpCapabilities;
 
 /**
  * Represents a session description for SDP (Session Description Protocol).
@@ -36,6 +35,7 @@ class SessionDescription
 
     /** @var string[] Supported SSRC attributes. */
     private const array SSRC_INFO_ATTRS = ["cname", "msid", "mslabel", "label"];
+    private const array FORBIDDEN_PAYLOAD_TYPES = [72, 73, 74, 75, 76];
     const array DIRECTIONS = ["inactive", "sendonly", "recvonly", "sendrecv"];
     /** @var int The SDP version. */
     private int $version = 0;
@@ -246,7 +246,7 @@ private function decodeMediaDescription(string $line): MediaDescription
         if (in_array($kind, ["audio", "video"])) {
             $fmtInt = array_map('intval', $fmt);
             foreach ($fmtInt as $pt) {
-                if ($pt < 0 || $pt >= 256 || in_array($pt, RtpConstants::FORBIDDEN_PAYLOAD_TYPES)) {
+                if ($pt < 0 || $pt >= 256 || in_array($pt, self::FORBIDDEN_PAYLOAD_TYPES)) {
                     throw new InvalidArgumentException("Invalid payload type: $pt");
                 }
             }

tests/SessionDescriptionTest.php

@@ -5,20 +5,20 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
-use Webrtc\DTLS\Enum\DtlsRole;
-use Webrtc\DTLS\Parameters\RTCDtlsFingerprint;
-use Webrtc\DTLS\Parameters\RTCDtlsParameters;
 use Webrtc\ICE\RTCIceCandidate;
 use Webrtc\ICE\RTCIceParameters;
-use Webrtc\RTP\Parameters\RTCRtcpFeedback;
-use Webrtc\RTP\Parameters\RTCRtcpParameters;
-use Webrtc\RTP\Parameters\RTCRtpCodecParameters;
-use Webrtc\RTP\Parameters\RTCRtpHeaderExtensionParameters;
-use Webrtc\RTP\Parameters\RTCRtpParameters;
-use Webrtc\SCTP\RTCSctpCapabilities;
+use Webrtc\RTPParameter\RTCRtcpFeedback;
+use Webrtc\RTPParameter\RTCRtcpParameters;
+use Webrtc\RTPParameter\RTCRtpCodecParameters;
+use Webrtc\RTPParameter\RTCRtpHeaderExtensionParameters;
+use Webrtc\RTPParameter\RTCRtpParameters;
+use Webrtc\SDP\DtlsParameter\RTCDtlsFingerprint;
+use Webrtc\SDP\DtlsParameter\RTCDtlsParameters;
+use Webrtc\SDP\Enum\DtlsRole;
 use Webrtc\SDP\Enum\SDPDirections;
 use Webrtc\SDP\GroupDescription;
 use Webrtc\SDP\MediaDescription;
+use Webrtc\SDP\SctpParameter\RTCSctpCapabilities;
 use Webrtc\SDP\SDPUtility;
 use Webrtc\SDP\SessionDescription;
 use Webrtc\SDP\SsrcDescription;