Squiz/OperatorBracket: stability tweak

The `$allowed` tokens array is joined after declaration with the `Tokens::$operators` array. This is only reliable if the keys in both arrays are unique (or intended to be overwritten).
However, with the `$allowed` array being numerically indexed and PHP native tokens also being integers, this was not the case and could lead to one of the tokens in the original array (unintentionally) being disregarded/overwritten by one of the tokens in the `Tokens::$operators` array.

Fixed now, by making setting the tokens constants both as the key as well as the value, making the entries in the array suitable for an array join operation.

Author: jrfnl

src/Standards/Squiz/Sniffs/Formatting/OperatorBracketSniff.php

@@ -116,25 +116,25 @@ public function process(File $phpcsFile, $stackPtr)
 
         // Tokens that are allowed inside a bracketed operation.
         $allowed = [
-            T_VARIABLE,
-            T_LNUMBER,
-            T_DNUMBER,
-            T_STRING,
-            T_NAME_QUALIFIED,
-            T_NAME_FULLY_QUALIFIED,
-            T_NAME_RELATIVE,
-            T_WHITESPACE,
-            T_THIS,
-            T_SELF,
-            T_STATIC,
-            T_PARENT,
-            T_OBJECT_OPERATOR,
-            T_NULLSAFE_OBJECT_OPERATOR,
-            T_DOUBLE_COLON,
-            T_OPEN_SQUARE_BRACKET,
-            T_CLOSE_SQUARE_BRACKET,
-            T_NONE,
-            T_BITWISE_NOT,
+            T_VARIABLE                 => T_VARIABLE,
+            T_LNUMBER                  => T_LNUMBER,
+            T_DNUMBER                  => T_DNUMBER,
+            T_STRING                   => T_STRING,
+            T_NAME_QUALIFIED           => T_NAME_QUALIFIED,
+            T_NAME_FULLY_QUALIFIED     => T_NAME_FULLY_QUALIFIED,
+            T_NAME_RELATIVE            => T_NAME_RELATIVE,
+            T_WHITESPACE               => T_WHITESPACE,
+            T_THIS                     => T_THIS,
+            T_SELF                     => T_SELF,
+            T_STATIC                   => T_STATIC,
+            T_PARENT                   => T_PARENT,
+            T_OBJECT_OPERATOR          => T_OBJECT_OPERATOR,
+            T_NULLSAFE_OBJECT_OPERATOR => T_NULLSAFE_OBJECT_OPERATOR,
+            T_DOUBLE_COLON             => T_DOUBLE_COLON,
+            T_OPEN_SQUARE_BRACKET      => T_OPEN_SQUARE_BRACKET,
+            T_CLOSE_SQUARE_BRACKET     => T_CLOSE_SQUARE_BRACKET,
+            T_NONE                     => T_NONE,
+            T_BITWISE_NOT              => T_BITWISE_NOT,
         ];
 
         $allowed += Tokens::$operators;
@@ -162,7 +162,7 @@ public function process(File $phpcsFile, $stackPtr)
                     // We allow simple operations to not be bracketed.
                     // For example, ceil($one / $two).
                     for ($prev = ($stackPtr - 1); $prev > $bracket; $prev--) {
-                        if (in_array($tokens[$prev]['code'], $allowed, true) === true) {
+                        if (isset($allowed[$tokens[$prev]['code']]) === true) {
                             continue;
                         }
 
@@ -178,7 +178,7 @@ public function process(File $phpcsFile, $stackPtr)
                     }
 
                     for ($next = ($stackPtr + 1); $next < $endBracket; $next++) {
-                        if (in_array($tokens[$next]['code'], $allowed, true) === true) {
+                        if (isset($allowed[$tokens[$next]['code']]) === true) {
                             continue;
                         }