Generic/InlineControlStructure: stop listening for T_SWITCH tokens

There is no inline version of a `switch` in PHP and JS so there is no
reason for this sniff to listen to `T_SWITCH` tokens. Before this
change, the sniff would bail early on the line below as a switch always
has a scope opener, so this change should not impact in any way the
behavior of the sniff.

https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/9a0c2546ea2fa7aac19881da7b655cc5f022bc10/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php#L71

The InlineControlStructure sniff started listening for T_SWITCH tokens
since the commit that added it to PHPCS:

ad96eb#diff-e1ea4eabd79d6324057bbf726a27074250478f87d92c11a3725a97f0afbd5513R50

Some of the sniff tests using the T_SWITCH token were added to
protect against regressions for changes in the tokenizer. For those,
dedicated tokenizer tests will be created in subsequent commits.

The sniff tests that were using T_SWITCH will be changed to use
different control structures that trigger this sniff. This will happen
either in this commit or subsequent commits depending on whether it is
necessary to add related tokenizer tests or not.

The modified JS test lost part of its value over time as now the sniff
bails early if there is no opening parenthesis after the control
structure. Ideally, it should be moved to a tokenizer test, but since
there are no tests for the JS tokenizer and support will be dropped in
PHPCS 4.0, I opted to simply use a control structure other than
T_SWITCH. This test was originally added in b3f4f83.

References:

- PHP: https://www.php.net/manual/en/control-structures.switch.php
- JS: https://tc39.es/ecma262/multipage/ecmascript-language-statements-and-declarations.html

Author: rodrigoprimo

src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php

@@ -48,7 +48,6 @@ public function register()
             T_FOREACH,
             T_WHILE,
             T_DO,
-            T_SWITCH,
             T_FOR,
         ];
 

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.inc

@@ -201,16 +201,16 @@ if (true)
     catch(Exception $e) {
     }
 
-switch ($num) {
-    case 0:
-        if (1 > $num)
-            return bar(
-                baz(
-                    "foobarbaz"
-                )
-            );
-        break;
-}
+for ($i = 0; $i <= 4; $i++)
+    if ($i % 2)
+        return bar(
+            baz(
+                "foobarbaz"
+            )
+        );
+
+
+
 
 do {
 	$i++;

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.inc.fixed

@@ -229,18 +229,19 @@ if (true) {
     }
 }
 
-switch ($num) {
-    case 0:
-        if (1 > $num) {
-            return bar(
-                baz(
-                    "foobarbaz"
-                )
-            );
-        }
-        break;
+for ($i = 0; $i <= 4; $i++) {
+    if ($i % 2) {
+        return bar(
+            baz(
+                "foobarbaz"
+            )
+        );
+    }
 }
 
+
+
+
 do {
 	$i++;
 }

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.js

@@ -20,7 +20,7 @@ do {
 
 do i++; while (i < 5);
 
-SomeClass.prototype.switch = function() {
+SomeClass.prototype.for = function() {
     // do something
 };
 

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.js.fixed

@@ -26,7 +26,7 @@ do {
 do { i++;
 } while (i < 5);
 
-SomeClass.prototype.switch = function() {
+SomeClass.prototype.for = function() {
     // do something
 };
 

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.php

@@ -69,7 +69,8 @@ public function getErrorList($testFile='')
                 191 => 1,
                 195 => 1,
                 198 => 1,
-                206 => 1,
+                204 => 1,
+                205 => 1,
                 222 => 1,
                 232 => 1,
                 235 => 1,