Commit a1c2aaa
committed
Squiz/FunctionDeclarationArgumentSpacing: fix typo in
The `SpacingAfterVis[i]bility` error code was introduced in v 3.12.0 (March this year) for constructor property promotion.
The `SpacingAfterSetVis[i]bility` error code was introduced in v 3.13.1 (few days ago) for constructor property promotion with asym visibility.
Both contained the same typo.
Now, changing an error code is a breaking change. However, with 3.13.1 only having been released a few days ago, it is my opinion that if released soon as 3.13.2, this is an acceptable bug fix.
But then, it would be really weird to not fix the other error code in the same version. Then again, as PHPCS 4.0.0 is around the corner and does allow for breaking changes, let's leave the older typo for 4.0.0, just to be on the safe side.SpacingAfterSetVis[i]bility error code1 parent 6739594 commit a1c2aaa
File tree
2 files changed
+2
-2
lines changed- src/Standards/Squiz/Sniffs/Functions
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
360 | 360 | | |
361 | 361 | | |
362 | 362 | | |
363 | | - | |
| 363 | + | |
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| |||
0 commit comments