Skip to content

Commit 2633ddf

Browse files
committed
Fix code from technical editor review.
1 parent 7eab4cb commit 2633ddf

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

ch04/todos/requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
fastapi==0.70.0
22
uvicorn==0.15.0
3+
jinja2 == 3.1.2
4+
python-multipart

ch05/planner/routes/users.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111

1212
@user_router.post("/signup")
13-
async def sign_user_up(data: User) -> dict
13+
async def sign_user_up(data: User) -> dict:
1414
if data.email in users:
1515
raise HTTPException(
1616
status_code=status.HTTP_409_CONFLICT,

ch07/planner/routes/events.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,17 +59,18 @@ async def update_event(id: PydanticObjectId, body: EventUpdate, user: str = Depe
5959
@event_router.delete("/{id}")
6060
async def delete_event(id: PydanticObjectId, user: str = Depends(authenticate)) -> dict:
6161
event = await event_database.get(id)
62+
if not event:
63+
raise HTTPException(
64+
status_code=status.HTTP_404_NOT_FOUND,
65+
detail="Event not found"
66+
)
6267
if event.creator != user:
6368
raise HTTPException(
6469
status_code=status.HTTP_400_BAD_REQUEST,
6570
detail="Operation not allowed"
6671
)
6772
event = await event_database.delete(id)
68-
if not event:
69-
raise HTTPException(
70-
status_code=status.HTTP_404_NOT_FOUND,
71-
detail="Event with supplied ID does not exist"
72-
)
73+
7374
return {
7475
"message": "Event deleted successfully."
7576
}

ch08/planner/tests/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import httpx
44
import pytest
5-
from database.database import Settings
5+
6+
from database.connection import Settings
67
from main import app
78
from models.events import Event
89
from models.users import User

0 commit comments

Comments
 (0)