Don't flash the open diff dialog when using patch_url param

Author: jpenilla

web/src/lib/components/files/index.svelte.ts

@@ -1,4 +1,4 @@
-import { type ReadableBoxedValues, type WritableBoxedValues } from "svelte-toolbelt";
+import { box, type ReadableBoxedValues, type WritableBoxedValues } from "svelte-toolbelt";
 import { getExtensionForLanguage, lazyPromise } from "$lib/util";
 import type { BundledLanguage, SpecialLanguage } from "shiki";
 import type { Snippet } from "svelte";
@@ -236,6 +236,23 @@ export class MultimodalFileInputState {
     });
     dragActive = $state(false);
 
+    /**
+     * For creating a state instance before the component is mounted.
+     *
+     * @returns new state instance
+     */
+    static createInstance() {
+        return new MultimodalFileInputState({
+            state: undefined,
+
+            // These will be overridden by the component itself. Only the actual input state is inherited.
+            label: box.with(() => ""),
+            required: box.with(() => false),
+            fileTypeOverride: box.with(() => false),
+            defaultMode: box.with(() => "file"),
+        });
+    }
+
     constructor(opts: MultimodalFileInputStateProps) {
         this.opts = opts;
         if (this.opts.state) {
@@ -317,5 +334,6 @@ export class MultimodalFileInputState {
         this.text = "";
         this.file = undefined;
         this.url = "";
+        this.mode = this.opts.defaultMode.current;
     }
 }

web/src/lib/open-diff-dialog.svelte.ts

@@ -29,7 +29,7 @@ export class OpenDiffDialogState {
 
     githubUrl = $state("https://github.com/");
 
-    patchFile = $state<MultimodalFileInputState | undefined>();
+    patchFile = $state(MultimodalFileInputState.createInstance());
 
     fileOne = $state<MultimodalFileInputState | undefined>();
     fileTwo = $state<MultimodalFileInputState | undefined>();

web/src/routes/OpenDiffDialog.svelte

@@ -27,14 +27,10 @@
             instance.githubUrl = githubUrlParam;
             await instance.handleGithubUrl();
         } else if (patchUrlParam !== null) {
-            open = true;
-            await tick();
-            if (instance.patchFile) {
-                instance.patchFile.reset();
-                instance.patchFile.mode = "url";
-                instance.patchFile.url = patchUrlParam;
-                await instance.handlePatchFile();
-            }
+            instance.patchFile.reset();
+            instance.patchFile.mode = "url";
+            instance.patchFile.url = patchUrlParam;
+            await instance.handlePatchFile();
         } else {
             open = true;
         }