MapContainer whenReady doesn't receive target parameter from Leaflet

[BggClr]

In Leaflet map whenReady event provides map component to whenReady callback as below:

whenReady(callback, context) {
	if (this._loaded) {
		callback.call(context || this, {target: this});
	} else {
		this.on('load', callback, context);
	}
	return this;
}

But MapContainer has whenReady function with no arguments

whenReady?: () => void

Is it possible to add those missing argument to whenReady callback?

[erfurtjohn]

Ran into the same problem.

[piotr-cz]

Ideally type definition for whenReady should inherit from @types/leaflet.

Unfortunately it's not typed properly there: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ab24eb77b6ca96a9aa41066add50b132199aab71/types/leaflet/index.d.ts#L2929

 whenReady(fn: () => void, context?: any): this;

[silversonicaxel]

Once this PR is merged:

DefinitelyTyped/DefinitelyTyped#72803

Should not be this line

react-leaflet/packages/react-leaflet/src/MapContainer.tsx

Line 34 in 093c597

whenReady?: () => void

whenReady?: () => void;

replaced with

whenReady?: (event: { target: L.Map }) => void;

or

whenReady?: (event: { target: LeafletMap }) => void

[silversonicaxel]

and @piotr-cz the inheritage should come from react-leaflet since MapContainer is a react-leaflet component, and since react-leaflet offers types.

in fact this is not existing https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-leaflet

[silversonicaxel]

Could this PR help #1161 ?