Added more pull requests

Author: Pierre GAC

PostProcessing/Runtime/Effects/ScreenSpaceReflections.cs

@@ -97,12 +97,19 @@ public sealed class ScreenSpaceReflections : PostProcessEffectSettings
         [Range(0f, 1f), Tooltip("Fades reflections close to the screen edges.")]
         public FloatParameter vignette = new FloatParameter { value = 0.5f };
 
+        /// <summary>
+        /// Enables the use of motion vectors to slightly improve visual quality.
+        /// </summary>
+        [Tooltip("Enables the use of motion vectors to slightly improve visual quality.")]
+        public BoolParameter useMotionVectors = new BoolParameter { value = false };
+
+
         /// <inheritdoc />
         public override bool IsEnabledAndSupported(PostProcessRenderContext context)
         {
             return enabled
                 && context.camera.actualRenderingPath == RenderingPath.DeferredShading
-                && SystemInfo.supportsMotionVectors
+                && (!useMotionVectors || SystemInfo.supportsMotionVectors)
                 && SystemInfo.supportsComputeShaders
                 && SystemInfo.copyTextureSupport > CopyTextureSupport.None
                 && context.resources.shaders.screenSpaceReflections
@@ -148,7 +155,14 @@ enum Pass
 
         public override DepthTextureMode GetCameraFlags()
         {
-            return DepthTextureMode.Depth | DepthTextureMode.MotionVectors;
+            if (settings.useMotionVectors.value)
+            {
+                return DepthTextureMode.Depth | DepthTextureMode.MotionVectors;
+            }
+            else
+            {
+                return DepthTextureMode.Depth;
+            }
         }
 
         internal void CheckRT(ref RenderTexture rt, int width, int height, FilterMode filterMode, bool useMipMap)
@@ -207,6 +221,16 @@ public override void Render(PostProcessRenderContext context)
 
             var noiseTex = context.resources.blueNoise256[0];
             var sheet = context.propertySheets.Get(context.resources.shaders.screenSpaceReflections);
+
+            if (settings.useMotionVectors.value)
+            {
+                sheet.EnableKeyword("_UseMotionVectors");
+            }
+            else
+            {
+                sheet.DisableKeyword("_UseMotionVectors");
+            }
+
             sheet.properties.SetTexture(ShaderIDs.Noise, noiseTex);
 
             var screenSpaceProjectionMatrix = new Matrix4x4();

PostProcessing/Runtime/PostProcessLayer.cs

@@ -120,10 +120,6 @@ public enum Antialiasing
         [SerializeField]
         PostProcessResources m_Resources;
 
-        // Some juggling needed to track down reference to the resource asset when loaded from asset
-        // bundle (guid conflict)
-        PostProcessResources m_OldResources;
-
         // UI states
 #if UNITY_2017_1_OR_NEWER
         [UnityEngine.Scripting.Preserve]
@@ -425,13 +421,10 @@ void OnPreCull()
             // when ResetProjectionMatrix() is called and will break transparent rendering if TAA
             // is switched off and the FOV or any other camera property changes.
 
-            if (m_CurrentContext.IsTemporalAntialiasingActive())
-            {
 #if UNITY_2018_2_OR_NEWER
             if (!m_Camera.usePhysicalProperties)
 #endif
                 m_Camera.ResetProjectionMatrix();
-            }
             m_Camera.nonJitteredProjectionMatrix = m_Camera.projectionMatrix;
 
 #if ENABLE_VR
@@ -605,7 +598,15 @@ void BuildCommandBuffers()
             if (RequiresInitialBlit(m_Camera, context) || forceNanKillPass)
             {
                 tempRt = m_TargetPool.Get();
-                context.GetScreenSpaceTemporaryRT(m_LegacyCmdBuffer, tempRt, 0, sourceFormat, RenderTextureReadWrite.sRGB);
+                // https://github.com/Unity-Technologies/PostProcessing/issues/844
+                if (!context.stereoActive)
+                {
+                    context.GetScreenSpaceTemporaryRT(m_LegacyCmdBuffer, tempRt, 0, sourceFormat, RenderTextureReadWrite.sRGB);
+                }
+                else
+                {
+                    context.GetScreenSpaceTemporaryRT(m_LegacyCmdBuffer, tempRt, 0, sourceFormat, RenderTextureReadWrite.sRGB, FilterMode.Bilinear, context.width * 2, context.height);
+                }
                 m_LegacyCmdBuffer.BuiltinBlit(cameraTarget, tempRt, RuntimeUtilities.copyStdMaterial, stopNaNPropagation ? 1 : 0);
                 if (!m_NaNKilled)
                     m_NaNKilled = stopNaNPropagation;
@@ -811,13 +812,7 @@ public bool HasActiveEffects(PostProcessEvent evt, PostProcessRenderContext cont
 
         void SetupContext(PostProcessRenderContext context)
         {
-            // Juggling required when a scene with post processing is loaded from an asset bundle
-            // See #1148230
-            if (m_OldResources != m_Resources)
-            {
-                RuntimeUtilities.UpdateResources(m_Resources);
-                m_OldResources = m_Resources;
-            }
+            RuntimeUtilities.UpdateResources(m_Resources);
 
             m_IsRenderingInSceneView = context.camera.cameraType == CameraType.SceneView;
             context.isSceneView = m_IsRenderingInSceneView;