#1 | The nonce isn’t being initialized properly

alan-null · alan-null · commit 017c3f4554c8 · 2025-03-16T17:56:55.000+01:00
diff --git a/Crypto.AES/Public/Protect-Data.ps1 b/Crypto.AES/Public/Protect-Data.ps1
@@ -21,6 +21,7 @@ function Protect-Data {
         Write-Verbose "Cmdlet Protect-Data - Process"
         if (!$Nonce) {
             $Nonce = [byte[]]::new(12)
+            [System.Security.Cryptography.RandomNumberGenerator]::Fill($Nonce)
         }
         $cipherOutput = [byte[]]::new($Data.Length)
         $tag = [byte[]]::new(16)

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ function Protect-Data {`
`21`	`21`	`Write-Verbose "Cmdlet Protect-Data - Process"`
`22`	`22`	`if (!$Nonce) {`
`23`	`23`	`$Nonce = [byte[]]::new(12)`
	`24`	`+ [System.Security.Cryptography.RandomNumberGenerator]::Fill($Nonce)`
`24`	`25`	`}`
`25`	`26`	`$cipherOutput = [byte[]]::new($Data.Length)`
`26`	`27`	`$tag = [byte[]]::new(16)`