Support system messages for upload text

docs: add default 'simplebatchupload-parameters' system message
feat: support unordered list in customization settings
feat: support system message on default upload text
feat: support unnamed on parser function call

Author: bilintsui

i18n/en.json

@@ -10,5 +10,7 @@
 	"batchupload": "Upload multiple files",
 	"simplebatchupload-buttonlabel": "Select files (or drop them here)...",
 	"simplebatchupload-comment": "Uploaded with [[mw:Special:MyLanguage/Extension:SimpleBatchUpload|SimpleBatchUpload]]",
-	"simplebatchupload-max-files-alert": "You cannot upload more than $1 {{PLURAL:$1|file|files}} at a time."
+	"simplebatchupload-filesummary": "<!-- Default file summary for uploaded new files via SimpleBatchUpload. -->",
+	"simplebatchupload-max-files-alert": "You cannot upload more than $1 {{PLURAL:$1|file|files}} at a time.",
+	"simplebatchupload-parameters": "<!-- Customization settings for SimpleBatchUpload subpages, see mw:Special:MyLanguage/Extension:SimpleBatchUpload#Customization for details. -->"
 }

i18n/qqq.json

@@ -10,5 +10,7 @@
 	"batchupload": "{{doc-special|BatchUpload}}",
 	"simplebatchupload-buttonlabel": "The label for the upload button",
 	"simplebatchupload-comment": "Comment saved with the upload. Do not translate '[[mw:Special:MyLanguage/Extension:SimpleBatchUpload|SimpleBatchUpload]]'",
-	"simplebatchupload-max-files-alert": "Alert saying there are too many files in a batch"
+	"simplebatchupload-filesummary": "Default file summary. Do not add anything outside the first comment. Do not translate 'SimpleBatchUpload'",
+	"simplebatchupload-max-files-alert": "Alert saying there are too many files in a batch",
+	"simplebatchupload-parameters": "Customization settings. Do not add anything outside the first comment. Do not translate 'SimpleBatchUpload' and 'mw:Special:MyLanguage/Extension:SimpleBatchUpload#Customization'"
 }

src/ParameterProvider.php

@@ -50,11 +50,23 @@ public function __construct( $templateName ) {
 
 	public function getUploadPageText(): string {
 
-		if ( $this->templateName === '' ) {
-			return '';
+		$msgKey = 'simplebatchupload-filesummary';
+		$templateName = $this->getParameter( self::IDX_TEMPLATENAME );
+		$templateParams = preg_replace( '/^\|+/', '|', $this->getParameter( self::IDX_TEMPLATEPARAMETERS ) );
+
+		if ( $this->templateName !== '' ) {
+			$msgKey = $msgKey . '-' . $templateName;
+		}
+
+		$fileSummaryMsg = Message::newFromKey( $msgKey, $templateParams );
+
+		if ( $fileSummaryMsg->exists() ) {
+			return preg_replace( '/^<!--.*?-->\n*/s', '', $fileSummaryMsg->plain() );
+		}
+		else {
+			return '{{' . $templateName . $templateParams . '}}';
 		}
 
-		return '{{' . $this->getParameter( self::IDX_TEMPLATENAME ) . $this->getParameter( self::IDX_TEMPLATEPARAMETERS ) . '}}';
 	}
 
 	private function getEscapedParameter( int $key ): string {
@@ -83,7 +95,7 @@ private function populateParametersFromKey() {
 
 		if ( $paramMsg->exists() ) {
 
-			$paramLines = explode( "\n", $paramMsg->plain() );
+			$paramLines = explode( "\n", str_replace( '*', '', $paramMsg->plain() ) );
 			$paramSet = array_map( [ $this, 'parseParamLine' ], $paramLines );
 			$paramMap = array_combine( array_column( $paramSet, 0 ), $paramSet );
 

src/UploadButtonRenderer.php

@@ -127,10 +127,11 @@ protected function prepareParameterProvider( $args ): ParameterProvider {
 
 		if ( $templateName !== '' ) {
 			array_shift( $args );
-			foreach ( $args as $node ) {
-				$paramProvider->addTemplateParameter( $node );
-			}
 		}
+		foreach ( $args as $node ) {
+			$paramProvider->addTemplateParameter( $node );
+		}
+
 		return $paramProvider;
 	}