Merge pull request #42 from RandomProgramm3r/develop

refactor(tests): Rename vars and clean up code

- Rename `signup_url` → `company_signup_url` and `user_signup` → `user_signup_url`
- Replace unused variables with `_` placeholder
- Remove unused imports

Author: RandomProgramm3r

promo_code/business/tests/auth/base.py

@@ -15,8 +15,12 @@ def setUpTestData(cls):
             'api-business:company-token-refresh',
         )
         cls.protected_url = django.urls.reverse('api-core:protected')
-        cls.signup_url = django.urls.reverse('api-business:company-sign-up')
-        cls.signin_url = django.urls.reverse('api-business:company-sign-in')
+        cls.company_signup_url = django.urls.reverse(
+            'api-business:company-sign-up',
+        )
+        cls.company_signin_url = django.urls.reverse(
+            'api-business:company-sign-in',
+        )
         cls.valid_data = {
             'name': 'Digital Marketing Solutions Inc.',
             'email': 'testcompany@example.com',

promo_code/business/tests/auth/test_authentication.py

@@ -20,7 +20,7 @@ def test_signin_success(self):
         )
 
         response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             {
                 'email': registration_data['email'],
                 'password': registration_data['password'],

promo_code/business/tests/auth/test_registration.py

@@ -11,7 +11,7 @@ class TestCompanyRegistration(
     def test_registration_success(self):
         registration_data = {**self.valid_data, 'email': 'unique@company.com'}
         response = self.client.post(
-            self.signup_url,
+            self.company_signup_url,
             registration_data,
             format='json',
         )

promo_code/business/tests/auth/test_tokens.py

@@ -23,7 +23,7 @@ def setUp(self):
 
     def test_access_protected_view_with_valid_token(self):
         response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             self.user_data,
             format='json',
         )
@@ -45,7 +45,7 @@ def test_registration_token_invalid_after_login(self):
             'name': 'Digital Marketing Solutions Inc.',
         }
         response = self.client.post(
-            self.signup_url,
+            self.company_signup_url,
             data,
             format='json',
         )
@@ -62,7 +62,7 @@ def test_registration_token_invalid_after_login(self):
 
         login_data = {'email': data['email'], 'password': data['password']}
         response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             login_data,
             format='json',
         )
@@ -214,14 +214,14 @@ def test_company_not_found(self):
 
     def test_refresh_token_invalidation_after_new_login(self):
         first_login_response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             self.company_data,
             format='json',
         )
         refresh_token_v1 = first_login_response.data['refresh']
 
         second_login_response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             self.company_data,
             format='json',
         )

promo_code/business/tests/auth/test_validation.py

@@ -22,7 +22,7 @@ def test_duplicate_email_registration(self):
         )
 
         response = self.client.post(
-            self.signup_url,
+            self.company_signup_url,
             self.valid_data,
             format='json',
         )
@@ -46,7 +46,11 @@ def test_duplicate_email_registration(self):
     )
     def test_invalid_password_cases(self, _, invalid_password):
         test_data = {**self.valid_data, 'password': invalid_password}
-        response = self.client.post(self.signup_url, test_data, format='json')
+        response = self.client.post(
+            self.company_signup_url,
+            test_data,
+            format='json',
+        )
         self.assertEqual(
             response.status_code,
             rest_framework.status.HTTP_400_BAD_REQUEST,
@@ -64,7 +68,11 @@ def test_invalid_password_cases(self, _, invalid_password):
     )
     def test_invalid_email_cases(self, _, invalid_email):
         test_data = {**self.valid_data, 'email': invalid_email}
-        response = self.client.post(self.signup_url, test_data, format='json')
+        response = self.client.post(
+            self.company_signup_url,
+            test_data,
+            format='json',
+        )
         self.assertEqual(
             response.status_code,
             rest_framework.status.HTTP_400_BAD_REQUEST,
@@ -73,7 +81,11 @@ def test_invalid_email_cases(self, _, invalid_email):
 
     def test_short_company_name(self):
         test_data = {**self.valid_data, 'name': 'A'}
-        response = self.client.post(self.signup_url, test_data, format='json')
+        response = self.client.post(
+            self.company_signup_url,
+            test_data,
+            format='json',
+        )
         self.assertEqual(
             response.status_code,
             rest_framework.status.HTTP_400_BAD_REQUEST,
@@ -90,8 +102,12 @@ class InvalidCompanyAuthenticationTestCase(
             ('empty_data', {}, ['email', 'password']),
         ],
     )
-    def test_missing_required_fields(self, case_name, data, expected_fields):
-        response = self.client.post(self.signin_url, data, format='json')
+    def test_missing_required_fields(self, _, data, expected_fields):
+        response = self.client.post(
+            self.company_signin_url,
+            data,
+            format='json',
+        )
         self.assertEqual(
             response.status_code,
             rest_framework.status.HTTP_400_BAD_REQUEST,
@@ -109,7 +125,7 @@ def test_signin_invalid_password(self):
             'password': 'SuperInvalidPassword2000!',
         }
         response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             data,
             format='json',
         )

promo_code/business/tests/promocodes/base.py

@@ -1,6 +1,4 @@
 import django.urls
-import rest_framework
-import rest_framework.status
 import rest_framework.test
 
 import business.models
@@ -14,8 +12,12 @@ def setUpTestData(cls):
         cls.promo_list_create_url = django.urls.reverse(
             'api-business:promo-list-create',
         )
-        cls.signup_url = django.urls.reverse('api-business:company-sign-up')
-        cls.signin_url = django.urls.reverse('api-business:company-sign-in')
+        cls.company_signup_url = django.urls.reverse(
+            'api-business:company-sign-up',
+        )
+        cls.company_signin_url = django.urls.reverse(
+            'api-business:company-sign-in',
+        )
 
         cls.company1_data = {
             'name': 'Digital Marketing Solutions Inc.',
@@ -38,7 +40,7 @@ def setUpTestData(cls):
         )
 
         response1 = cls.client.post(
-            cls.signin_url,
+            cls.company_signin_url,
             {
                 'email': cls.company1_data['email'],
                 'password': cls.company1_data['password'],
@@ -48,7 +50,7 @@ def setUpTestData(cls):
         cls.company1_token = response1.data['access']
 
         response2 = cls.client.post(
-            cls.signin_url,
+            cls.company_signin_url,
             {
                 'email': cls.company2_data['email'],
                 'password': cls.company2_data['password'],

promo_code/business/tests/promocodes/validations/test_create_validation.py

@@ -21,13 +21,13 @@ def test_create_promo_with_old_token(self):
             'password': 'SuperStrongPassword2000!',
         }
         reg_response = self.client.post(
-            self.signup_url,
+            self.company_signup_url,
             registration_data,
             format='json',
         )
         old_token = reg_response.data.get('token')
         self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             {
                 'email': registration_data['email'],
                 'password': registration_data['password'],
@@ -94,7 +94,7 @@ def test_create_promo_with_old_token(self):
             ),
         ],
     )
-    def test_missing_fields(self, name, payload):
+    def test_missing_fields(self, _, payload):
         response = self.client.post(
             self.promo_list_create_url,
             payload,
@@ -349,7 +349,7 @@ def test_too_short_promo_common(self):
             ),
         ],
     )
-    def test_invalid_type_payloads(self, name, payload):
+    def test_invalid_type_payloads(self, _, payload):
         response = self.client.post(
             self.promo_list_create_url,
             payload,

promo_code/business/tests/promocodes/validations/test_detail_validation.py

@@ -56,7 +56,7 @@ def test_old_token_invalid_after_reauthentication(self):
             'password': self.company1_data['password'],
         }
         response = self.client.post(
-            self.signin_url,
+            self.company_signin_url,
             signin_payload,
             format='json',
         )

promo_code/business/tests/promocodes/validations/test_list_validation.py

@@ -46,7 +46,7 @@ def test_get_promos_without_token(self):
             ),
         ],
     )
-    def test_invalid_query_string_parameters(self, name, params):
+    def test_invalid_query_string_parameters(self, _, params):
         response = self.client.get(self.promo_list_create_url, params)
         self.assertEqual(
             response.status_code,
@@ -65,7 +65,7 @@ def test_invalid_query_string_parameters(self, name, params):
             ('empty_string_offset', {'offset': ''}),
         ],
     )
-    def test_invalid_numeric_parameters(self, name, params):
+    def test_invalid_numeric_parameters(self, _, params):
         response = self.client.get(self.promo_list_create_url, params)
         self.assertEqual(
             response.status_code,

promo_code/user/tests/auth/base.py

@@ -12,8 +12,8 @@ def setUpTestData(cls):
         cls.client = rest_framework.test.APIClient()
         cls.protected_url = django.urls.reverse('api-core:protected')
         cls.refresh_url = django.urls.reverse('api-user:user-token-refresh')
-        cls.signup_url = django.urls.reverse('api-user:sign-up')
-        cls.signin_url = django.urls.reverse('api-user:sign-in')
+        cls.user_signup_url = django.urls.reverse('api-user:user-sign-up')
+        cls.user_signin_url = django.urls.reverse('api-user:user-sign-in')
 
     def tearDown(self):
         user.models.User.objects.all().delete()