chore: fix lint warnings

Author: Rel1cx

eslint.config.mts

@@ -78,10 +78,6 @@ const config: FlatConfig[] = [
       "no-process-exit": "error",
       "no-restricted-syntax": [
         "error",
-        {
-          message: "no let",
-          selector: "VariableDeclaration[kind=let]",
-        },
         {
           message: "no else",
           selector: "IfStatement[alternate]",
@@ -90,6 +86,10 @@ const config: FlatConfig[] = [
           message: "no optional",
           selector: "TSPropertySignature[optional=true]",
         },
+        {
+          message: "no undefined",
+          selector: "Identifier[name='undefined']",
+        },
       ],
       "no-undef": "off",
       "one-var": ["error", "never"],

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-direct-set-state-in-use-effect.ts

@@ -124,7 +124,7 @@ export default createRule<[], MessageID>({
         .otherwise(() => "other");
     }
     const functionStack = MutList.make<[node: TSESTreeFunction, kind: FunctionKind]>();
-    const effectFunctionRef = MutRef.make<TSESTreeFunction | null>(null);
+    const effectFunctionRef = MutRef.make<null | TSESTreeFunction>(null);
     const effectFunctionIdentifiers: TSESTree.Identifier[] = [];
     const indirectFunctionCalls: TSESTree.CallExpression[] = [];
     const indirectSetStateCalls = new WeakMap<TSESTreeFunction, TSESTree.CallExpression[]>();
@@ -179,7 +179,7 @@ export default createRule<[], MessageID>({
           .otherwise(F.constVoid);
       },
       "Program:exit"() {
-        const getSetStateCalls = (id: TSESTree.Identifier | string, initialScope: Scope.Scope) => {
+        const getSetStateCalls = (id: string | TSESTree.Identifier, initialScope: Scope.Scope) => {
           return F.pipe(
             findVariable(id, initialScope),
             O.flatMap(getVariableNode(0)),

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-direct-set-state-in-use-layout-effect.ts

@@ -125,7 +125,7 @@ export default createRule<[], MessageID>({
         .otherwise(() => "other");
     }
     const functionStack = MutList.make<[node: TSESTreeFunction, kind: FunctionKind]>();
-    const effectFunctionRef = MutRef.make<TSESTreeFunction | null>(null);
+    const effectFunctionRef = MutRef.make<null | TSESTreeFunction>(null);
     const effectFunctionIdentifiers: TSESTree.Identifier[] = [];
     const indirectFunctionCalls: TSESTree.CallExpression[] = [];
     const indirectSetStateCalls = new WeakMap<TSESTreeFunction, TSESTree.CallExpression[]>();
@@ -180,7 +180,7 @@ export default createRule<[], MessageID>({
           .otherwise(F.constVoid);
       },
       "Program:exit"() {
-        const getSetStateCalls = (id: TSESTree.Identifier | string, initialScope: Scope.Scope) => {
+        const getSetStateCalls = (id: string | TSESTree.Identifier, initialScope: Scope.Scope) => {
           return F.pipe(
             findVariable(id, initialScope),
             O.flatMap(getVariableNode(0)),

packages/plugins/eslint-plugin-react-naming-convention/src/rules/filename.ts

@@ -15,7 +15,7 @@ export type MessageID =
   | "FILENAME_CASE_MISMATCH_SUGGESTION"
   | "FILENAME_EMPTY";
 
-type Case = "PascalCase" | "camelCase" | "kebab-case" | "snake_case";
+type Case = "camelCase" | "kebab-case" | "PascalCase" | "snake_case";
 
 /* eslint-disable no-restricted-syntax */
 type Options = readonly [

packages/plugins/eslint-plugin-react-x/src/rules/no-missing-key.ts

@@ -119,6 +119,9 @@ export default createRule<[], MessageID>({
         }
         O.map(checkExpression(fn.body), context.report);
       },
+      [childrenToArraySelector]() {
+        MutRef.set(isWithinChildrenToArrayRef, true);
+      },
       JSXFragment(node) {
         if (MutRef.get(isWithinChildrenToArrayRef)) return;
         if (node.parent.type === NodeType.ArrayExpression) {
@@ -128,9 +131,6 @@ export default createRule<[], MessageID>({
           });
         }
       },
-      [childrenToArraySelector]() {
-        MutRef.set(isWithinChildrenToArrayRef, true);
-      },
     };
   },
   defaultOptions: [],

packages/tools/src/helpers.ts

@@ -16,6 +16,7 @@ export type Narrow<TType> =
   | { [K in keyof TType]: Narrow<TType[K]> }
   | (TType extends [] ? [] : never)
   | (TType extends Function ? TType : never)
+  // eslint-disable-next-line perfectionist/sort-union-types
   | (TType extends bigint | boolean | number | string ? TType : never);
 
 /**

packages/utilities/ast/src/get-nested-return-statements.ts

@@ -1,3 +1,4 @@
+import { Pred } from "@eslint-react/tools";
 import type { TSESTree } from "@typescript-eslint/types";
 
 import { NodeType } from "./types";
@@ -12,7 +13,7 @@ export function getNestedReturnStatements(node: TSESTree.Node): readonly TSESTre
   if (node.type === NodeType.ReturnStatement) {
     returnStatements.push(node);
   }
-  if ("body" in node && node.body !== undefined && node.body !== null) {
+  if ("body" in node && !Pred.isNullable(node.body)) {
     const chunk = Array.isArray(node.body)
       ? node.body.map(getNestedReturnStatements).flat(1)
       : getNestedReturnStatements(node.body);

packages/utilities/ast/typings/eslint-community-eslint-utils.d.ts

@@ -1,3 +1,4 @@
+/* eslint-disable perfectionist/sort-object-types */
 declare module "@eslint-community/eslint-utils" {
   export const findVariable: unknown;
   export const getFunctionHeadLocation: unknown;

packages/utilities/jsx/src/is-jsx-value.ts

@@ -46,7 +46,7 @@ export const DEFAULT_JSX_VALUE_HINT = 0n
  * @returns boolean
  */
 export function isJSXValue(
-  node: TSESTree.Node | null | undefined,
+  node: null | TSESTree.Node | undefined,
   context: RuleContext,
   hint: bigint = DEFAULT_JSX_VALUE_HINT,
 ): boolean {