Skip to content

Commit 554aeba

Browse files
authored
Apply suggestions from code review
1 parent 94f4e8a commit 554aeba

File tree

2 files changed

+6
-24
lines changed

2 files changed

+6
-24
lines changed

stubs/nova_test.blade.php

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,7 @@ public function testGetUpdatableFields(): void
142142

143143
public function testDelete(): void
144144
{
145-
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall(
146-
resourceClass: {{$entity}}::class,
147-
resourceIds: [1, 2],
148-
);
145+
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall({{$entity}}::class, [1, 2]);
149146

150147
@if($shouldUseStatus)
151148
$response->assertStatus(Response::HTTP_OK);
@@ -159,10 +156,7 @@ public function testDelete(): void
159156

160157
public function testDeleteNotExists(): void
161158
{
162-
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall(
163-
resourceClass: {{$entity}}::class,
164-
resourceIds: [0],
165-
);
159+
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall({{$entity}}::class, [0]);
166160

167161
@if($shouldUseStatus)
168162
$response->assertStatus(Response::HTTP_NOT_FOUND);
@@ -173,10 +167,7 @@ public function testDeleteNotExists(): void
173167

174168
public function testDeleteNoAuth(): void
175169
{
176-
$response = $this->novaDeleteResourceAPICall(
177-
resourceClass: {{$entity}}::class,
178-
resourceIds: [1, 2],
179-
);
170+
$response = $this->novaDeleteResourceAPICall({{$entity}}::class, [1, 2]);
180171

181172
@if($shouldUseStatus)
182173
$response->assertStatus(Response::HTTP_UNAUTHORIZED);

tests/fixtures/NovaTestGeneratorTest/created_resource_test.php

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,7 @@ public function testGetUpdatableFields(): void
108108

109109
public function testDelete(): void
110110
{
111-
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall(
112-
resourceClass: WelcomeBonus::class,
113-
resourceIds: [1, 2],
114-
);
111+
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall(WelcomeBonus::class, [1, 2]);
115112

116113
$response->assertOk();
117114

@@ -121,20 +118,14 @@ public function testDelete(): void
121118

122119
public function testDeleteNotExists(): void
123120
{
124-
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall(
125-
resourceClass: WelcomeBonus::class,
126-
resourceIds: [0],
127-
);
121+
$response = $this->novaActingAs(self::$user)->novaDeleteResourceAPICall(WelcomeBonus::class, [0]);
128122

129123
$response->assertNotFound();
130124
}
131125

132126
public function testDeleteNoAuth(): void
133127
{
134-
$response = $this->novaDeleteResourceAPICall(
135-
resourceClass: WelcomeBonus::class,
136-
resourceIds: [1, 2],
137-
);
128+
$response = $this->novaDeleteResourceAPICall(WelcomeBonus::class, [1, 2]);
138129

139130
$response->assertUnauthorized();
140131
}

0 commit comments

Comments
 (0)