fix: remove reflection from NovaResourceGeneratorTest

Author: aizlee

src/Generators/NovaResourceGenerator.php

@@ -112,7 +112,7 @@ protected function prepareNovaFields(): array
         return $result;
     }
 
-    protected function getFieldsForCreation(): array
+    public function getFieldsForCreation(): array
     {
         if ($this->commandFieldsExists()) {
             return $this->getFieldsFromCommandLineArguments();

src/Support/DatabaseNovaField.php

@@ -9,7 +9,7 @@ class DatabaseNovaField extends AbstractNovaField
     public function __construct(Column $field)
     {
         $this->isRequired = $field->getNotNull();
-        $this->type = $field->getType();
+        $this->type = strtolower($field->getType()->getBindingType()->name);
         $this->name = $field->getName();
     }
 }

tests/NovaResourceGeneratorTest.php

@@ -19,10 +19,15 @@ class NovaResourceGeneratorTest extends TestCase
 {
     use NovaResourceGeneratorMockTrait;
 
-    public function testCreateWithMissingNovaPackage()
+    public function setUp(): void
     {
+        parent::setUp();
+
         Event::fake();
+    }
 
+    public function testCreateWithMissingNovaPackage()
+    {
         $this->mockNovaServiceProviderExists(false);
 
         app(NovaResourceGenerator::class)
@@ -67,10 +72,8 @@ className: ClassAlreadyExistsException::class,
             ->generate();
     }
 
-    public function testCreate()
+    public function testSuccess()
     {
-        Event::fake();
-
         $this->mockNovaServiceProviderExists();
 
         $this->mockFilesystem();
@@ -90,41 +93,27 @@ className: SuccessCreateMessage::class,
         );
     }
 
-    public function testGetModelFieldsFromDatabase()
+    public function testSuccessWithoutCommandLineFields()
     {
+        $this->mockNovaServiceProviderExists();
+
         $this->mockGettingModelInstance();
 
-        $reflectionClass = new ReflectionClass(NovaResourceGenerator::class);
-        $method = $reflectionClass->getMethod('getFieldsForCreation');
-        $method->setAccessible(true);
+        $this->mockFilesystem();
 
-        $generator = (new NovaResourceGenerator)
+        app(NovaResourceGenerator::class)
+            ->setModel('Post')
             ->setFields([])
-            ->setModel('Post');
-
-        $fields = $method->invokeArgs($generator, []);
-
-        $this->assertEquals([
-            [
-                new DatabaseNovaField(new Column('id', new IntegerType)),
-                new DatabaseNovaField(new Column('title', new StringType)),
-                new DatabaseNovaField(new Column('created_at', new DatetimeType)),
-            ],
-            [
-                'integer' => 'Number',
-                'smallint' => 'Number',
-                'bigint' => 'Number',
-                'float' => 'Number',
-                'decimal' => 'Number',
-                'string' => 'Text',
-                'text' => 'Text',
-                'guid' => 'Text',
-                'json' => 'Text',
-                'date' => 'Date',
-                'datetime' => 'DateTime',
-                'datetimetz' => 'DateTime',
-                'boolean' => 'Boolean',
-            ]
-        ], $fields);
+            ->generate();
+
+        $this->assertGeneratedFileEquals(
+            fixtureName: 'created_resource_without_command_line_fields.php',
+            filePath: 'app/Nova/PostResource.php',
+        );
+
+        $this->assertEventPushed(
+            className: SuccessCreateMessage::class,
+            message: 'Created a new Nova Resource: PostResource',
+        );
     }
 }

tests/NovaTestGeneratorTest.php

@@ -37,22 +37,22 @@ public function testCreateNovaTestAlreadyExists()
     {
         $this->mockNovaServiceProviderExists();
 
-        $this->assertExceptionThrowed(
-            className: ClassAlreadyExistsException::class,
-            message: "Cannot create NovaPostTest cause it's already exist. Remove NovaPostTest.",
-        );
-
         $this->mockClass(NovaTestGenerator::class, [
             $this->classExistsMethodCall(['nova', 'PostNovaResource']),
             $this->classExistsMethodCall(['nova', 'NovaPostTest'])
         ]);
 
+        $this->assertExceptionThrowed(
+            className: ClassAlreadyExistsException::class,
+            message: "Cannot create NovaPostTest cause it's already exist. Remove NovaPostTest.",
+        );
+
         app(NovaTestGenerator::class)
             ->setModel('Post')
             ->generate();
     }
 
-    public function testCreate()
+    public function testSuccess()
     {
         $this->mockNovaServiceProviderExists();
 

tests/Support/GeneratorMockTrait.php

@@ -2,7 +2,6 @@
 
 namespace RonasIT\Support\Tests\Support;
 
-use Illuminate\Support\Facades\Event;
 use Laravel\Nova\NovaServiceProvider;
 
 trait GeneratorMockTrait

tests/Support/Models/WelcomeBonus.php

@@ -9,6 +9,11 @@ class WelcomeBonus extends Model
 {
     use ModelTrait;
 
+    public function getConnectionName(): string
+    {
+        return 'pgsql';
+    }
+
     protected $fillable = [
         'title',
         'name',

tests/fixtures/NovaResourceGeneratorTest/created_resource_without_command_line_fields.php

@@ -0,0 +1,59 @@
+<?php
+
+namespace App\Nova;
+
+use App\Models\Post;
+use Illuminate\Http\Request;
+use Laravel\Nova\Fields\ID;
+use Laravel\Nova\Fields\Text;
+
+class PostResource extends Resource
+{
+    public static $model = Post::class;
+
+    //TODO change field for the title if it required
+    public static $title = 'name';
+
+    //TODO change query fields if it required
+    public static $search = ['id', 'name'];
+
+    public static function label(): string
+    {
+        return 'Posts';
+    }
+
+    public function fields(Request $request): array
+    {
+        return [
+            ID::make('Id')
+                ->required()
+                ->sortable(),
+            Text::make('Title')
+                ->required()
+                ->sortable(),
+            Text::make('Created At')
+                ->required()
+                ->sortable(),
+        ];
+    }
+
+    public function cards(Request $request): array
+    {
+        return [];
+    }
+
+    public function filters(Request $request): array
+    {
+        return [];
+    }
+
+    public function lenses(Request $request): array
+    {
+        return [];
+    }
+
+    public function actions(Request $request): array
+    {
+        return [];
+    }
+}