fix: nova action class name

t0xas · t0xas · commit 7fa3c949aa83 · 2024-10-23T11:29:02.000+05:00
diff --git a/composer.json b/composer.json
@@ -12,7 +12,7 @@
   "require": {
     "php": "^8.3",
     "laravel/framework": "^11.21",
-    "ronasit/laravel-helpers": "^3.0.0-beta",
+    "ronasit/laravel-helpers": "dev-modify-nova-test-trait",
     "laravel/legacy-factories": ">=1.3.0",
     "ext-json": "*"
   },
diff --git a/composer.lock b/composer.lock
diff --git a/stubs/nova_test.blade.php b/stubs/nova_test.blade.php
@@ -173,7 +173,7 @@ public function testDeleteNotExists(): void
 
     public function testDeleteNoAuth(): void
     {
-        $response = $this$this->novaDeleteResource(
+        $response = $this->novaDeleteResource(
             resourceClass: {{$entity}}::class,
             resourceIds: [1, 2],
         );
diff --git a/tests/NovaTestGeneratorTest.php b/tests/NovaTestGeneratorTest.php
@@ -65,7 +65,7 @@ public function testCreateWithActions()
 
         $this->rollbackToDefaultBasePath();
 
-        $this->assertGeneratedFileEquals('created_resource_test.php', 'tests/NovaWelcomeBonusTest.php');
+        $this->assertGeneratedFileEquals('created_resource_test.php', 'tests/NovaWelcomeBonusTest.php', true);
         $this->assertGeneratedFileEquals('dump.sql', 'tests/fixtures/NovaWelcomeBonusTest/nova_welcome_bonus_dump.sql');
         $this->assertGeneratedFileEquals('create_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusTest/create_welcome_bonus_request.json');
         $this->assertGeneratedFileEquals('create_welcome_bonus_response.json', 'tests/fixtures/NovaWelcomeBonusTest/create_welcome_bonus_response.json');
diff --git a/tests/fixtures/NovaTestGeneratorTest/created_resource_test.php b/tests/fixtures/NovaTestGeneratorTest/created_resource_test.php
@@ -27,7 +27,7 @@ public function testCreate(): void
     {
         $data = $this->getJsonFixture('create_welcome_bonus_request.json');
 
-        $response = $this->actingAs(self::$user, 'web')->json('post', '/nova-api/welcome-bonus-resources', $data);
+        $response = $this->novaActingAs(self::$user)->novaCreateResource(WelcomeBonus::class, $data);
 
         $response->assertCreated();
 
@@ -39,7 +39,7 @@ public function testCreate(): void
 
     public function testCreateNoAuth(): void
     {
-        $response = $this->json('post', '/nova-api/welcome-bonus-resources');
+        $response = $this->novaCreateResource(Card::class);
 
         $response->assertUnauthorized();
 
@@ -48,7 +48,7 @@ public function testCreateNoAuth(): void
 
     public function testCreateValidationError(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('post', '/nova-api/welcome-bonus-resources');
+        $response = $this->novaActingAs(self::$user)->novaCreateResource(WelcomeBonus::class);
 
         $response->assertUnprocessable();
 
@@ -62,7 +62,7 @@ public function testUpdate(): void
     {
         $data = $this->getJsonFixture('update_welcome_bonus_request.json');
 
-        $response = $this->actingAs(self::$user, 'web')->json('put', '/nova-api/welcome-bonus-resources/1', $data);
+        $response = $this->novaActingAs(self::$user)->novaUpdateResource(WelcomeBonus::class, 1, $data);
 
         $response->assertNoContent();
 
@@ -74,21 +74,21 @@ public function testUpdateNotExists(): void
     {
         $data = $this->getJsonFixture('update_welcome_bonus_request.json');
 
-        $response = $this->actingAs(self::$user, 'web')->json('put', '/nova-api/welcome-bonus-resources/0', $data);
+        $response = $this->novaActingAs(self::$user)->novaUpdateResource(WelcomeBonus::class, 0, $data);
 
         $response->assertNotFound();
     }
 
     public function testUpdateNoAuth(): void
     {
-        $response = $this->json('put', '/nova-api/welcome-bonus-resources/1');
+        $response = $this->novaUpdateResource(WelcomeBonus::class, 1);
 
         $response->assertUnauthorized();
     }
 
     public function testUpdateValidationError(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('put', '/nova-api/welcome-bonus-resources/4');
+        $response = $this->novaActingAs(self::$user)->novaUpdateResource(WelcomeBonus::class, 4);
 
         $response->assertUnprocessable();
 
@@ -98,7 +98,7 @@ public function testUpdateValidationError(): void
 
     public function testGetUpdatableFields(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/1/update-fields');
+        $response = $this->novaActingAs(self::$user)->novaGetUpdatableFields(WelcomeBonus::class, 1);
 
         $response->assertOk();
 
@@ -108,9 +108,10 @@ public function testGetUpdatableFields(): void
 
     public function testDelete(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('delete', '/nova-api/welcome-bonus-resources', [
-            'resources' => [1, 2]
-        ]);
+        $response = $this->novaActingAs(self::$user)->novaDeleteResource(
+            resourceClass: WelcomeBonus::class,
+            resourceIds: [1, 2],
+        );
 
         $response->assertOk();
 
@@ -120,25 +121,27 @@ public function testDelete(): void
 
     public function testDeleteNotExists(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('delete', '/nova-api/welcome-bonus-resources', [
-            'resources' => [0]
-        ]);
+        $response = $this->novaActingAs(self::$user)->novaDeleteResource(
+            resourceClass: WelcomeBonus::class,
+            resourceIds: [0],
+        );
 
         $response->assertNotFound();
     }
 
     public function testDeleteNoAuth(): void
     {
-        $response = $this->json('delete', '/nova-api/welcome-bonus-resources', [
-            'resources' => [1, 2]
-        ]);
+        $response = $this->novaDeleteResource(
+            resourceClass: WelcomeBonus::class,
+            resourceIds: [1, 2],
+        );
 
         $response->assertUnauthorized();
     }
 
     public function testGet(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/1');
+        $response = $this->novaActingAs(self::$user)->novaGetResource(WelcomeBonus::class, 1);
 
         $response->assertOk();
 
@@ -148,28 +151,34 @@ public function testGet(): void
 
     public function testGetNotExists(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/0');
+        $response = $this->novaActingAs(self::$user)->novaGetResource(WelcomeBonus::class, 0);
 
         $response->assertNotFound();
     }
 
     public function testGetNoAuth(): void
     {
-        $response = $this->json('get', '/nova-api/welcome-bonus-resources/1');
+        $response = $this->novaGetResource(WelcomeBonus::class, 1);
 
         $response->assertUnauthorized();
     }
 
     public function testSearchUnauthorized(): void
     {
-        $response = $this->json('get', '/nova-api/welcome-bonus-resources');
+        $response = $this->novaSearchResource(
+            resourceClass: WelcomeBonus::class,
+            request: [
+                'orderBy' => 'id',
+                'orderByDirection' => 'asc',
+            ],
+        );
 
         $response->assertUnauthorized();
     }
 
     public function testGetFieldsVisibleOnCreate(): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/creation-fields');
+        $response = $this->novaActingAs(self::$user)->novaGetCreationFields(WelcomeBonus::class);
 
         $response->assertOk();
 
@@ -181,14 +190,14 @@ public function getRunWelcomeBonusActionsData(): array
     {
         return [
             [
-                'action' => 'publish-post-action',
+                'action' => PublishPostAction::class,
                 'request' => [
                     'resources' => '1,2',
                 ],
                 'state' => 'run_publish_post_action_state.json',
             ],
             [
-                'action' => 'un-publish-post-action',
+                'action' => UnPublishPostAction::class,
                 'request' => [
                     'resources' => '1,2',
                 ],
@@ -202,7 +211,7 @@ public function getRunWelcomeBonusActionsData(): array
      */
     public function testRunWelcomeBonusActions($action, $request, $welcome_bonusesStateFixture): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('post', "/nova-api/welcome-bonus-resources/action?action={$action}", $request);
+        $response = $this->novaActingAs(self::$user)->json('post', "/nova-api/welcome-bonus-resources/action?action={$action}", $request);
 
         $response->assertOk();
 
@@ -216,15 +225,11 @@ public function getWelcomeBonusActionsData(): array
     {
         return [
             [
-                'request' => [
-                    'resources' => '1,2',
-                ],
+                'resources' => [1, 2],
                 'response_fixture' => 'get_welcome_bonus_actions_publish_post_action.json',
             ],
             [
-                'request' => [
-                    'resources' => '1,2',
-                ],
+                'resources' => [1, 2],
                 'response_fixture' => 'get_welcome_bonus_actions_un_publish_post_action.json',
             ],
         ];
@@ -233,9 +238,9 @@ public function getWelcomeBonusActionsData(): array
     /**
      * @dataProvider getWelcomeBonusActionsData
      */
-    public function testGetWelcomeBonusActions(array $request, string $responseFixture): void
+    public function testGetWelcomeBonusActions(array $resources, string $responseFixture): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/actions', $request);
+        $response = $this->novaActingAs(self::$user)->novaGetActions(WelcomeBonus::class, $resources);
 
         $response->assertOk();
 
@@ -266,7 +271,7 @@ public function getWelcomeBonusFiltersData(): array
      */
     public function testFilterWelcomeBonus(array $request, string $responseFixture): void
     {
-        $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources', $request);
+        $response = $this->novaActingAs(self::$user)->novaSearchResource(WelcomeBonus::class, $request);
 
         $response->assertOk();
 

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ public function testDeleteNotExists(): void`
`173`	`173`
`174`	`174`	`public function testDeleteNoAuth(): void`
`175`	`175`	`{`
`176`		`- $response = $this$this->novaDeleteResource(`
	`176`	`+ $response = $this->novaDeleteResource(`
`177`	`177`	`resourceClass: {{$entity}}::class,`
`178`	`178`	`resourceIds: [1, 2],`
`179`	`179`	`);`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function testCreate(): void`
`27`	`27`	`{`
`28`	`28`	`$data = $this->getJsonFixture('create_welcome_bonus_request.json');`
`29`	`29`
`30`		`- $response = $this->actingAs(self::$user, 'web')->json('post', '/nova-api/welcome-bonus-resources', $data);`
	`30`	`+ $response = $this->novaActingAs(self::$user)->novaCreateResource(WelcomeBonus::class, $data);`
`31`	`31`
`32`	`32`	`$response->assertCreated();`
`33`	`33`
`@@ -39,7 +39,7 @@ public function testCreate(): void`
`39`	`39`
`40`	`40`	`public function testCreateNoAuth(): void`
`41`	`41`	`{`
`42`		`- $response = $this->json('post', '/nova-api/welcome-bonus-resources');`
	`42`	`+ $response = $this->novaCreateResource(Card::class);`
`43`	`43`
`44`	`44`	`$response->assertUnauthorized();`
`45`	`45`
`@@ -48,7 +48,7 @@ public function testCreateNoAuth(): void`
`48`	`48`
`49`	`49`	`public function testCreateValidationError(): void`
`50`	`50`	`{`
`51`		`- $response = $this->actingAs(self::$user, 'web')->json('post', '/nova-api/welcome-bonus-resources');`
	`51`	`+ $response = $this->novaActingAs(self::$user)->novaCreateResource(WelcomeBonus::class);`
`52`	`52`
`53`	`53`	`$response->assertUnprocessable();`
`54`	`54`
`@@ -62,7 +62,7 @@ public function testUpdate(): void`
`62`	`62`	`{`
`63`	`63`	`$data = $this->getJsonFixture('update_welcome_bonus_request.json');`
`64`	`64`
`65`		`- $response = $this->actingAs(self::$user, 'web')->json('put', '/nova-api/welcome-bonus-resources/1', $data);`
	`65`	`+ $response = $this->novaActingAs(self::$user)->novaUpdateResource(WelcomeBonus::class, 1, $data);`
`66`	`66`
`67`	`67`	`$response->assertNoContent();`
`68`	`68`
`@@ -74,21 +74,21 @@ public function testUpdateNotExists(): void`
`74`	`74`	`{`
`75`	`75`	`$data = $this->getJsonFixture('update_welcome_bonus_request.json');`
`76`	`76`
`77`		`- $response = $this->actingAs(self::$user, 'web')->json('put', '/nova-api/welcome-bonus-resources/0', $data);`
	`77`	`+ $response = $this->novaActingAs(self::$user)->novaUpdateResource(WelcomeBonus::class, 0, $data);`
`78`	`78`
`79`	`79`	`$response->assertNotFound();`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`public function testUpdateNoAuth(): void`
`83`	`83`	`{`
`84`		`- $response = $this->json('put', '/nova-api/welcome-bonus-resources/1');`
	`84`	`+ $response = $this->novaUpdateResource(WelcomeBonus::class, 1);`
`85`	`85`
`86`	`86`	`$response->assertUnauthorized();`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`public function testUpdateValidationError(): void`
`90`	`90`	`{`
`91`		`- $response = $this->actingAs(self::$user, 'web')->json('put', '/nova-api/welcome-bonus-resources/4');`
	`91`	`+ $response = $this->novaActingAs(self::$user)->novaUpdateResource(WelcomeBonus::class, 4);`
`92`	`92`
`93`	`93`	`$response->assertUnprocessable();`
`94`	`94`
`@@ -98,7 +98,7 @@ public function testUpdateValidationError(): void`
`98`	`98`
`99`	`99`	`public function testGetUpdatableFields(): void`
`100`	`100`	`{`
`101`		`- $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/1/update-fields');`
	`101`	`+ $response = $this->novaActingAs(self::$user)->novaGetUpdatableFields(WelcomeBonus::class, 1);`
`102`	`102`
`103`	`103`	`$response->assertOk();`
`104`	`104`
`@@ -108,9 +108,10 @@ public function testGetUpdatableFields(): void`
`108`	`108`
`109`	`109`	`public function testDelete(): void`
`110`	`110`	`{`
`111`		`- $response = $this->actingAs(self::$user, 'web')->json('delete', '/nova-api/welcome-bonus-resources', [`
`112`		`- 'resources' => [1, 2]`
`113`		`- ]);`
	`111`	`+ $response = $this->novaActingAs(self::$user)->novaDeleteResource(`
	`112`	`+ resourceClass: WelcomeBonus::class,`
	`113`	`+ resourceIds: [1, 2],`
	`114`	`+ );`
`114`	`115`
`115`	`116`	`$response->assertOk();`
`116`	`117`
`@@ -120,25 +121,27 @@ public function testDelete(): void`
`120`	`121`
`121`	`122`	`public function testDeleteNotExists(): void`
`122`	`123`	`{`
`123`		`- $response = $this->actingAs(self::$user, 'web')->json('delete', '/nova-api/welcome-bonus-resources', [`
`124`		`- 'resources' => [0]`
`125`		`- ]);`
	`124`	`+ $response = $this->novaActingAs(self::$user)->novaDeleteResource(`
	`125`	`+ resourceClass: WelcomeBonus::class,`
	`126`	`+ resourceIds: [0],`
	`127`	`+ );`
`126`	`128`
`127`	`129`	`$response->assertNotFound();`
`128`	`130`	`}`
`129`	`131`
`130`	`132`	`public function testDeleteNoAuth(): void`
`131`	`133`	`{`
`132`		`- $response = $this->json('delete', '/nova-api/welcome-bonus-resources', [`
`133`		`- 'resources' => [1, 2]`
`134`		`- ]);`
	`134`	`+ $response = $this->novaDeleteResource(`
	`135`	`+ resourceClass: WelcomeBonus::class,`
	`136`	`+ resourceIds: [1, 2],`
	`137`	`+ );`
`135`	`138`
`136`	`139`	`$response->assertUnauthorized();`
`137`	`140`	`}`
`138`	`141`
`139`	`142`	`public function testGet(): void`
`140`	`143`	`{`
`141`		`- $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/1');`
	`144`	`+ $response = $this->novaActingAs(self::$user)->novaGetResource(WelcomeBonus::class, 1);`
`142`	`145`
`143`	`146`	`$response->assertOk();`
`144`	`147`
`@@ -148,28 +151,34 @@ public function testGet(): void`
`148`	`151`
`149`	`152`	`public function testGetNotExists(): void`
`150`	`153`	`{`
`151`		`- $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/0');`
	`154`	`+ $response = $this->novaActingAs(self::$user)->novaGetResource(WelcomeBonus::class, 0);`
`152`	`155`
`153`	`156`	`$response->assertNotFound();`
`154`	`157`	`}`
`155`	`158`
`156`	`159`	`public function testGetNoAuth(): void`
`157`	`160`	`{`
`158`		`- $response = $this->json('get', '/nova-api/welcome-bonus-resources/1');`
	`161`	`+ $response = $this->novaGetResource(WelcomeBonus::class, 1);`
`159`	`162`
`160`	`163`	`$response->assertUnauthorized();`
`161`	`164`	`}`
`162`	`165`
`163`	`166`	`public function testSearchUnauthorized(): void`
`164`	`167`	`{`
`165`		`- $response = $this->json('get', '/nova-api/welcome-bonus-resources');`
	`168`	`+ $response = $this->novaSearchResource(`
	`169`	`+ resourceClass: WelcomeBonus::class,`
	`170`	`+ request: [`
	`171`	`+ 'orderBy' => 'id',`
	`172`	`+ 'orderByDirection' => 'asc',`
	`173`	`+ ],`
	`174`	`+ );`
`166`	`175`
`167`	`176`	`$response->assertUnauthorized();`
`168`	`177`	`}`
`169`	`178`
`170`	`179`	`public function testGetFieldsVisibleOnCreate(): void`
`171`	`180`	`{`
`172`		`- $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/creation-fields');`
	`181`	`+ $response = $this->novaActingAs(self::$user)->novaGetCreationFields(WelcomeBonus::class);`
`173`	`182`
`174`	`183`	`$response->assertOk();`
`175`	`184`
`@@ -181,14 +190,14 @@ public function getRunWelcomeBonusActionsData(): array`
`181`	`190`	`{`
`182`	`191`	`return [`
`183`	`192`	`[`
`184`		`- 'action' => 'publish-post-action',`
	`193`	`+ 'action' => PublishPostAction::class,`
`185`	`194`	`'request' => [`
`186`	`195`	`'resources' => '1,2',`
`187`	`196`	`],`
`188`	`197`	`'state' => 'run_publish_post_action_state.json',`
`189`	`198`	`],`
`190`	`199`	`[`
`191`		`- 'action' => 'un-publish-post-action',`
	`200`	`+ 'action' => UnPublishPostAction::class,`
`192`	`201`	`'request' => [`
`193`	`202`	`'resources' => '1,2',`
`194`	`203`	`],`
`@@ -202,7 +211,7 @@ public function getRunWelcomeBonusActionsData(): array`
`202`	`211`	`*/`
`203`	`212`	`public function testRunWelcomeBonusActions($action, $request, $welcome_bonusesStateFixture): void`
`204`	`213`	`{`
`205`		`- $response = $this->actingAs(self::$user, 'web')->json('post', "/nova-api/welcome-bonus-resources/action?action={$action}", $request);`
	`214`	`+ $response = $this->novaActingAs(self::$user)->json('post', "/nova-api/welcome-bonus-resources/action?action={$action}", $request);`
`206`	`215`
`207`	`216`	`$response->assertOk();`
`208`	`217`
`@@ -216,15 +225,11 @@ public function getWelcomeBonusActionsData(): array`
`216`	`225`	`{`
`217`	`226`	`return [`
`218`	`227`	`[`
`219`		`- 'request' => [`
`220`		`- 'resources' => '1,2',`
`221`		`- ],`
	`228`	`+ 'resources' => [1, 2],`
`222`	`229`	`'response_fixture' => 'get_welcome_bonus_actions_publish_post_action.json',`
`223`	`230`	`],`
`224`	`231`	`[`
`225`		`- 'request' => [`
`226`		`- 'resources' => '1,2',`
`227`		`- ],`
	`232`	`+ 'resources' => [1, 2],`
`228`	`233`	`'response_fixture' => 'get_welcome_bonus_actions_un_publish_post_action.json',`
`229`	`234`	`],`
`230`	`235`	`];`
`@@ -233,9 +238,9 @@ public function getWelcomeBonusActionsData(): array`
`233`	`238`	`/**`
`234`	`239`	`* @dataProvider getWelcomeBonusActionsData`
`235`	`240`	`*/`
`236`		`- public function testGetWelcomeBonusActions(array $request, string $responseFixture): void`
	`241`	`+ public function testGetWelcomeBonusActions(array $resources, string $responseFixture): void`
`237`	`242`	`{`
`238`		`- $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources/actions', $request);`
	`243`	`+ $response = $this->novaActingAs(self::$user)->novaGetActions(WelcomeBonus::class, $resources);`
`239`	`244`
`240`	`245`	`$response->assertOk();`
`241`	`246`
`@@ -266,7 +271,7 @@ public function getWelcomeBonusFiltersData(): array`
`266`	`271`	`*/`
`267`	`272`	`public function testFilterWelcomeBonus(array $request, string $responseFixture): void`
`268`	`273`	`{`
`269`		`- $response = $this->actingAs(self::$user, 'web')->json('get', '/nova-api/welcome-bonus-resources', $request);`
	`274`	`+ $response = $this->novaActingAs(self::$user)->novaSearchResource(WelcomeBonus::class, $request);`
`270`	`275`
`271`	`276`	`$response->assertOk();`
`272`	`277`