From 2c1570f44e8bcc01a9e8f3f820433cd359c772e5 Mon Sep 17 00:00:00 2001 From: Ruslan Guskov Date: Tue, 27 May 2025 15:14:43 +0300 Subject: [PATCH 1/6] refactor: remove useless faker import --- stubs/factory.blade.php | 6 +++++- tests/fixtures/CommandTest/factory.php | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/stubs/factory.blade.php b/stubs/factory.blade.php index e53798e5..fa377f73 100644 --- a/stubs/factory.blade.php +++ b/stubs/factory.blade.php @@ -1,6 +1,10 @@ namespace {{$namespace}}; -use Faker\Generator as Faker; +@if(!empty($fields)) + use Faker\Generator as Faker; + +@endif + use Illuminate\Database\Eloquent\Factories\Factory; use {{$modelNamespace}}\{{$entity}}; diff --git a/tests/fixtures/CommandTest/factory.php b/tests/fixtures/CommandTest/factory.php index 9b31f8a5..141edaa2 100644 --- a/tests/fixtures/CommandTest/factory.php +++ b/tests/fixtures/CommandTest/factory.php @@ -2,7 +2,6 @@ namespace RonasIT\Support\Tests\Support\Command\Factories; -use Faker\Generator as Faker; use Illuminate\Database\Eloquent\Factories\Factory; use RonasIT\Support\Tests\Support\Command\Models\Post; From 5334c5a20c07375d41ffb98d2eff41c2650bccdd Mon Sep 17 00:00:00 2001 From: Ruslan Guskov Date: Tue, 27 May 2025 15:16:21 +0300 Subject: [PATCH 2/6] fix:tests --- tests/fixtures/CommandTest/factory.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/fixtures/CommandTest/factory.php b/tests/fixtures/CommandTest/factory.php index 141edaa2..9b31f8a5 100644 --- a/tests/fixtures/CommandTest/factory.php +++ b/tests/fixtures/CommandTest/factory.php @@ -2,6 +2,7 @@ namespace RonasIT\Support\Tests\Support\Command\Factories; +use Faker\Generator as Faker; use Illuminate\Database\Eloquent\Factories\Factory; use RonasIT\Support\Tests\Support\Command\Models\Post; From cd386f9076f60efcc805dfc346312f2f4f635087 Mon Sep 17 00:00:00 2001 From: Ruslan Guskov Date: Tue, 27 May 2025 15:26:30 +0300 Subject: [PATCH 3/6] fix:tests --- tests/fixtures/CommandTest/factory.php | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/fixtures/CommandTest/factory.php b/tests/fixtures/CommandTest/factory.php index 9b31f8a5..141edaa2 100644 --- a/tests/fixtures/CommandTest/factory.php +++ b/tests/fixtures/CommandTest/factory.php @@ -2,7 +2,6 @@ namespace RonasIT\Support\Tests\Support\Command\Factories; -use Faker\Generator as Faker; use Illuminate\Database\Eloquent\Factories\Factory; use RonasIT\Support\Tests\Support\Command\Models\Post; From 95c09d72588f4561360e4be5c6b830ad73379d8a Mon Sep 17 00:00:00 2001 From: Ruslan Guskov Date: Tue, 27 May 2025 15:29:20 +0300 Subject: [PATCH 4/6] fix: move faker import to third line --- stubs/factory.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/factory.blade.php b/stubs/factory.blade.php index fa377f73..b4c3e78b 100644 --- a/stubs/factory.blade.php +++ b/stubs/factory.blade.php @@ -1,10 +1,10 @@ namespace {{$namespace}}; - @if(!empty($fields)) use Faker\Generator as Faker; @endif + use Illuminate\Database\Eloquent\Factories\Factory; use {{$modelNamespace}}\{{$entity}}; From 820b869eb0e5c46ca6fc57962ff042d3f5d4bb1e Mon Sep 17 00:00:00 2001 From: Ruslan Guskov Date: Tue, 27 May 2025 15:29:20 +0300 Subject: [PATCH 5/6] fix: move faker import to third line --- stubs/factory.blade.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/stubs/factory.blade.php b/stubs/factory.blade.php index fa377f73..ec46880a 100644 --- a/stubs/factory.blade.php +++ b/stubs/factory.blade.php @@ -1,10 +1,7 @@ namespace {{$namespace}}; -@if(!empty($fields)) - use Faker\Generator as Faker; - +@if(!empty($fields))use Faker\Generator as Faker; @endif - use Illuminate\Database\Eloquent\Factories\Factory; use {{$modelNamespace}}\{{$entity}}; From 93320b33ec937f795d6559e33f9a9fddd0c9ae77 Mon Sep 17 00:00:00 2001 From: DenTray Date: Thu, 29 May 2025 09:31:48 +0600 Subject: [PATCH 6/6] Update stubs/factory.blade.php --- stubs/factory.blade.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stubs/factory.blade.php b/stubs/factory.blade.php index ec46880a..4cb1fd09 100644 --- a/stubs/factory.blade.php +++ b/stubs/factory.blade.php @@ -1,6 +1,7 @@ namespace {{$namespace}}; -@if(!empty($fields))use Faker\Generator as Faker; +@if (!empty($fields)) +use Faker\Generator as Faker; @endif use Illuminate\Database\Eloquent\Factories\Factory; use {{$modelNamespace}}\{{$entity}};