Skip to content

Commit a5f28dd

Browse files
committed
fix: remarks from reviewer
1 parent 86be682 commit a5f28dd

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

src/Commands/InitCommand.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,18 @@ public function handle(): void
119119
}
120120

121121
$this->updateEnvFile('.env.development', [
122+
'APP_NAME' => $this->appName,
122123
'APP_URL' => $this->appUrl,
123124
'APP_MAINTENANCE_DRIVER' => 'cache',
124125
'CACHE_STORE' => 'redis',
125126
'QUEUE_CONNECTION' => 'redis',
126127
'SESSION_DRIVER' => 'redis',
127-
...$envConfig,
128+
'DB_CONNECTION' => $this->dbConnection,
129+
'DB_HOST' => '',
130+
'DB_PORT' => '',
131+
'DB_DATABASE' => '',
132+
'DB_USERNAME' => '',
133+
'DB_PASSWORD' => '',
128134
]);
129135

130136
$this->info('Project initialized successfully!');

tests/fixtures/InitCommandTest/env.development_app_name_not_pascal_case.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ APP_LOG_LEVEL=debug
66
APP_URL=https://mysite.com
77

88
DB_CONNECTION=pgsql
9-
DB_HOST=pgsql
10-
DB_PORT=5432
11-
DB_DATABASE=postgres
12-
DB_USERNAME=postgres
9+
DB_HOST=
10+
DB_PORT=
11+
DB_DATABASE=
12+
DB_USERNAME=
1313
DB_PASSWORD=
1414

1515
BROADCAST_DRIVER=log

tests/fixtures/InitCommandTest/env.development_app_name_pascal_case.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ APP_LOG_LEVEL=debug
66
APP_URL=https://mysite.com
77

88
DB_CONNECTION=pgsql
9-
DB_HOST=pgsql
10-
DB_PORT=5432
11-
DB_DATABASE=postgres
12-
DB_USERNAME=postgres
9+
DB_HOST=
10+
DB_PORT=
11+
DB_DATABASE=
12+
DB_USERNAME=
1313
DB_PASSWORD=
1414

1515
BROADCAST_DRIVER=log

0 commit comments

Comments
 (0)