fix: remarks from reviewer

Author: artengin

config/auto-doc.php

@@ -46,7 +46,7 @@ class InitCommand extends Command implements Isolatable
 
     protected $description = 'Initialize required project parameters to run DEV environment';
 
-    protected string $emailTeamLead;
+    protected string $codeOwnerEmail;
 
     protected array $resources = [];
 
@@ -77,8 +77,8 @@ public function handle(): void
 
         $kebabName = Str::kebab($this->appName);
 
-        $this->emailTeamLead = $this->validateInput(
-            method: fn () => $this->ask('Please specify a Code Owner/Team Lead\'s email', Str::before($this->reviewer, '@')),
+        $this->codeOwnerEmail = $this->validateInput(
+            method: fn () => $this->ask('Please specify a Code Owner/Team Lead\'s email'),
             field: 'email of code owner / team lead',
             rules: 'required|email',
         );
@@ -188,16 +188,16 @@ public function handle(): void
             shell_exec("{$shellCommand} --ansi");
         }
 
-        $this->setAutoDocContactEmail($this->emailTeamLead);
-        
+        $this->setAutoDocContactEmail($this->codeOwnerEmail);
+
         Artisan::call('migrate');
     }
 
     protected function setAutoDocContactEmail(string $email): void
     {
         $config = ArrayFile::open(base_path('config/auto-doc.php'));
 
-        $config->set('info.contact.email',  $email);
+        $config->set('info.contact.email', $email);
 
         $config->write();
     }
@@ -291,10 +291,6 @@ protected function fillContacts(): void
 
         foreach (self::CONTACTS_ITEMS as $key => $title) {
             if ($link = $this->ask("Please enter a {$title}'s email", '')) {
-                if (!empty($link) && $key === $this->emailTeamLead) {
-                    $this->reviewer = $link;
-                }
-
                 $this->setReadmeValue($filePart, "{$key}_link", $link);
             } else {
                 $this->emptyValuesList[] = "{$title}'s email";
@@ -303,7 +299,7 @@ protected function fillContacts(): void
             $this->removeTag($filePart, $key);
         }
 
-        $this->setReadmeValue($filePart, "team_lead_link", $this->emailTeamLead);
+        $this->setReadmeValue($filePart, 'team_lead_link', $this->codeOwnerEmail);
 
         $this->updateReadmeFile($filePart);
     }

src/Commands/InitCommand.php

@@ -10,7 +10,9 @@ class InitCommandTest extends TestCase
 
     public function testRunWithoutAdminAndReadmeCreationConvertAppNameToPascalCaseTelescopeAlreadyInstalled()
     {
-        $this->mockArrayFilePutContent();
+        $this->mockUpdateConfigGetContent('config/auto-doc.php', 'auto_doc.php');
+
+        $this->mockUpdateConfigPutContent('config/auto-doc.php', 'auto_doc_after_changes.php');
 
         $this->mockFileGetContent(
             [
@@ -56,7 +58,9 @@ public function testRunWithoutAdminAndReadmeCreationConvertAppNameToPascalCaseTe
 
     public function testRunWithoutAdminAndReadmeCreation()
     {
-        $this->mockArrayFilePutContent();
+        $this->mockUpdateConfigGetContent('config/auto-doc.php', 'auto_doc.php');
+
+        $this->mockUpdateConfigPutContent('config/auto-doc.php', 'auto_doc_after_changes.php');
 
         $this->mockFileGetContent(
             [
@@ -104,7 +108,9 @@ public function testRunWithoutAdminAndReadmeCreation()
 
     public function testRunWithAdminAndWithoutReadmeCreation()
     {
-        $this->mockArrayFilePutContent();
+        $this->mockUpdateConfigGetContent('config/auto-doc.php', 'auto_doc.php');
+
+        $this->mockUpdateConfigPutContent('config/auto-doc.php', 'auto_doc_after_changes.php');
 
         $this->mockFileGetContent(
             [
@@ -156,7 +162,9 @@ public function testRunWithAdminAndWithoutReadmeCreation()
 
     public function testRunWithAdminAndDefaultReadmeCreation()
     {
-        $this->mockArrayFilePutContent();
+        $this->mockUpdateConfigGetContent('config/auto-doc.php', 'auto_doc.php');
+
+        $this->mockUpdateConfigPutContent('config/auto-doc.php', 'auto_doc_after_changes.php');
 
         $this->mockFileGetContent(
             [
@@ -334,7 +342,9 @@ public function testRunWithAdminAndDefaultReadmeCreation()
 
     public function testRunWithAdminAndPartialReadmeCreation()
     {
-        $this->mockArrayFilePutContent();
+        $this->mockUpdateConfigGetContent('config/auto-doc.php', 'auto_doc.php');
+
+        $this->mockUpdateConfigPutContent('config/auto-doc.php', 'auto_doc_after_changes.php');
 
         $this->mockFileGetContent(
             [
@@ -451,7 +461,9 @@ public function testRunWithAdminAndPartialReadmeCreation()
 
     public function testRunWithAdminAndFullReadmeCreationAndRemovingInitializatorInstallationMedia()
     {
-        $this->mockArrayFilePutContent();
+        $this->mockUpdateConfigGetContent('config/auto-doc.php', 'auto_doc.php');
+
+        $this->mockUpdateConfigPutContent('config/auto-doc.php', 'auto_doc_after_changes.php');
 
         $this->mockFileGetContent(
             [

tests/InitCommandTest.php

@@ -70,16 +70,30 @@ protected function getTemplate(string $template): string
         return file_get_contents(base_path("/resources/md/readme/{$template}"));
     }
 
-    public function mockArrayFilePutContent(): void
+    public function mockUpdateConfigGetContent(string $path, string $expectedContent): void
     {
         $this->mockNativeFunction(
             '\Winter\LaravelConfigWriter',
             [
-                [
-                    'function' => 'file_put_contents',
-                    'arguments' => [base_path('config/auto-doc.php'), $this->getFixture('auto-doc.php')],
-                    'result' => $this->getFixture('auto-doc.php'),
-                ],
+                $this->functionCall('file_exists', [
+                    base_path($path),
+                ], true),
+                $this->functionCall('file_get_contents', [
+                    base_path($path),
+                ], $this->getFixture($expectedContent)),
+            ]
+        );    
+    }
+
+    public function mockUpdateConfigPutContent(string $path, string $expectedContent): void
+    {
+        $this->mockNativeFunction(
+            '\Winter\LaravelConfigWriter',
+            [
+                $this->functionCall('file_put_contents', [
+                    base_path($path),
+                    $this->getFixture($expectedContent),
+                ], $this->getFixture($expectedContent)),
             ]
         );    
     }