Skip to content

Commit bbf1fa4

Browse files
committed
fix: remarks from reviewer
1 parent 9bda996 commit bbf1fa4

File tree

5 files changed

+10
-266
lines changed

5 files changed

+10
-266
lines changed

src/Commands/InitCommand.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,17 @@ public function handle(): void
210210
$this->readmeGenerator->fillClerkAuthType();
211211
}
212212
}
213+
}
214+
215+
if ($this->confirm('Would you use Renovate dependabot?', true)) {
216+
$this->saveRenovateJSON();
217+
218+
if ($shouldGenerateReadme) {
219+
$this->readmeGenerator->fillRenovate();
220+
}
221+
}
213222

223+
if ($shouldGenerateReadme) {
214224
$this->readmeGenerator->save();
215225

216226
$this->info('README generated successfully!');
@@ -224,16 +234,6 @@ public function handle(): void
224234
}
225235
}
226236

227-
if ($this->confirm('Would you use Renovate dependabot?', true)) {
228-
$this->saveRenovateJSON();
229-
230-
if ($shouldGenerateReadme) {
231-
$this->readmeGenerator->fillRenovate();
232-
233-
$this->readmeGenerator->save();
234-
}
235-
}
236-
237237
if (!class_exists(\Laravel\Telescope\TelescopeServiceProvider::class)) {
238238
array_push(
239239
$this->shellCommands,

tests/InitCommandTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ public function testRunWithAdminAndDefaultReadmeCreation()
264264
$this->callFileGetContent($this->generateResourcePath('md/readme/CREDENTIALS_AND_ACCESS.md'), $this->getReadmeTemplateContent('CREDENTIALS_AND_ACCESS.md')),
265265
$this->callFileGetContent($this->generateResourcePath('md/readme/CLERK.md'), $this->getReadmeTemplateContent('CLERK.md')),
266266
$this->callFileGetContent($this->generateResourcePath('md/readme/RENOVATE.md'), $this->getReadmeTemplateContent('RENOVATE.md')),
267-
$this->callFilePutContent('README.md', $this->getFixture('default_readme.md')),
268267
$this->callFilePutContent('README.md', $this->getFixture('default_readme_after_using_renovate.md')),
269268
);
270269

@@ -516,7 +515,6 @@ public function testRunWithAdminAndFullReadmeCreationAndRemovingInitializatorIns
516515
$this->callFileGetContent($this->generateResourcePath('md/readme/ENVIRONMENTS.md'), $this->getReadmeTemplateContent('ENVIRONMENTS.md')),
517516
$this->callFileGetContent($this->generateResourcePath('md/readme/CREDENTIALS_AND_ACCESS.md'), $this->getReadmeTemplateContent('CREDENTIALS_AND_ACCESS.md')),
518517
$this->callFileGetContent($this->generateResourcePath('md/readme/RENOVATE.md'), $this->getReadmeTemplateContent('RENOVATE.md')),
519-
$this->callFilePutContent('README.md', $this->getFixture('full_readme.md')),
520518
$this->callFilePutContent('README.md', $this->getFixture('full_readme_after_using_renovate.md')),
521519
);
522520

@@ -780,7 +778,6 @@ public function testRunWithClerkMobileAppWithPintInstalled(): void
780778
$this->callFileGetContent($this->generateResourcePath('md/readme/CREDENTIALS_AND_ACCESS.md'), $this->getReadmeTemplateContent('CREDENTIALS_AND_ACCESS.md')),
781779
$this->callFileGetContent($this->generateResourcePath('md/readme/CLERK.md'), $this->getReadmeTemplateContent('CLERK.md')),
782780
$this->callFileGetContent($this->generateResourcePath('md/readme/RENOVATE.md'), $this->getReadmeTemplateContent('RENOVATE.md')),
783-
$this->callFilePutContent('README.md', $this->getFixture('default_readme_with_mobile_app.md')),
784781
$this->callFilePutContent('README.md', $this->getFixture('default_readme_with_mobile_app_after_using_renovate.md')),
785782
);
786783

tests/fixtures/InitCommandTest/default_readme.md

Lines changed: 0 additions & 85 deletions
This file was deleted.

tests/fixtures/InitCommandTest/default_readme_with_mobile_app.md

Lines changed: 0 additions & 85 deletions
This file was deleted.

tests/fixtures/InitCommandTest/full_readme.md

Lines changed: 0 additions & 83 deletions
This file was deleted.

0 commit comments

Comments
 (0)