Merge pull request #27 from RonasIT/26_install_telescope_if_not_exists

feat: install telescope if not exists

Author: DenTray

src/Commands/InitCommand.php

@@ -60,8 +60,6 @@ class InitCommand extends Command implements Isolatable
         'composer require ronasit/laravel-helpers',
         'composer require ronasit/laravel-swagger',
         'composer require --dev ronasit/laravel-entity-generator',
-        'composer require ronasit/laravel-telescope-extension',
-        'php artisan telescope:install',
     ];
 
     protected string $appName;
@@ -141,6 +139,14 @@ public function handle(): void
             }
         }
 
+        if (!class_exists(\Laravel\Telescope\TelescopeServiceProvider::class)) {
+            array_push(
+                $this->shellCommands,
+                'composer require ronasit/laravel-telescope-extension',
+                'php artisan telescope:install',
+            );
+        }
+
         if ($this->confirm('Do you want to install media package?')) {
             $this->shellCommands[] = 'composer require ronasit/laravel-media';
         }

tests/InitCommandTest.php

@@ -8,7 +8,7 @@ class InitCommandTest extends TestCase
 {
     use InitCommandMockTrait;
 
-    public function testRunWithoutAdminAndReadmeCreation()
+    public function testRunWithoutAdminAndReadmeCreationConvertAppNameToPascalCaseTelescopeAlreadyInstalled()
     {
         $this->mockFileGetContent(
             [
@@ -24,36 +24,32 @@ public function testRunWithoutAdminAndReadmeCreation()
         $this->mockFilePutContent(
             'env.example_app_name_pascal_case.yml',
             'env.development_app_name_pascal_case.yml',
-            [
-                'renovate.json',
-                $this->getFixture('renovate.json'),
-                'optionalParameter',
-                'optionalParameter',
-            ],
         );
 
+        $this->mockClassExists([
+            'arguments' => ['Laravel\Telescope\TelescopeServiceProvider', true],
+        ]);
+
         $this->mockShellExec(
             ['arguments' => 'composer require ronasit/laravel-helpers --ansi'],
             ['arguments' => 'composer require ronasit/laravel-swagger --ansi'],
             ['arguments' => 'composer require --dev ronasit/laravel-entity-generator --ansi'],
-            ['arguments' => 'composer require ronasit/laravel-telescope-extension --ansi'],
-            ['arguments' => 'php artisan telescope:install --ansi'],
         );
 
         $this
-            ->artisan('init "MyApp"')
+            ->artisan('init "My App"')
+            ->expectsConfirmation('The application name is not in PascalCase, would you like to use MyApp', 'yes')
             ->expectsOutput('Project initialized successfully!')
             ->expectsQuestion('Please enter an application URL', 'https://mysite.com')
             ->expectsConfirmation('Do you want to generate an admin user?')
             ->expectsConfirmation('Do you want to generate a README file?')
-            ->expectsConfirmation('Would you use Renovate dependabot?', 'yes')
-            ->expectsQuestion('Please type username of the project reviewer', 'reviewer')
+            ->expectsConfirmation('Would you use Renovate dependabot?')
             ->expectsConfirmation('Do you want to install media package?')
             ->expectsConfirmation('Do you want to uninstall project-initializator package?')
             ->assertExitCode(0);
     }
 
-    public function testRunWithoutAdminAndReadmeCreationConvertAppNameToPascalCase()
+    public function testRunWithoutAdminAndReadmeCreation()
     {
         $this->mockFileGetContent(
             [
@@ -69,6 +65,12 @@ public function testRunWithoutAdminAndReadmeCreationConvertAppNameToPascalCase()
         $this->mockFilePutContent(
             'env.example_app_name_pascal_case.yml',
             'env.development_app_name_pascal_case.yml',
+            [
+                'renovate.json',
+                $this->getFixture('renovate.json'),
+                'optionalParameter',
+                'optionalParameter',
+            ],
         );
 
         $this->mockShellExec(
@@ -80,13 +82,13 @@ public function testRunWithoutAdminAndReadmeCreationConvertAppNameToPascalCase()
         );
 
         $this
-            ->artisan('init "My App"')
-            ->expectsConfirmation('The application name is not in PascalCase, would you like to use MyApp', 'yes')
+            ->artisan('init "MyApp"')
             ->expectsOutput('Project initialized successfully!')
             ->expectsQuestion('Please enter an application URL', 'https://mysite.com')
             ->expectsConfirmation('Do you want to generate an admin user?')
             ->expectsConfirmation('Do you want to generate a README file?')
-            ->expectsConfirmation('Would you use Renovate dependabot?')
+            ->expectsConfirmation('Would you use Renovate dependabot?', 'yes')
+            ->expectsQuestion('Please type username of the project reviewer', 'reviewer')
             ->expectsConfirmation('Do you want to install media package?')
             ->expectsConfirmation('Do you want to uninstall project-initializator package?')
             ->assertExitCode(0);

tests/Support/Traits/InitCommandMockTrait.php

@@ -57,6 +57,17 @@ public function mockFileGetContent(array ...$rawCallChain): void
         );
     }
 
+    protected function mockClassExists(array ...$rawCallChain): void
+    {
+        $callChain = array_map(fn ($call) => $this->functionCall(
+            name: 'class_exists',
+            arguments: Arr::wrap($call['arguments']),
+            result: Arr::get($call, 'result', true),
+        ), $rawCallChain);
+
+        $this->mockNativeFunction('RonasIT\ProjectInitializator\Commands', $callChain);
+    }
+
     protected function getTemplate(string $template): string
     {
         return file_get_contents(dirname(__DIR__, 3) . "/resources/md/readme/{$template}");