Merge pull request #348 from SciML/ChrisRackauckas-patch-1

Fiox solution handling for KrylovJL on subarrays

Author: ChrisRackauckas

src/iterative_wrappers.jl

@@ -282,6 +282,12 @@ function SciMLBase.solve!(cache::LinearCache, alg::KrylovJL; kwargs...)
         ReturnCode.Success
     end
 
+    # Copy the solution to the allocated output vector
+    cacheval = @get_cacheval(cache, :KrylovJL_GMRES)
+    if cache.u !== cacheval.x
+        cache.u .= cacheval.x
+    end
+
     return SciMLBase.build_linear_solution(alg, cache.u, resid, cache;
         iters = stats.niter)
 end

test/basictests.jl

@@ -459,3 +459,10 @@ end
         end
     end
 end # testset
+
+# https://github.com/SciML/LinearSolve.jl/issues/347
+A = rand(4, 4); b = rand(4); u0 = zeros(4);
+lp = LinearProblem(A, b; u0 = view(u0, :));
+truesol = solve(lp, LUFactorization())
+krylovsol = solve(lp, KrylovJL_GMRES())
+@test truesol ≈ krylovsol