Merge pull request #829 from jClugstor/blas_errors_fix

Use WarnLevel instead of ErrorLevel for Blas messages by default

Author: ChrisRackauckas

src/LinearSolve.jl

@@ -22,7 +22,7 @@ using SciMLOperators: SciMLOperators, AbstractSciMLOperator, IdentityOperator,
                       MatrixOperator,
                       has_ldiv!, issquare
 using SciMLLogging: SciMLLogging, @SciMLMessage, verbosity_to_int, AbstractVerbositySpecifier, AbstractMessageLevel, AbstractVerbosityPreset,
-                    Silent, InfoLevel, WarnLevel, ErrorLevel, CustomLevel, None, Minimal, Standard, Detailed, All
+                    Silent, InfoLevel, WarnLevel, CustomLevel, None, Minimal, Standard, Detailed, All
 using Setfield: @set, @set!
 using UnPack: @unpack
 using DocStringExtensions: DocStringExtensions

src/verbosity.jl

@@ -106,8 +106,8 @@ function LinearVerbosity(;
             Silent(),
             InfoLevel(),
             Silent(),
-            ErrorLevel(),
-            ErrorLevel(),
+            WarnLevel(),
+            WarnLevel(),
             Silent(),
             Silent(),
             Silent(),
@@ -148,8 +148,8 @@ function LinearVerbosity(;
         KrylovJL_verbosity = Silent(),
         HYPRE_verbosity = InfoLevel(),
         pardiso_verbosity = Silent(),
-        blas_errors = ErrorLevel(),
-        blas_invalid_args = ErrorLevel(),
+        blas_errors = WarnLevel(),
+        blas_invalid_args = WarnLevel(),
         blas_info = Silent(),
         blas_success = Silent(),
         condition_number=Silent(),
@@ -193,8 +193,8 @@ function LinearVerbosity(verbose::AbstractVerbosityPreset)
             KrylovJL_verbosity = Silent(),
             HYPRE_verbosity = Silent(),
             pardiso_verbosity = Silent(),
-            blas_errors = ErrorLevel(),
-            blas_invalid_args = ErrorLevel(),
+            blas_errors = WarnLevel(),
+            blas_invalid_args = WarnLevel(),
             blas_info = Silent(),
             blas_success = Silent(),
             condition_number = Silent(),
@@ -216,8 +216,8 @@ function LinearVerbosity(verbose::AbstractVerbosityPreset)
             KrylovJL_verbosity = CustomLevel(1), # verbose = true in Krylov.jl
             HYPRE_verbosity = InfoLevel(),
             pardiso_verbosity = CustomLevel(1), # verbose = true in Pardiso.jl
-            blas_errors = ErrorLevel(),
-            blas_invalid_args = ErrorLevel(),
+            blas_errors = WarnLevel(),
+            blas_invalid_args = WarnLevel(),
             blas_info = InfoLevel(),
             blas_success = InfoLevel(),
             condition_number = Silent(),
@@ -236,8 +236,8 @@ function LinearVerbosity(verbose::AbstractVerbosityPreset)
             KrylovJL_verbosity = CustomLevel(1),
             HYPRE_verbosity = InfoLevel(),
             pardiso_verbosity = CustomLevel(1), # verbsoe = true in Pardiso.jl
-            blas_errors = ErrorLevel(),
-            blas_invalid_args = ErrorLevel(),
+            blas_errors = WarnLevel(),
+            blas_invalid_args = WarnLevel(),
             blas_info = InfoLevel(),
             blas_success = InfoLevel(),
             condition_number = InfoLevel(),

test/verbosity.jl

@@ -25,7 +25,7 @@ using Test
     end
 
     @testset "Group-level keyword constructors" begin
-        v4_error = LinearVerbosity(error_control = ErrorLevel())
+        v4_error = LinearVerbosity(error_control = SciMLLogging.ErrorLevel())
         @test v4_error.default_lu_fallback isa SciMLLogging.ErrorLevel
 
         v4_numerical = LinearVerbosity(numerical = Silent())
@@ -53,9 +53,9 @@ using Test
 
     @testset "Individual keyword arguments" begin
         v6_individual = LinearVerbosity(
-            default_lu_fallback = ErrorLevel(),
-            KrylovKit_verbosity = InfoLevel(),
-            pardiso_verbosity = Silent()
+            default_lu_fallback = SciMLLogging.ErrorLevel(),
+            KrylovKit_verbosity = SciMLLogging.InfoLevel(),
+            pardiso_verbosity = SciMLLogging.Silent()
         )
         @test v6_individual.default_lu_fallback isa SciMLLogging.ErrorLevel
         @test v6_individual.KrylovKit_verbosity isa SciMLLogging.InfoLevel