fix basic bugs

Author: ChrisRackauckas

src/LinearSolve.jl

@@ -95,6 +95,7 @@ EnumX.@enumx DefaultAlgorithmChoice begin
     CholeskyFactorization
     NormalCholeskyFactorization
     AppleAccelerateLUFactorization
+    MKLLUFactorization
 end
 
 struct DefaultLinearSolver <: SciMLLinearSolveAlgorithm
@@ -104,6 +105,7 @@ end
 include("common.jl")
 include("factorization.jl")
 include("appleaccelerate.jl")
+include("mkl.jl")
 include("simplelu.jl")
 include("simplegmres.jl")
 include("iterative_wrappers.jl")

src/extension_algs.jl

@@ -339,16 +339,6 @@ A wrapper over the IterativeSolvers.jl MINRES.
 """
 function IterativeSolversJL_MINRES end
 
-"""
-```julia
-MKLLUFactorization()
-```
-
-A wrapper over Intel's Math Kernel Library (MKL). Direct calls to MKL in a way that pre-allocates workspace
-to avoid allocations and does not require libblastrampoline.
-"""
-struct MKLLUFactorization <: AbstractFactorization end
-
 """
 ```julia
 MetalLUFactorization()

src/mkl.jl

@@ -1,3 +1,13 @@
+"""
+```julia
+MKLLUFactorization()
+```
+
+A wrapper over Intel's Math Kernel Library (MKL). Direct calls to MKL in a way that pre-allocates workspace
+to avoid allocations and does not require libblastrampoline.
+"""
+struct MKLLUFactorization <: AbstractFactorization end
+
 function getrf!(A::AbstractMatrix{<:Float64};
     ipiv = similar(A, BlasInt, min(size(A, 1), size(A, 2))),
     info = Ref{BlasInt}(),
@@ -91,7 +101,7 @@ end
 default_alias_A(::MKLLUFactorization, ::Any, ::Any) = false
 default_alias_b(::MKLLUFactorization, ::Any, ::Any) = false
 
-function LinearSolve.init_cacheval(alg::MKLLUFactorization, A, b, u, Pl, Pr,
+function init_cacheval(alg::MKLLUFactorization, A, b, u, Pl, Pr,
     maxiters::Int, abstol, reltol, verbose::Bool,
     assumptions::OperatorAssumptions)
     ArrayInterface.lu_instance(convert(AbstractMatrix, A)), Ref{BlasInt}()