Skip to content

Commit a2c80c8

Browse files
Add version guard for MKLLUFactorization JET test
MKLLUFactorization also passes on Julia 1.12+ due to improved type inference that can see through the type barrier we added for _format_context_pair. The runtime dispatch in the BLAS logging code is still present on Julia < 1.12, but Julia 1.12+ has sufficient type inference improvements to optimize through the @noinline ::String type barrier. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 0efcb6a commit a2c80c8

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

test/nopre/jet.jl

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,14 @@ end
8989

9090
# Platform-specific factorizations (may not be available on all systems)
9191
if @isdefined(MKLLUFactorization)
92-
# MKLLUFactorization has one acceptable runtime dispatch in logging code
92+
# MKLLUFactorization has one runtime dispatch in logging code on Julia < 1.12
9393
# (_format_context_pair with Dict{Symbol,Any}) that's isolated behind a type barrier
94-
JET.@test_opt solve(prob, MKLLUFactorization()) broken=true
94+
# Julia 1.12+ has improved type inference that sees through the barrier
95+
if VERSION < v"1.12.0-"
96+
JET.@test_opt solve(prob, MKLLUFactorization()) broken=true
97+
else
98+
JET.@test_opt solve(prob, MKLLUFactorization())
99+
end
95100
end
96101

97102
if Sys.isapple() && @isdefined(AppleAccelerateLUFactorization)

0 commit comments

Comments
 (0)