Merge pull request #69 from SciML/hist

add history purging

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "LinearSolve"
 uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 authors = ["SciML"]
-version = "0.2.3"
+version = "0.2.4"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/iterative_wrappers.jl

@@ -201,10 +201,11 @@ function init_cacheval(alg::IterativeSolversJL, A, b, u, Pl, Pr, maxiters, absto
 end
 
 function SciMLBase.solve(cache::LinearCache, alg::IterativeSolversJL; kwargs...)
-    if cache.isfresh
+    if cache.isfresh || !(alg <: IterativeSolvers.GMRESIterable)
         solver = init_cacheval(alg, cache.A, cache.b, cache.u, cache.Pl, cache.Pr, cache.maxiters, cache.abstol, cache.reltol, cache.verbose)
         cache = set_cacheval(cache, solver)
     end
+    purge_history!(cache.cacheval, cache.u, cache.b)
 
     cache.verbose && println("Using IterativeSolvers.$(alg.generate_iterator)")
     for iter in enumerate(cache.cacheval)
@@ -215,3 +216,15 @@ function SciMLBase.solve(cache::LinearCache, alg::IterativeSolversJL; kwargs...)
 
     return SciMLBase.build_linear_solution(alg,cache.u,nothing,cache)
 end
+
+purge_history!(iter, x, b) = nothing
+function purge_history!(iter::IterativeSolvers.GMRESIterable, x, b)
+  iter.k = 1
+  iter.x  = x
+  iter.b  = b
+
+  iter.residual.current = IterativeSolvers.init!(iter.arnoldi, iter.x, iter.b, iter.Pl, iter.Ax, initially_zero = true)
+  IterativeSolvers.init_residual!(iter.residual, iter.residual.current)
+  iter.β = iter.residual.current
+  nothing
+end

test/runtests.jl

@@ -16,18 +16,22 @@ function test_interface(alg, prob1, prob2)
     A1 = prob1.A; b1 = prob1.b; x1 = prob1.u0
     A2 = prob2.A; b2 = prob2.b; x2 = prob2.u0
 
+    x1 .= false
     y = solve(prob1, alg; cache_kwargs...)
     @test A1 *  y  ≈ b1
 
     cache = SciMLBase.init(prob1,alg; cache_kwargs...) # initialize cache
+    cache.u .= false
     y = solve(cache)
     @test A1 *  y  ≈ b1
 
     cache = LinearSolve.set_A(cache,copy(A2))
+    cache.u .= false
     y = solve(cache)
     @test A2 *  y  ≈ b1
 
     cache = LinearSolve.set_b(cache,b2)
+    cache.u .= false
     y = solve(cache)
     @test A2 *  y  ≈ b2