Refactored Rosenbrock32 and Rosenbrock23

Author: ParamThakkar123

lib/OrdinaryDiffEqRosenbrock/src/interp_func.jl

@@ -3,8 +3,7 @@ function SciMLBase.interp_summary(::Type{cacheType},
         cacheType <:
         Union{Rosenbrock23ConstantCache,
         Rosenbrock32ConstantCache,
-        Rosenbrock23Cache,
-        Rosenbrock32Cache}}
+        RosenbrockCombinedCache}}
     dense ? "specialized 2nd order \"free\" stiffness-aware interpolation" :
     "1st order linear"
 end

lib/OrdinaryDiffEqRosenbrock/src/rosenbrock_caches.jl

@@ -62,7 +62,7 @@ struct RosenbrockCombinedConstantCache{TF, UF, Tab, JType, WType, F, AD} <:
     interp_order::Int
 end
 
-@cache mutable struct Rosenbrock23Cache{uType, rateType, uNoUnitsType, JType, WType,
+@cache mutable struct RosenbrockCombinedCache{uType, rateType, uNoUnitsType, JType, WType,
     TabType, TFType, UFType, F, JCType, GCType,
     RTolType, A, AV, StepLimiter, StageLimiter} <: RosenbrockMutableCache
     u::uType
@@ -95,40 +95,7 @@ end
     stage_limiter!::StageLimiter
 end
 
-@cache mutable struct Rosenbrock32Cache{uType, rateType, uNoUnitsType, JType, WType,
-    TabType, TFType, UFType, F, JCType, GCType,
-    RTolType, A, AV, StepLimiter, StageLimiter} <: RosenbrockMutableCache
-    u::uType
-    uprev::uType
-    k₁::rateType
-    k₂::rateType
-    k₃::rateType
-    du1::rateType
-    du2::rateType
-    f₁::rateType
-    fsalfirst::rateType
-    fsallast::rateType
-    dT::rateType
-    J::JType
-    W::WType
-    tmp::rateType
-    atmp::uNoUnitsType
-    weight::uNoUnitsType
-    tab::TabType
-    tf::TFType
-    uf::UFType
-    linsolve_tmp::rateType
-    linsolve::F
-    jac_config::JCType
-    grad_config::GCType
-    reltol::RTolType
-    alg::A
-    algebraic_vars::AV
-    step_limiter!::StepLimiter
-    stage_limiter!::StageLimiter
-end
-
-function alg_cache(alg::Rosenbrock23, u, rate_prototype, ::Type{uEltypeNoUnits},
+function alg_cache(alg::Union{Rosenbrock23, Rosenbrock32}, u, rate_prototype, ::Type{uEltypeNoUnits},
         ::Type{uBottomEltypeNoUnits}, ::Type{tTypeNoUnits}, uprev, uprev2, f, t,
         dt, reltol, p, calck,
         ::Val{true}) where {uEltypeNoUnits, uBottomEltypeNoUnits, tTypeNoUnits}
@@ -147,7 +114,7 @@ function alg_cache(alg::Rosenbrock23, u, rate_prototype, ::Type{uEltypeNoUnits},
     recursivefill!(atmp, false)
     weight = similar(u, uEltypeNoUnits)
     recursivefill!(weight, false)
-    tab = Rosenbrock23Tableau(constvalue(uBottomEltypeNoUnits))
+    tab = RosenbrockCombinedTableau(constvalue(uBottomEltypeNoUnits))
     tf = TimeGradientWrapper(f, uprev, p)
     uf = UJacobianWrapper(f, t, p)
     linsolve_tmp = zero(rate_prototype)
@@ -170,61 +137,13 @@ function alg_cache(alg::Rosenbrock23, u, rate_prototype, ::Type{uEltypeNoUnits},
     algebraic_vars = f.mass_matrix === I ? nothing :
                      [all(iszero, x) for x in eachcol(f.mass_matrix)]
 
-    Rosenbrock23Cache(u, uprev, k₁, k₂, k₃, du1, du2, f₁,
+    RosenbrockCombinedCache(u, uprev, k₁, k₂, k₃, du1, du2, f₁,
         fsalfirst, fsallast, dT, J, W, tmp, atmp, weight, tab, tf, uf,
         linsolve_tmp,
         linsolve, jac_config, grad_config, reltol, alg, algebraic_vars, alg.step_limiter!,
         alg.stage_limiter!)
 end
 
-function alg_cache(alg::Rosenbrock32, u, rate_prototype, ::Type{uEltypeNoUnits},
-        ::Type{uBottomEltypeNoUnits}, ::Type{tTypeNoUnits}, uprev, uprev2, f, t,
-        dt, reltol, p, calck,
-        ::Val{true}) where {uEltypeNoUnits, uBottomEltypeNoUnits, tTypeNoUnits}
-    k₁ = zero(rate_prototype)
-    k₂ = zero(rate_prototype)
-    k₃ = zero(rate_prototype)
-    du1 = zero(rate_prototype)
-    du2 = zero(rate_prototype)
-    # f₀ = zero(u) fsalfirst
-    f₁ = zero(rate_prototype)
-    fsalfirst = zero(rate_prototype)
-    fsallast = zero(rate_prototype)
-    dT = zero(rate_prototype)
-    tmp = zero(rate_prototype)
-    atmp = similar(u, uEltypeNoUnits)
-    recursivefill!(atmp, false)
-    weight = similar(u, uEltypeNoUnits)
-    recursivefill!(weight, false)
-    tab = Rosenbrock32Tableau(constvalue(uBottomEltypeNoUnits))
-
-    tf = TimeGradientWrapper(f, uprev, p)
-    uf = UJacobianWrapper(f, t, p)
-    linsolve_tmp = zero(rate_prototype)
-   
-    grad_config = build_grad_config(alg, f, tf, du1, t)
-    jac_config = build_jac_config(alg, f, uf, du1, uprev, u, tmp, du2)
-
-    J, W = build_J_W(alg, u, uprev, p, t, dt, f, jac_config, uEltypeNoUnits, Val(true))
-
-    linprob = LinearProblem(W, _vec(linsolve_tmp); u0 = _vec(tmp))
-
-    Pl, Pr = wrapprecs(
-        alg.precs(W, nothing, u, p, t, nothing, nothing, nothing,
-            nothing)..., weight, tmp)
-    linsolve = init(
-        linprob, alg.linsolve, alias = LinearAliasSpecifier(alias_A = true, alias_b = true),
-        Pl = Pl, Pr = Pr,
-        assumptions = LinearSolve.OperatorAssumptions(true))
-
-    algebraic_vars = f.mass_matrix === I ? nothing :
-                     [all(iszero, x) for x in eachcol(f.mass_matrix)]
-
-    Rosenbrock32Cache(u, uprev, k₁, k₂, k₃, du1, du2, f₁, fsalfirst, fsallast, dT, J, W,
-        tmp, atmp, weight, tab, tf, uf, linsolve_tmp, linsolve, jac_config,
-        grad_config, reltol, alg, algebraic_vars, alg.step_limiter!, alg.stage_limiter!)
-end
-
 struct Rosenbrock23ConstantCache{T, TF, UF, JType, WType, F, AD} <:
        RosenbrockConstantCache
     c₃₂::T
@@ -238,7 +157,7 @@ struct Rosenbrock23ConstantCache{T, TF, UF, JType, WType, F, AD} <:
 end
 
 function Rosenbrock23ConstantCache(::Type{T}, tf, uf, J, W, linsolve, autodiff) where {T}
-    tab = Rosenbrock23Tableau(T)
+    tab = RosenbrockCombinedTableau(T)
     Rosenbrock23ConstantCache(tab.c₃₂, tab.d, tf, uf, J, W, linsolve, autodiff)
 end
 
@@ -268,7 +187,7 @@ struct Rosenbrock32ConstantCache{T, TF, UF, JType, WType, F, AD} <:
 end
 
 function Rosenbrock32ConstantCache(::Type{T}, tf, uf, J, W, linsolve, autodiff) where {T}
-    tab = Rosenbrock32Tableau(T)
+    tab = RosenbrockCombinedTableau(T)
     Rosenbrock32ConstantCache(tab.c₃₂, tab.d, tf, uf, J, W, linsolve, autodiff)
 end
 
@@ -832,7 +751,7 @@ function alg_cache(
 end
 
 function get_fsalfirstlast(
-        cache::Union{Rosenbrock23Cache, Rosenbrock32Cache, Rosenbrock33Cache,
+        cache::Union{RosenbrockCombinedCache, Rosenbrock33Cache,
             Rosenbrock34Cache,
             Rosenbrock4Cache},
         u)

lib/OrdinaryDiffEqRosenbrock/src/rosenbrock_interpolants.jl

@@ -1,6 +1,6 @@
 ### Fallbacks to capture
-ROSENBROCKS_WITH_INTERPOLATIONS = Union{Rosenbrock23ConstantCache, Rosenbrock23Cache,
-    Rosenbrock32ConstantCache, Rosenbrock32Cache,
+ROSENBROCKS_WITH_INTERPOLATIONS = Union{Rosenbrock23ConstantCache, RosenbrockCombinedCache,
+    Rosenbrock32ConstantCache,
     Rodas23WConstantCache, Rodas3PConstantCache,
     Rodas23WCache, Rodas3PCache,
     RosenbrockCombinedConstantCache,
@@ -46,24 +46,24 @@ end
 end
 
 @muladd function _ode_interpolant(Θ, dt, y₀, y₁, k,
-        cache::Union{Rosenbrock23Cache, Rosenbrock32Cache},
+        cache::RosenbrockCombinedCache,
         idxs::Nothing, T::Type{Val{0}}, differential_vars)
     @rosenbrock2332pre0
     @inbounds @.. y₀ + dt * (c1 * k[1] + c2 * k[2])
 end
 
 @muladd function _ode_interpolant(Θ, dt, y₀, y₁, k,
-        cache::Union{Rosenbrock23ConstantCache, Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+        cache::Union{Rosenbrock23ConstantCache, RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs, T::Type{Val{0}}, differential_vars)
     @rosenbrock2332pre0
     @.. y₀[idxs] + dt * (c1 * k[1][idxs] + c2 * k[2][idxs])
 end
 
 @muladd function _ode_interpolant!(out, Θ, dt, y₀, y₁, k,
         cache::Union{Rosenbrock23ConstantCache,
-            Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+            RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs::Nothing, T::Type{Val{0}}, differential_vars)
     @rosenbrock2332pre0
     @inbounds @.. out = y₀ + dt * (c1 * k[1] + c2 * k[2])
@@ -72,8 +72,8 @@ end
 
 @muladd function _ode_interpolant!(out, Θ, dt, y₀, y₁, k,
         cache::Union{Rosenbrock23ConstantCache,
-            Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+            RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs, T::Type{Val{0}}, differential_vars)
     @rosenbrock2332pre0
     @views @.. out = y₀[idxs] + dt * (c1 * k[1][idxs] + c2 * k[2][idxs])
@@ -88,25 +88,25 @@ end
 end
 
 @muladd function _ode_interpolant(Θ, dt, y₀, y₁, k,
-        cache::Union{Rosenbrock23ConstantCache, Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+        cache::Union{Rosenbrock23ConstantCache, RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs::Nothing, T::Type{Val{1}}, differential_vars)
     @rosenbrock2332pre1
     @.. c1diff * k[1] + c2diff * k[2]
 end
 
 @muladd function _ode_interpolant(Θ, dt, y₀, y₁, k,
-        cache::Union{Rosenbrock23ConstantCache, Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+        cache::Union{Rosenbrock23ConstantCache, RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs, T::Type{Val{1}}, differential_vars)
     @rosenbrock2332pre1
     @.. c1diff * k[1][idxs] + c2diff * k[2][idxs]
 end
 
 @muladd function _ode_interpolant!(out, Θ, dt, y₀, y₁, k,
         cache::Union{Rosenbrock23ConstantCache,
-            Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+            RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs::Nothing, T::Type{Val{1}}, differential_vars)
     @rosenbrock2332pre1
     @.. out = c1diff * k[1] + c2diff * k[2]
@@ -115,8 +115,8 @@ end
 
 @muladd function _ode_interpolant!(out, Θ, dt, y₀, y₁, k,
         cache::Union{Rosenbrock23ConstantCache,
-            Rosenbrock23Cache,
-            Rosenbrock32ConstantCache, Rosenbrock32Cache
+            RosenbrockCombinedCache,
+            Rosenbrock32ConstantCache
         }, idxs, T::Type{Val{1}}, differential_vars)
     @rosenbrock2332pre1
     @views @.. out = c1diff * k[1][idxs] + c2diff * k[2][idxs]