[dotnet] Move internal compiler services to Properties (#16653)

Author: nvborisenko

dotnet/BUILD.bazel

@@ -30,8 +30,8 @@ pkg_zip(
 filegroup(
     name = "source_files_support_needs_from_core",
     srcs = [
-        "//dotnet/src/webdriver:Internal/StringSyntaxAttribute.cs",
-        "//dotnet/src/webdriver:Internal/StringSyntaxConstants.cs",
+        "//dotnet/src/webdriver:Properties/StringSyntaxAttribute.cs",
+        "//dotnet/src/webdriver:Properties/StringSyntaxConstants.cs",
     ],
     visibility = ["__subpackages__"],
 )

dotnet/src/support/Selenium.WebDriver.Support.csproj

@@ -42,8 +42,8 @@
 
   <ItemGroup>
     <!--Workaround for being unable to have two different types of the same name in WebDriver and in Support, despite both being internal-->
-    <Compile Include="$(CsprojIncludePath)\Internal\StringSyntaxAttribute.cs" />
-    <Compile Include="$(CsprojIncludePath)\Internal\StringSyntaxConstants.cs" />
+    <Compile Include="$(CsprojIncludePath)\Properties\StringSyntaxAttribute.cs" />
+    <Compile Include="$(CsprojIncludePath)\Properties\StringSyntaxConstants.cs" />
   </ItemGroup>
 
 </Project>

dotnet/src/webdriver/BUILD.bazel

@@ -12,8 +12,8 @@ load(
 
 exports_files([
     "WebDriver.csproj",
-    "Internal/StringSyntaxAttribute.cs",
-    "Internal/StringSyntaxConstants.cs",
+    "Properties/StringSyntaxAttribute.cs",
+    "Properties/StringSyntaxConstants.cs",
 ])
 
 generated_assembly_info(

dotnet/src/webdriver/BiDi/Properties/IsExternalInit.cs renamed to dotnet/src/webdriver/Properties/IsExternalInit.cs

@@ -17,6 +17,12 @@
 // under the License.
 // </copyright>
 
+#if !NET8_0_OR_GREATER
+
+#pragma warning disable IDE0130 // Namespace does not match folder structure
 namespace System.Runtime.CompilerServices;
+#pragma warning restore IDE0130 // Namespace does not match folder structure
 
 internal static class IsExternalInit;
+
+#endif

dotnet/src/webdriver/Internal/NullableAttributes.cs renamed to dotnet/src/webdriver/Properties/NullableAttributes.cs

@@ -17,13 +17,14 @@
 // under the License.
 // </copyright>
 
-
 #if !NET8_0_OR_GREATER
 
 // Following polyfill guidance explained here https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/#targetframeworks
 // Original code in https://github.com/dotnet/runtime/blob/419e949d258ecee4c40a460fb09c66d974229623/src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/NullableAttributes.cs
 
+#pragma warning disable IDE0130 // Namespace does not match folder structure
 namespace System.Diagnostics.CodeAnalysis;
+#pragma warning restore IDE0130 // Namespace does not match folder structure
 
 /// <summary>Specifies that null is allowed as an input even if the corresponding type disallows it.</summary>
 [AttributeUsage(AttributeTargets.Field | AttributeTargets.Parameter | AttributeTargets.Property, Inherited = false)]

dotnet/src/webdriver/Internal/StringSyntaxAttribute.cs renamed to dotnet/src/webdriver/Properties/StringSyntaxAttribute.cs

@@ -19,7 +19,9 @@
 
 #if !NET8_0_OR_GREATER
 
+#pragma warning disable IDE0130 // Namespace does not match folder structure
 namespace System.Diagnostics.CodeAnalysis;
+#pragma warning restore IDE0130 // Namespace does not match folder structure
 
 /// <summary>Specifies the syntax used in a string.</summary>
 [AttributeUsage(AttributeTargets.Parameter | AttributeTargets.Field | AttributeTargets.Property, AllowMultiple = false, Inherited = false)]
@@ -86,4 +88,3 @@ public StringSyntaxAttribute(string syntax, params object?[] arguments)
 }
 
 #endif
-

dotnet/src/webdriver/Internal/StringSyntaxConstants.cs renamed to dotnet/src/webdriver/Properties/StringSyntaxConstants.cs

@@ -17,7 +17,9 @@
 // under the License.
 // </copyright>
 
-namespace OpenQA.Selenium.Internal;
+#pragma warning disable IDE0130 // Namespace does not match folder structure
+namespace OpenQA.Selenium;
+#pragma warning restore IDE0130 // Namespace does not match folder structure
 
 internal static class StringSyntaxConstants
 {

dotnet/src/webdriver/Internal/TrimmingAttributes.cs renamed to dotnet/src/webdriver/Properties/TrimmingAttributes.cs

@@ -21,7 +21,9 @@
 
 #if !NET8_0_OR_GREATER
 
+#pragma warning disable IDE0130 // Namespace does not match folder structure
 namespace System.Diagnostics.CodeAnalysis;
+#pragma warning restore IDE0130 // Namespace does not match folder structure
 
 /// <summary>
 /// Indicates that the specified method requires the ability to generate new code at runtime,